From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Mikko Rapeli <mikko.rapeli@bmw.de>, paul.eggleton@linux.microsoft.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [RFC PATCH 1/2] classes/buildhistory: record SRC_URI
Date: Wed, 28 Oct 2020 14:21:22 +0000 [thread overview]
Message-ID: <f3c0e0b9ce68c2377148e85c522d9f5003a580bc.camel@linuxfoundation.org> (raw)
In-Reply-To: <20201026064259.GT2040@korppu>
On Mon, 2020-10-26 at 06:43 +0000, Mikko Rapeli wrote:
> On Sun, Oct 18, 2020 at 09:03:56PM -0700, Paul Eggleton wrote:
> > From: Paul Eggleton <paul.eggleton@microsoft.com>
> >
> > It can be useful to record SRC_URI into buildhistory for the
> > purposes of
> > tracking exactly which sources got built (we already have SRCREV)
> > as
> > well as getting an indication when changes to the SRC_URI relate to
> > changes in the output.
> >
> > Signed-off-by: Paul Eggleton <paul.eggleton@microsoft.com>
>
> I have similar patch in our poky trees. Also have patches
> to export LICENSE and CVE_PRODUCT to buildhistory. These are used
> by some post-build QA check scripts.
>
> Acked-by: Mikko Rapeli <mikko.rapeli@bmw.de>
I'm actually fairly against some of these kinds of changes.
Buildhistory is meant to be there to highlight changes in the output
over time. Using it to create manifests and for license checking
purposes is not what it was designed for.
I just feel if the original author of the class thinks its a good idea
I need to give up :/.
Cheers,
Richard
next prev parent reply other threads:[~2020-10-28 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 4:03 [RFC PATCH 0/2] buildhistory: record SRC_URI Paul Eggleton
2020-10-19 4:03 ` [RFC PATCH 1/2] classes/buildhistory: " Paul Eggleton
2020-10-26 6:43 ` [OE-core] " Mikko Rapeli
2020-10-28 14:21 ` Richard Purdie [this message]
2020-10-29 9:18 ` Mikko Rapeli
2020-10-29 11:35 ` Richard Purdie
2020-10-19 4:03 ` [RFC PATCH 2/2] classes/buildhistory: also save recipe info for native recipes Paul Eggleton
2020-10-19 21:16 ` [OE-core] [RFC PATCH 0/2] buildhistory: record SRC_URI Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3c0e0b9ce68c2377148e85c522d9f5003a580bc.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mikko.rapeli@bmw.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox