public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [OE-core][kirkstone 0/1] Pull request
@ 2026-04-10 12:26 Yoann Congal
  2026-04-10 12:27 ` [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos Yoann Congal
  0 siblings, 1 reply; 4+ messages in thread
From: Yoann Congal @ 2026-04-10 12:26 UTC (permalink / raw)
  To: openembedded-core; +Cc: Paul Barker

This is a last minute fix about the git:// protocol migration.
It passed oe-selftest:
https://autobuilder.yoctoproject.org/valkyrie/#/builders/69/builds/209

The following changes since commit f2bc121f821f684a541b1f4e317078c50d29c389:

  scripts/install-buildtools: Update to 4.0.34 (2026-04-10 00:51:17 +0200)

are available in the Git repository at:

  https://git.openembedded.org/openembedded-core-contrib stable/kirkstone-next
  https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-next

for you to fetch changes up to b507de6d469890f14d153c0eb48361d97d24a71e:

  oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos (2026-04-10 13:26:01 +0200)

----------------------------------------------------------------

Yoann Congal (1):
  oeqa/selftest/git-submodule-test: Default to https git protocol for
    YP/OE repos

 .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++--
 meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos
  2026-04-10 12:26 [OE-core][kirkstone 0/1] Pull request Yoann Congal
@ 2026-04-10 12:27 ` Yoann Congal
  2026-04-11  7:28   ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Yoann Congal @ 2026-04-10 12:27 UTC (permalink / raw)
  To: openembedded-core; +Cc: Paul Barker

From: Yoann Congal <yoann.congal@smile.fr>

Following up on commit 139102a73d41 ("recipes: Default to https git protocol where possible"),
> The recommendation from server maintainers is that the https protocol
> is both faster and more reliable than the dedicated git protocol at this point.
> Switch to it where possible.

Use ";protocol=https" for the parent git submodule and, also, update the
SRCREV to point to a commit where submodules are reference through a
https:// URL instead of a git:// one.

Update the expected output of the archiver test.

Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
---
 .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++--
 meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb b/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb
index fa3041b7d8f..3f66cf6919d 100644
--- a/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb
+++ b/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb
@@ -5,8 +5,8 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
 
 INHIBIT_DEFAULT_DEPS = "1"
 
-SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master"
-SRCREV = "a2885dd7d25380d23627e7544b7bbb55014b16ee"
+SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master;protocol=https"
+SRCREV = "f280847494763cdcf71197557a81ba7d8a6bce42"
 
 S = "${WORKDIR}/git"
 
diff --git a/meta/lib/oeqa/selftest/cases/archiver.py b/meta/lib/oeqa/selftest/cases/archiver.py
index 75195241b79..ad2dd2dda65 100644
--- a/meta/lib/oeqa/selftest/cases/archiver.py
+++ b/meta/lib/oeqa/selftest/cases/archiver.py
@@ -301,8 +301,8 @@ class Archiver(OESelftestTestCase):
 
         bb_vars = get_bb_vars(['DEPLOY_DIR_SRC'])
         for target_file_name in [
-            'gitsmshallow_git.yoctoproject.org.git-submodule-test_a2885dd-1_master.tar.gz',
-            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_120f4c7-1.tar.gz',
+            'gitsmshallow_git.yoctoproject.org.git-submodule-test_f280847-1_master.tar.gz',
+            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_79a0efa-1.tar.gz',
             'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test2_bare_f66699e-1.tar.gz',
             'gitsmshallow_git.openembedded.org.bitbake_bare_52a144a-1.tar.gz',
             'gitsmshallow_git.openembedded.org.bitbake_bare_c39b997-1.tar.gz'


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos
  2026-04-10 12:27 ` [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos Yoann Congal
@ 2026-04-11  7:28   ` Richard Purdie
  2026-04-11  8:51     ` Yoann Congal
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2026-04-11  7:28 UTC (permalink / raw)
  To: yoann.congal, openembedded-core; +Cc: Paul Barker

On Fri, 2026-04-10 at 14:27 +0200, Yoann Congal via lists.openembedded.org wrote:
> From: Yoann Congal <yoann.congal@smile.fr>
> 
> Following up on commit 139102a73d41 ("recipes: Default to https git protocol where possible"),
> > The recommendation from server maintainers is that the https protocol
> > is both faster and more reliable than the dedicated git protocol at this point.
> > Switch to it where possible.
> 
> Use ";protocol=https" for the parent git submodule and, also, update the
> SRCREV to point to a commit where submodules are reference through a
> https:// URL instead of a git:// one.
> 
> Update the expected output of the archiver test.
> 
> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> ---
>  .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++--
>  meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb b/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb
> index fa3041b7d8f..3f66cf6919d 100644
> --- a/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb
> +++ b/meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb
> @@ -5,8 +5,8 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
>  
>  INHIBIT_DEFAULT_DEPS = "1"
>  
> -SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master"
> -SRCREV = "a2885dd7d25380d23627e7544b7bbb55014b16ee"
> +SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master;protocol=https"
> +SRCREV = "f280847494763cdcf71197557a81ba7d8a6bce42"
>  
>  S = "${WORKDIR}/git"
>  
> diff --git a/meta/lib/oeqa/selftest/cases/archiver.py b/meta/lib/oeqa/selftest/cases/archiver.py
> index 75195241b79..ad2dd2dda65 100644
> --- a/meta/lib/oeqa/selftest/cases/archiver.py
> +++ b/meta/lib/oeqa/selftest/cases/archiver.py
> @@ -301,8 +301,8 @@ class Archiver(OESelftestTestCase):
>  
>          bb_vars = get_bb_vars(['DEPLOY_DIR_SRC'])
>          for target_file_name in [
> -            'gitsmshallow_git.yoctoproject.org.git-submodule-test_a2885dd-1_master.tar.gz',
> -            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_120f4c7-1.tar.gz',
> +            'gitsmshallow_git.yoctoproject.org.git-submodule-test_f280847-1_master.tar.gz',
> +            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_79a0efa-1.tar.gz',
>              'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test2_bare_f66699e-1.tar.gz',
>              'gitsmshallow_git.openembedded.org.bitbake_bare_52a144a-1.tar.gz',
>              'gitsmshallow_git.openembedded.org.bitbake_bare_c39b997-1.tar.gz'

Does master need that? At a quick look it probably should...

I'm wondering if this should be using an isolated downloads directory
for the test and it is seeing files from previous builds?

Cheers,

Richard


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos
  2026-04-11  7:28   ` Richard Purdie
@ 2026-04-11  8:51     ` Yoann Congal
  0 siblings, 0 replies; 4+ messages in thread
From: Yoann Congal @ 2026-04-11  8:51 UTC (permalink / raw)
  To: Richard Purdie
  Cc: Patches and discussions about the oe-core layer, Paul Barker

[-- Attachment #1: Type: text/plain, Size: 3587 bytes --]

Le sam. 11 avr. 2026, 09:28, Richard Purdie <
richard.purdie@linuxfoundation.org> a écrit :

> On Fri, 2026-04-10 at 14:27 +0200, Yoann Congal via lists.openembedded.org
> wrote:
> > From: Yoann Congal <yoann.congal@smile.fr>
> >
> > Following up on commit 139102a73d41 ("recipes: Default to https git
> protocol where possible"),
> > > The recommendation from server maintainers is that the https protocol
> > > is both faster and more reliable than the dedicated git protocol at
> this point.
> > > Switch to it where possible.
> >
> > Use ";protocol=https" for the parent git submodule and, also, update the
> > SRCREV to point to a commit where submodules are reference through a
> > https:// URL instead of a git:// one.
> >
> > Update the expected output of the archiver test.
> >
> > Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> > ---
> >  .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++--
> >  meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta-selftest/recipes-test/git-submodule-test/
> git-submodule-test.bb b/meta-selftest/recipes-test/git-submodule-test/
> git-submodule-test.bb
> > index fa3041b7d8f..3f66cf6919d 100644
> > --- a/meta-selftest/recipes-test/git-submodule-test/
> git-submodule-test.bb
> > +++ b/meta-selftest/recipes-test/git-submodule-test/
> git-submodule-test.bb
> > @@ -5,8 +5,8 @@ LIC_FILES_CHKSUM =
> "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
> >
> >  INHIBIT_DEFAULT_DEPS = "1"
> >
> > -SRC_URI = "gitsm://
> git.yoctoproject.org/git-submodule-test;branch=master"
> > -SRCREV = "a2885dd7d25380d23627e7544b7bbb55014b16ee"
> > +SRC_URI = "gitsm://
> git.yoctoproject.org/git-submodule-test;branch=master;protocol=https"
> > +SRCREV = "f280847494763cdcf71197557a81ba7d8a6bce42"
> >
> >  S = "${WORKDIR}/git"
> >
> > diff --git a/meta/lib/oeqa/selftest/cases/archiver.py
> b/meta/lib/oeqa/selftest/cases/archiver.py
> > index 75195241b79..ad2dd2dda65 100644
> > --- a/meta/lib/oeqa/selftest/cases/archiver.py
> > +++ b/meta/lib/oeqa/selftest/cases/archiver.py
> > @@ -301,8 +301,8 @@ class Archiver(OESelftestTestCase):
> >
> >          bb_vars = get_bb_vars(['DEPLOY_DIR_SRC'])
> >          for target_file_name in [
> > -
> 'gitsmshallow_git.yoctoproject.org.git-submodule-test_a2885dd-1_master.tar.gz',
> > -
> 'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_120f4c7-1.tar.gz',
> > +
> 'gitsmshallow_git.yoctoproject.org.git-submodule-test_f280847-1_master.tar.gz',
> > +
> 'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_79a0efa-1.tar.gz',
> >
> 'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test2_bare_f66699e-1.tar.gz',
> >
> 'gitsmshallow_git.openembedded.org.bitbake_bare_52a144a-1.tar.gz',
> >
> 'gitsmshallow_git.openembedded.org.bitbake_bare_c39b997-1.tar.gz'
>
> Does master need that? At a quick look it probably should...
>


Yes it does need it. And this is not the only reference patched on
kirkstone that is not patch on master, I will send the series to master as
soon as possible.

>
> I'm wondering if this should be using an isolated downloads directory
> for the test and it is seeing files from previous builds?
>

Yes, surely.

But more generally, a universe fetch, on a empty dl_dir and a blocked
git:// protocol (can be done locally with a firewall rule, don't know about
doing that on AB) should be interesting...

Regards,

>
> Cheers,
>
> Richard
>

[-- Attachment #2: Type: text/html, Size: 6067 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-11  8:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-10 12:26 [OE-core][kirkstone 0/1] Pull request Yoann Congal
2026-04-10 12:27 ` [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos Yoann Congal
2026-04-11  7:28   ` Richard Purdie
2026-04-11  8:51     ` Yoann Congal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox