public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mikko Rapeli <mikko.rapeli@linaro.org>,
	Martin Jansa <martin.jansa@gmail.com>
Cc: Ross Burton <Ross.Burton@arm.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] python3-cryptography: workaround broken native functionality
Date: Tue, 20 Sep 2022 12:35:00 +0100	[thread overview]
Message-ID: <f6cfef06795de6889cb88c56b94fabd851022643.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJFpGrO8nxxovNFPK=cvoARuV=uteB2FxwofM0GMd5ok7aRw6g@mail.gmail.com>

On Tue, 2022-09-20 at 13:20 +0300, Mikko Rapeli wrote:
> Hi,
> 
> I created an issue in openssl about this:
> 
> https://github.com/openssl/openssl/issues/19242
> 
> Then I have the openssl patches in:
> 
> https://github.com/openssl/openssl/compare/master...mikkorapeli-linaro:openssl:relative_paths
> 
> The feedback so far is cold in upstream. Yes, the patches are a bit
> ugly too, but IMO so are the original code paths in openssl.
> I'll follow-up on openssl side if there is anything that could be
> improved. Comments and more feedback is welcome.
> 
> So what should we do now on oe side? python3-cryptography is
> completely broken and users really need to export at least
> 
> export OPENSSL_MODULES="${STAGING_LIBDIR_NATIVE}/ossl-modules"
> 
> or apply https://github.com/openssl/openssl/commit/a10a6c298878cf438cc8c13f5878d97f476eb0d0
> to openssl-native.
> But that still leaves config files, engines and certificate paths broken.

Are there any other ways we could patch the code? Some ideas offhand
are:

a) the paths could be relative to the main library location?

b) the paths could have a token in them with is replaced with the
library path (a bit like $ORIGIN in RPATH)?

That might be more acceptable to upstream and be a bit less invasive?

Cheers,

Richard




      reply	other threads:[~2022-09-20 11:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  9:34 [PATCH] python3-cryptography: workaround broken native functionality Mikko Rapeli
2022-09-13 10:01 ` [OE-core] " Richard Purdie
2022-09-13 10:29   ` Mikko Rapeli
2022-09-13 10:34     ` Richard Purdie
2022-09-13 11:13       ` Mikko Rapeli
2022-09-13 12:24         ` Richard Purdie
2022-09-14  8:09           ` Mikko Rapeli
2022-09-14  8:19             ` Alexander Kanavin
2022-09-14  8:43               ` Mikko Rapeli
2022-09-14  8:45                 ` Alexander Kanavin
2022-09-14  8:51                   ` Mikko Rapeli
2022-09-14  8:52                     ` Alexander Kanavin
2022-09-14  8:58             ` Richard Purdie
2022-09-15 11:17             ` Ross Burton
2022-09-15 11:26               ` Mikko Rapeli
2022-09-15 11:36                 ` Martin Jansa
2022-09-20 10:20                   ` Mikko Rapeli
2022-09-20 11:35                     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6cfef06795de6889cb88c56b94fabd851022643.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Ross.Burton@arm.com \
    --cc=martin.jansa@gmail.com \
    --cc=mikko.rapeli@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox