From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>, Ross Burton <ross@burtonini.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/5] qemu: Depend on virtual/egl
Date: Wed, 23 Mar 2022 16:30:38 +0000 [thread overview]
Message-ID: <f739e5cf67d1f7eb40a18dde20aea90ea3200d15.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1so19J5LtAcO-kc14nBWUEjqOqTGZhk3A7vhTruMkgNugA@mail.gmail.com>
On Thu, 2022-03-17 at 08:29 -0700, Khem Raj wrote:
> On Wed, Mar 9, 2022 at 4:30 AM Ross Burton <ross@burtonini.com> wrote:
> >
> > On Tue, 8 Mar 2022 at 15:52, Khem Raj <raj.khem@gmail.com> wrote:
> > > -PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/libgl"
> > > +PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/egl"
> >
> > Either the packageconfig name is wrong, or this patch is wrong: GLX is
> > explicitly big-GL not EGL.
>
> Neither seems to be wrong. see
> https://github.com/qemu/qemu/blob/master/configure#L2289-L2313
>
> It's expecting epoxy with egl. So virtual/egl is a better
> representation. Maybe we should
> add epoxy to depends section of packageconfig separately.
I think Ross' point is that the PACKAGECONFIG option could do with renaming
since it isn't GLX at all...
Cheers,
Richard
prev parent reply other threads:[~2022-03-23 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 15:52 [PATCH 1/5] qemu: Depend on virtual/egl Khem Raj
2022-03-08 15:52 ` [PATCH 2/5] libsdl2: " Khem Raj
2022-03-09 12:31 ` [OE-core] " Ross Burton
2022-03-17 14:54 ` Khem Raj
2022-03-08 15:52 ` [PATCH 3/5] piglit: Remove virtual/libgl Khem Raj
2022-03-08 15:52 ` [PATCH 4/5] waffle: Use the right dependencies as needed Khem Raj
2022-03-08 15:52 ` [PATCH 5/5] webkitgtk: Depend on virtual/egl instead of virtual/libgl Khem Raj
2022-03-09 12:30 ` [OE-core] [PATCH 1/5] qemu: Depend on virtual/egl Ross Burton
2022-03-17 15:29 ` Khem Raj
2022-03-23 16:30 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f739e5cf67d1f7eb40a18dde20aea90ea3200d15.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
--cc=ross@burtonini.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox