Re: [PATCH] libidn2: improve reproducibility

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2018-09-29 at 11:06 +0800, Hongxu Jia wrote:
> Remoe prefix ${RECIPE_SYSROOT} in libidn2.pc
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/recipes-extended/libidn/libidn2_2.0.5.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> index 0daf7a6..7a06ed3 100644
> --- a/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> +++ b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> @@ -27,3 +27,9 @@ LICENSE_${PN} = "(GPLv2+ | LGPLv3)"
>  LICENSE_${PN}-bin = "GPLv3+"
>  
>  BBCLASSEXTEND = "native nativesdk"
> +
> +PACKAGE_PREPROCESS_FUNCS += "libidn2_package_preprocess"
> +libidn2_package_preprocess () {
> +    sed -e 's@${RECIPE_SYSROOT}@@g' \
> +       -i ${PKGD}${libdir}/pkgconfig/libidn2.pc
> +}

Why is RECIPE_SYSROOT in here in the first place? Can you include the
exact issue in the commit message?

I suspect there is probably a better fix than this.

On reason I hate sed expressions like this is that the sed expression
will sit there forever as its very hard to tell if it still applies
anymore. So more detail needed and it really probably should be a patch
 of some sort.

Cheers,

Richard