Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: "Yu, Mingli" <mingli.yu@windriver.com>,
	Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: ✗ patchtest: failure for Open file with O_CLOEXEC to avoid fd leak (rev3)
Date: Mon, 20 Jan 2020 03:15:15 +0000	[thread overview]
Message-ID: <f8005a9c8aae479db77809bb1132e04c@XBOX03.axis.com> (raw)
In-Reply-To: <5E2518BC.7090306@windriver.com>

> -----Original Message-----
> From: Yu, Mingli <mingli.yu@windriver.com>
> Sent: den 20 januari 2020 04:04
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; Paul Eggleton
> <paul.eggleton@linux.intel.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] ✗ patchtest: failure for Open file with O_CLOEXEC
> to avoid fd leak (rev3)
> 
> On 01/20/20 10:28, Peter Kjellerstedt wrote:
> >> -----Original Message-----
> >> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-
> >> bounces@lists.openembedded.org> On Behalf Of Yu, Mingli
> >> Sent: den 20 januari 2020 02:34
> >> To: Paul Eggleton <paul.eggleton@linux.intel.com>
> >> Cc: openembedded-core@lists.openembedded.org
> >> Subject: Re: [OE-core] ✗ patchtest: failure for Open file with
> O_CLOEXEC
> >> to avoid fd leak (rev3)
> >>
> >> On 01/20/20 09:29, Paul Eggleton wrote:
> >>> Hi Mingli
> >>>
> >>> On Sunday, 19 January 2020 6:41:49 PM NZDT Yu, Mingli wrote:
> >>>> On 01/19/20 13:32, Patchwork wrote:
> >>>>> == Series Details ==
> >>>>>
> >>>>> Series: Open file with O_CLOEXEC to avoid fd leak (rev3)
> >>>>> Revision: 3
> >>>>> URL   : https://patchwork.openembedded.org/series/22123/
> >>>>> State : failure
> >>>>>
> >>>>> == Summary ==
> >>>>>
> >>>>>
> >>>>> Thank you for submitting this patch series to OpenEmbedded Core.
> This
> >> is
> >>>>> an automated response. Several tests have been executed on the
> >> proposed
> >>>>> series by patchtest resulting in the following failures:
> >>>>>
> >>>>>
> >>>>>
> >>>>> * Issue             Series does not apply on top of target branch
> >> [test_series_merge_on_head]
> >>>>>      Suggested fix    Rebase your series on top of targeted branch
> >>>>>      Targeted branch  master (currently at 9d7a521971)
> >>>>
> >>>> Have already rebased on the master branch of
> >>>> http://git.yoctoproject.org/cgit/cgit.cgi/pseudo/, why still issue
> out
> >>>> the above issue? Any hint?
> >>>
> >>> It's assuming that patches sent to this list are for OE-Core (which
> they
> >>> generally are). I wasn't aware but apparently the documented place to
> >>> send pseudo patches is this list, so I think in this case you can just
> >>> ignore patchtest.
> >>
> >> Okay, many thanks Paul for your hint!
> >>
> >> Thanks,
> >>
> >>>
> >>> Cheers,
> >>> Paul
> >
> > But it is probably a good idea to include a "[pseudo]" tag in the
> subject
> > when sending patches related to pseudo to this list, as the expectation
> > otherwise is that they are for OE-Core.
> 
> Thanks Peter! And already add the "pseudo_util.c" tag in the subject in
> the v3, please check the mail with the subject "[OE-core] [PATCH v3]
> pseudo_util.c: Open file with O_CLOEXEC to avoid fd leak".

That is not the same. The "pseudo_util.c:" is part of the commit subject 
and will end up in the Git repository. A "[pseudo]" tag is for anyone 
seeing the mail (possibly including patchwork and patchtest), letting 
them know that this commit is about pseudo, not OE-Core (similar to the 
"[PATCH v3]" tag, which is also information about the commit).

> Thanks,
> 
> > //Peter

//Peter


  reply	other threads:[~2020-01-20  3:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-19  3:50 [PATCH] Open file with O_CLOEXEC to avoid fd leak mingli.yu
2020-01-19  4:02 ` ✗ patchtest: failure for " Patchwork
2020-01-19  4:12 ` [PATCH v2] " mingli.yu
2020-01-19  4:32 ` ✗ patchtest: failure for Open file with O_CLOEXEC to avoid fd leak (rev2) Patchwork
2020-01-19  5:15 ` [PATCH v3] pseudo_util.c: Open file with O_CLOEXEC to avoid fd leak mingli.yu
2020-01-19  5:32 ` ✗ patchtest: failure for Open file with O_CLOEXEC to avoid fd leak (rev3) Patchwork
2020-01-19  5:41   ` Yu, Mingli
2020-01-20  1:29     ` Paul Eggleton
2020-01-20  1:34       ` Yu, Mingli
2020-01-20  2:28         ` Peter Kjellerstedt
2020-01-20  3:04           ` Yu, Mingli
2020-01-20  3:15             ` Peter Kjellerstedt [this message]
2020-01-20  3:27               ` [pseudo v4] pseudo_util.c: Open file with O_CLOEXEC to avoid fd leak mingli.yu
2020-01-20  3:27               ` ✗ patchtest: failure for Open file with O_CLOEXEC to avoid fd leak (rev3) Yu, Mingli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8005a9c8aae479db77809bb1132e04c@XBOX03.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=mingli.yu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox