public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: "Jamaluddin,
	Khairul Rohaizzat" <khairul.rohaizzat.jamaluddin@intel.com>,
	 openembedded-core@lists.openembedded.org
Cc: randy.e.witt@linux.intel.com
Subject: Re: [OE-core] [PATCH v2] wic/bootimg-efi: IMAGE_EFI_BOOT_FILES added to separate bootimg-efi and bootimg-partition
Date: Wed, 26 Aug 2020 13:28:01 +0100	[thread overview]
Message-ID: <fa0af5b0faf2194dc3932321e42004bbb1f3d7bb.camel@linuxfoundation.org> (raw)
In-Reply-To: <1598429593-16162-1-git-send-email-khairul.rohaizzat.jamaluddin@intel.com>

On Wed, 2020-08-26 at 16:13 +0800, Jamaluddin, Khairul Rohaizzat wrote:
> From: Khairul Rohaizzat Jamaluddin <
> khairul.rohaizzat.jamaluddin@intel.com>
> 
> Due to recent changes in bootimg-efi to include IMAGE_BOOT_FILES,
> when both bootimg-partition and bootimg-efi occur in a single .wks
> and IMAGE_BOOT_FILES are defined, files listed in IMAGE_BOOT_FILES
> will be duplicated in both partition.
> Since IMAGE_BOOT_FILES are crucial for bootimg-partition, but
> optional for bootimg-efi, hence allowing bootimg-efi to have the
> option
> to ignore it.
> 
> Added a new variable, IMAGE_EFI_BOOT_FILES, to handle this
> issue. Its basic usage is the same as IMAGE_BOOT_FILES.
> Usage example:
>         IMAGE_EFI_BOOT_FILES = "u-boot.img uImage;kernel"
>         IMAGE_EFI_BOOT_FILES = "u-boot.${UBOOT_SUFFIX}
> ${KERNEL_IMAGETYPE}"
> 
> This commit is also squashed with the updated testcase to cover for
> this change.
> 
> [YOCTO #14011]
> 
> Signed-off-by: Khairul Rohaizzat Jamaluddin <khairul.rohaizzat.jamaluddin@intel.com>

This looks like the right idea but it fails in testing:

https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/1280

Cheers,

Richard


  reply	other threads:[~2020-08-26 12:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26  8:13 [PATCH v2] wic/bootimg-efi: IMAGE_EFI_BOOT_FILES added to separate bootimg-efi and bootimg-partition Jamaluddin, Khairul Rohaizzat
2020-08-26 12:28 ` Richard Purdie [this message]
2020-08-27 19:39 ` [OE-core] " Randy Witt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa0af5b0faf2194dc3932321e42004bbb1f3d7bb.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=khairul.rohaizzat.jamaluddin@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=randy.e.witt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox