From: richard.purdie@linuxfoundation.org
To: Mark Hatle <mark.hatle@windriver.com>,
mingli.yu@windriver.com,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] sysklogd.inc: add syslogd.8 to ALTERNATIVE_${PN}-doc
Date: Thu, 27 Sep 2018 16:49:38 +0100 [thread overview]
Message-ID: <fa8191d7fe16aa538783377bd40e0ec8f809b8c1.camel@linuxfoundation.org> (raw)
In-Reply-To: <23abed17-72c1-e4e0-0bae-b5b35943c2a5@windriver.com>
On Thu, 2018-09-27 at 10:19 -0500, Mark Hatle wrote:
> On 9/27/18 4:36 AM, richard.purdie@linuxfoundation.org wrote:
> > On Thu, 2018-09-27 at 13:22 +0800, mingli.yu@windriver.com wrote:
> > > From: Mark Hatle <mark.hatle@windriver.com>
> > >
> > > Other recipes, such as meta-networking inetutils
> > > may also provide a man page for syslogd.8.
> > > Use the alternatives mechanism to select the man
> > > page to display.
> > >
> > > This is a partial revert of commit:
> > > 988aad01b20c18a8850db0ad6dc547525d94116c
> > >
> > > Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> > > Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> > > ---
> > > meta/recipes-extended/sysklogd/sysklogd.inc | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > I'm not sure I like the sound of this. Why would it provide a man
> > page
> > but not the actual tool itself?
> >
> > At the very least this needs a better explanation but I'm not sure
> > it
> > sounds correct or is something we want to encourage.
>
> The syslogd 'tool' is provided by both recipes in their respective 'runtime'
> packages. In the inet case, it is inetutils-syslogd, which has an appropriate
> RCONFLICTS with the syslogd version. So only one or the other will be
> installed. This is the conflict resolution the original commit of
> "988aad01b20c18a8850db0ad6dc547525d94116c" was referring to.
>
> HOWEVER, both syslogd and inetutils each only have a singular 'doc' package.
> (As do most packages it seems.) Since this is the case, there and syslogd and
> inetutils (not syslogd part) is requested for this configuration -- AND ---
> doc-pkgs are configured in, you get an error of conflicting files.
>
> Thus a partial revert of the prior work enabled documentation to be installed
> correctly.
>
> Now does the documentation match whichever package was installed, maybe not...
> but this isn't a big deal as it turns out, since most syslogd share a common set
> of arguments and those are the things a run-time user would query from the man
> pages.
>
> The only alternative is to start spliting up the docs into their relevant
> subpackages, as we have the runtime items. But this then complicates the
> doc-pkgs processing and related...
This makes much more sense with more information. Could someone rewrite
the commit message please?
Cheers,
Richard
prev parent reply other threads:[~2018-09-27 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 5:22 [PATCH] sysklogd.inc: add syslogd.8 to ALTERNATIVE_${PN}-doc mingli.yu
2018-09-27 9:36 ` richard.purdie
2018-09-27 15:19 ` Mark Hatle
2018-09-27 15:49 ` richard.purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa8191d7fe16aa538783377bd40e0ec8f809b8c1.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mark.hatle@windriver.com \
--cc=mingli.yu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox