From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Maanya Goenka <maanyagoenka@linux.microsoft.com>,
openembedded-core@lists.openembedded.org
Cc: alhe@linux.microsoft.com, Maanya Goenka <maanyagoenka@microsoft.com>
Subject: Re: [OE-core] [PATCH] usrmerge: add the distro feature to nativesdk builds when added to target and enable symlink creation for both
Date: Tue, 06 Feb 2024 10:27:42 +0000 [thread overview]
Message-ID: <fac899458e20aa7cac770ce215fc7cb4bfbce513.camel@linuxfoundation.org> (raw)
In-Reply-To: <20240201025621.1632547-2-maanyagoenka@linux.microsoft.com>
On Thu, 2024-02-01 at 02:56 +0000, Maanya Goenka wrote:
> From: Maanya Goenka <maanyagoenka@microsoft.com>
>
> Add usrmerge to DISTRO_FEATURES_FILTER_NATIVESDK (and DISTRO_FEATURES_FILTER_NATIVE for consistency),
> since we have come across cases where the distro feature would be required by both contexts.
> As a supplement to this change, when creating the merged usr symlinks at the do_populate_sdk stage,
> these need to be created for both the target and native sysroots within the SDK.
>
> Signed-off-by: Maanya Goenka <maanyagoenka@microsoft.com>
> Signed-off-by : Alejandro Hernandez Samaniego <alhe@linux.microsoft.com>
> ---
> meta/classes-recipe/image.bbclass | 2 ++
> meta/conf/bitbake.conf | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
This doesn't quite follow. "target", "nativesdk" and "native" are all
different separate filesystems and not connected. Yes, you can use
usrmerge on some (or all?) of them but you don't have to have them
match.
Forcing them to match is likely just working around an underlying issue
which needs to be fixed.
What were the real failures?
For example, this would stop native or nativesdk sstate being reused
between differently configured builds when it could be.
Cheers,
Richard
next prev parent reply other threads:[~2024-02-06 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 2:56 [PATCH] bash: nativesdk-sdk-provides-dummy RPROVIDES bash for nativesdk already so usrmerge should not Maanya Goenka
2024-02-01 2:56 ` [PATCH] usrmerge: add the distro feature to nativesdk builds when added to target and enable symlink creation for both Maanya Goenka
2024-02-06 10:03 ` [OE-core] " Alexandre Belloni
2024-02-06 10:27 ` Richard Purdie [this message]
2024-02-15 19:10 ` Alejandro Enedino Hernandez Samaniego
2024-02-15 21:08 ` Richard Purdie
2024-02-01 2:56 ` [PATCH] toolchain-shar-relocate: allow 'find' access to libraries in symlinked directories Maanya Goenka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac899458e20aa7cac770ce215fc7cb4bfbce513.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alhe@linux.microsoft.com \
--cc=maanyagoenka@linux.microsoft.com \
--cc=maanyagoenka@microsoft.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox