Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [CONSOLIDATED PULL 23/41] init-install: Clean up partition alignment
Date: Mon,  9 Jul 2012 08:47:37 -0700	[thread overview]
Message-ID: <fb978607412d3aff3512533cc4ea64ebf8ff7041.1341802889.git.sgw@linux.intel.com> (raw)
In-Reply-To: <cover.1341802889.git.sgw@linux.intel.com>
In-Reply-To: <cover.1341802889.git.sgw@linux.intel.com>

From: Darren Hart <dvhart@linux.intel.com>

The current partitioning scheme leaves a 1MB gap between all the
generated partitions by adding a 1 to the end of the last partition to
use as the start of the next. parted is smart enough to not overlap
start and end positions of the same value. This avoids the 1 MB gaps.

Rather than pad the disk with 1MB in the beginning and cut it off at the
MB boundary on the end, we can use 0% and 100% to allow parted to do the
required math and use as much of the disk as possible.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 .../initrdscripts/files/init-install.sh            |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-core/initrdscripts/files/init-install.sh b/meta/recipes-core/initrdscripts/files/init-install.sh
index 8d21dd1..0ac4949 100644
--- a/meta/recipes-core/initrdscripts/files/init-install.sh
+++ b/meta/recipes-core/initrdscripts/files/init-install.sh
@@ -84,9 +84,9 @@ disk_size=$(parted /dev/${device} unit mb print | grep Disk | cut -d" " -f 3 | s
 swap_size=$((disk_size*swap_ratio/100))
 rootfs_size=$((disk_size-boot_size-swap_size))
 
-rootfs_start=$((boot_size + 1))
+rootfs_start=$((boot_size))
 rootfs_end=$((rootfs_start+rootfs_size))
-swap_start=$((rootfs_end+1))
+swap_start=$((rootfs_end))
 
 # MMC devices are special in a couple of ways
 # 1) they use a partition prefix character 'p'
@@ -113,13 +113,13 @@ echo "Creating new partition table on /dev/${device} ..."
 parted /dev/${device} mklabel msdos
 
 echo "Creating boot partition on $bootfs"
-parted /dev/${device} mkpart primary 1 $boot_size
+parted /dev/${device} mkpart primary 0% $boot_size
 
 echo "Creating rootfs partition on $rootfs"
 parted /dev/${device} mkpart primary $rootfs_start $rootfs_end
 
 echo "Creating swap partition on $swap"
-parted /dev/${device} mkpart primary $swap_start $disk_size
+parted /dev/${device} mkpart primary $swap_start 100%
 
 parted /dev/${device} print
 
-- 
1.7.7.6




  parent reply	other threads:[~2012-07-09 15:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 15:47 [CONSOLIDATED PULL 00/41] Fixes and Updates Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 01/41] directfb: upgrade to 1.6.1 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 02/41] directfb-examples: upgrade to 1.6.0 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 03/41] libx11: upgrade to 1.5.0 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 04/41] libx11-trim: " Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 05/41] libx11-diet: " Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 06/41] libxi: upgrade to 1.6.1 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 07/41] xinput: upgrade to 1.6.0 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 08/41] pixman: upgrade to 0.26.2 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 09/41] recipes.txt: Add entries for "recipes-rt" and "recipes-support" Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 10/41] gcc-common: Don't use "is" for comparing strings, use "==" Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 11/41] gthumb: run make install in parallel Saul Wold
2012-07-09 15:50   ` Burton, Ross
2012-07-09 15:47 ` [CONSOLIDATED PULL 12/41] curl: upgrade to 7.26.0 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 13/41] apt 0.7.14: runtime error: filename too long (tmpdir length) Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 14/41] apt 0.7.14: runtime error: Method file has died unexpectedly Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 15/41] sanity.bbclass: the tmpdir can't be longer than 410 Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 16/41] startup-notification: bump PR because libxcb-util soname was changed Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 17/41] matchbox-panel-2: " Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 18/41] runqemu: fix usage() help for MACHINE setting Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 19/41] runqemu: fix support for ext4 rootfs images Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 20/41] classes/license: fix manifest to work with deb Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 21/41] init-install: Use swap_ratio in the calulation of swap_size Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 22/41] init-install: Correct ext2->ext3 typo in logging Saul Wold
2012-07-09 15:47 ` Saul Wold [this message]
2012-07-09 15:47 ` [CONSOLIDATED PULL 24/41] grub-efi: Do not use help2man Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 25/41] pseudo: Update to 1.3.1 (fixing chroot crash) Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 26/41] utils.bbclass: add helper function to add all multilib variants of a specific package Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 27/41] libxml-parser-perl_2.41.bb: fix MakeMaker issues with using wrong CC/LD/etc Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 28/41] gnutls: make sure native is patched for gettext version Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 29/41] populate_sdk_rpm: Sync multilib configuration with rootfs_rpm Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 30/41] multilib: Enable multilib remapping for SDK generation Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 31/41] package_rpm: Avoid duplicate package generation failures Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 32/41] rpm: Fix PACKAGECONFIG dependencies Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 33/41] qemu-0.15.1: add patch to fix compilatation problems on powerpc Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 34/41] packagedata.py: Fix get_subpkgedata_fn for multilib Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 35/41] bluez4: fix packaging issue after update Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 36/41] ncurses: fix packaging issue in multilib build Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 37/41] connman: remove some obviously wrong (circa early-GNOME 2?) directories from FILES Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 38/41] connman: ship the empty plugins directory in the connman package Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 39/41] kernel.bbclass: add non-santized kernel provides Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 40/41] initscripts: use update-alternative to handle file functions Saul Wold
2012-07-09 15:47 ` [CONSOLIDATED PULL 41/41] lsbinitscripts: increase ALTERNATIVE_PRIORITY Saul Wold
2012-07-09 16:04 ` [CONSOLIDATED PULL 00/41] Fixes and Updates Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb978607412d3aff3512533cc4ea64ebf8ff7041.1341802889.git.sgw@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox