Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Watt <JPEWhacker@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] classes/populate_sdk_base: Add setscene tasks
Date: Sat, 23 Oct 2021 22:16:39 +0100	[thread overview]
Message-ID: <fbc96f2c9631b7d8b36f1fac8362abd32e520197.camel@linuxfoundation.org> (raw)
In-Reply-To: <20211022214422.2176030-1-JPEWhacker@gmail.com>

On Fri, 2021-10-22 at 16:44 -0500, Joshua Watt wrote:
> do_populate_sdk was added to SSTATETASKS, but had no _setscene task
> created to allow it to actually run from sstate. Add it so that SDKs can
> be restored from sstate.
> 
> Note that like do_image_complete, do_populate_sdk is marked with
> SSTATE_SKIP_CREATION by default so sstate is not used for them; adding
> this task will allow it to work if the user overrides this default
> though.
> 
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  meta/classes/populate_sdk_base.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 49e166e697..fafdd96749 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -179,6 +179,10 @@ do_populate_sdk[cleandirs] = "${SDKDEPLOYDIR}"
>  do_populate_sdk[sstate-inputdirs] = "${SDKDEPLOYDIR}"
>  do_populate_sdk[sstate-outputdirs] = "${SDK_DEPLOY}"
>  do_populate_sdk[stamp-extra-info] = "${MACHINE_ARCH}${SDKMACHINE}"
> +python do_populate_sdk_setscene () {
> +    sstate_setscene(d)
> +}
> +addtask do_populate_sdk_setscene
>  
> 

That was deliberately missing since we don't use/need it. I've merged this since
I guess you want to use it but it isn't something I particularly want to
support. It simply won't work for eSDK either.

Cheers,

Richard



      reply	other threads:[~2021-10-23 21:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 21:44 [OE-core][PATCH] classes/populate_sdk_base: Add setscene tasks Joshua Watt
2021-10-23 21:16 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbc96f2c9631b7d8b36f1fac8362abd32e520197.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=JPEWhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox