public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] qemurunner.py: print output from runqemu/qemu-system in stop()
Date: Thu, 26 Aug 2021 13:03:45 +0100	[thread overview]
Message-ID: <fc5b311848218b5825de269d31fb08dd2e74d989.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210826114517.817267-1-alex.kanavin@gmail.com>

On Thu, 2021-08-26 at 13:45 +0200, Alexander Kanavin wrote:
> This is done when starting up qemu has failed, but is not done
> when qemu started ok, but fails later in QMP communication.
> 
> Output from runqemu does contain valuable information to find out
> why, so rather than fix all the QMP fails to include it, let's just
> print it in stop().
> 
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>  meta/lib/oeqa/utils/qemurunner.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/lib/oeqa/utils/qemurunner.py b/meta/lib/oeqa/utils/qemurunner.py
> index 5c9d2b24a3..204ad8b918 100644
> --- a/meta/lib/oeqa/utils/qemurunner.py
> +++ b/meta/lib/oeqa/utils/qemurunner.py
> @@ -535,6 +535,8 @@ class QemuRunner:
>              if self.runqemu.poll() is None:
>                  self.logger.debug("Sending SIGKILL to runqemu")
>                  os.killpg(os.getpgid(self.runqemu.pid), signal.SIGKILL)
> +            if not self.runqemu.stdout.closed:
> +                self.logger.info("Output from runqemu:\n%s" % self.getOutput(self.runqemu.stdout))
>              self.runqemu.stdin.close()
>              self.runqemu.stdout.close()
>              self.runqemu_exited = True

This isn't quite so simple I'm afraid:

https://autobuilder.yoctoproject.org/typhoon/#/builders/97/builds/3210/steps/16/logs/stdio

Cheers,

Richard


  reply	other threads:[~2021-08-26 12:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 11:45 [PATCH] qemurunner.py: print output from runqemu/qemu-system in stop() Alexander Kanavin
2021-08-26 12:03 ` Richard Purdie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-25 22:35 Alexander Kanavin
2021-08-26  9:42 ` [OE-core] " Richard Purdie
2021-08-26 10:45   ` Alexander Kanavin
2021-08-26 11:00     ` Richard Purdie
2021-08-26 11:10       ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc5b311848218b5825de269d31fb08dd2e74d989.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox