Re: [PATCH 09/13] icu: update to 58.1

Khem Raj
2016-11-02T17:22:06Z

[-- Attachment #1.1: Type: text/plain, Size: 1890 bytes --]

> On Nov 2, 2016, at 5:16 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
>
> On 1 November 2016 at 15:25, Alexander Kanavin <alexander.kanavin@linux.intel.com <mailto:alexander.kanavin@linux.intel.com>> wrote:
> The copyright for the software has been transferred to Unicode Inc from IBM,
> but the terms are same.
>
> libiculx and libicule are no longer produced as they depend on an external
> package icu-le-hb (previous versions had an option of using an internal
> implementation which now has been dropped). I have verified that icu
> dependencies in oe-core and meta-oe still build.
>
> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com <mailto:alexander.kanavin@linux.intel.com>>
>
> This breaks under musl:
>
> ../../icu/source/i18n/digitlst.cpp:67:24: fatal error: xlocale.h: No such file or directory
> # include <xlocale.h>
>
> musl doesn't have xlocale.h but does have a crippled strtod_l (doesn't actually support a passed in locale, which is the entire point of the _l functions).
>
> Upstreams such as pulseaudio have done https://bugs.freedesktop.org/attachment.cgi?id=118644 <https://bugs.freedesktop.org/attachment.cgi?id=118644> to guard the include, but I see that digitlist.cpp has an alternative branch where strtod_l isn't supported: as that function on musl is crippled maybe ICU should be told not to use it?

the _l functions were added as aliases for ABI compatibility reasons, however, it should work well and is compatible with glibc versions. however its not defined that
it should only come from xlocale.h so we should check for xlocale.h to be present on rootfs before using it.

>
> Ross
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #1.2: Type: text/html, Size: 3392 bytes --]

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]