Re: [PATCH 09/13] icu: update to 58.1

Alexander Kanavin
2016-11-08T14:48:32Z

On 11/02/2016 02:16 PM, Burton, Ross wrote:

> This breaks under musl:
>
> ../../icu/source/i18n/digitlst.cpp:67:24: fatal error: xlocale.h: No
> such file or directory
> # include <xlocale.h>
>
> musl doesn't have xlocale.h but does have a crippled strtod_l (doesn't
> actually support a passed in locale, which is the entire point of the _l
> functions).
>
> Upstreams such as pulseaudio have
> done https://bugs.freedesktop.org/attachment.cgi?id=118644 to guard the
> include, but I see that digitlist.cpp has an alternative branch where
> strtod_l isn't supported: as that function on musl is crippled maybe ICU
> should be told not to use it?

Thanks, I've forced icu to take that alternative branch (when musl is in
use) by monkey patching configure.ac; the updated patch will come with
the next batch of updates. There's no configure switch or environment
variable that will have the necessary effect.

Alex