From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by mail.openembedded.org (Postfix) with ESMTP id B442B7F2F0 for ; Fri, 27 Sep 2019 15:11:57 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id x8RFAfS9010380 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 27 Sep 2019 08:11:16 -0700 Received: from [128.224.56.209] (128.224.56.209) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.468.0; Fri, 27 Sep 2019 08:10:44 -0700 To: References: <20190927150740.22453-1-Trevor.Gamblin@windriver.com> From: Trevor Gamblin Message-ID: Date: Fri, 27 Sep 2019 11:10:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190927150740.22453-1-Trevor.Gamblin@windriver.com> Subject: Re: [PATCH] systemd.bbclass: add RMINITDIR for nativesdk builds X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2019 15:11:57 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 9/27/19 11:07 AM, Trevor Gamblin wrote: > From: Trevor Gamblin > > nativesdk builds such as nativesdk-dnf are installing systemd > service files, leading bitbake to throw installed-vs-shipped > warnings, but these are not needed in nativesdk: > > WARNING: nativesdk-dnf-4.2.2-r0 do_package: QA Issue: nativesdk-dnf: Files/directories were installed but not shipped in any package: > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.timer > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.timer > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.service > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.service > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.timer > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.service > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.timer > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.service > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.timer > /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.service > Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. > nativesdk-dnf: 13 installed and not shipped files. [installed-vs-shipped] > > Rather than have each recipe remove the files, an RMINITDIR case > for nativesdk builds should be added to systemd.bbclass. > > Signed-off-by: Trevor Gamblin > --- > meta/classes/systemd.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass > index 747055b8fa..1dca09964b 100644 > --- a/meta/classes/systemd.bbclass > +++ b/meta/classes/systemd.bbclass > @@ -231,5 +231,6 @@ python rm_sysvinit_initddir (){ > > do_install[postfuncs] += "${RMINITDIR} " > RMINITDIR_class-target = " rm_sysvinit_initddir rm_systemd_unitdir " > +RMINITDIR_class-nativesdk = " rm_sysvinit_initddir rm_systemd_unitdir " > RMINITDIR = "" > Forgot to put you guys on the original cc list. I tested this out with systemd and sysvinit in DISTRO_FEATURES with nativesdk-dnf because I was having issues with nativesdk-clang building. Switching between the two I did not see a rebuild of anything, so I think we're good to go.