From: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
To: Jose Quaresma <quaresma.jose@gmail.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v3 5/5] spirv-tools: fix identation
Date: Mon, 19 Oct 2020 08:29:21 +0000 [thread overview]
Message-ID: <fd4eccc67f224c21b957742e33988bfd@XBOX03.axis.com> (raw)
In-Reply-To: <20201017142935.3605756-5-quaresma.jose@gmail.com>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Jose Quaresma
> Sent: den 17 oktober 2020 16:30
> To: openembedded-core@lists.openembedded.org
> Cc: Jose Quaresma <quaresma.jose@gmail.com>
> Subject: [OE-core] [PATCH v3 5/5] spirv-tools: fix identation
>
> replace tabs with spaces and remove extra spaces
>
> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> ---
> meta/recipes-graphics/spir/spirv-tools_git.bb | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/meta/recipes-graphics/spir/spirv-tools_git.bb b/meta/recipes-graphics/spir/spirv-tools_git.bb
> index d1c2436cd9..8c4d4299ed 100644
> --- a/meta/recipes-graphics/spir/spirv-tools_git.bb
> +++ b/meta/recipes-graphics/spir/spirv-tools_git.bb
> @@ -9,12 +9,12 @@ SECTION = "graphics"
> S = "${WORKDIR}/git"
> DEST_DIR = "${S}/external"
> SRC_URI = "git://github.com/KhronosGroup/SPIRV-Tools.git;name=spirv-tools \
> - git://github.com/KhronosGroup/SPIRV-Headers.git;name=spirv-headers;destsuffix=${DEST_DIR}/spirv-headers \
> - git://github.com/google/effcee.git;name=effcee;destsuffix=${DEST_DIR}/effcee \
> - git://github.com/google/re2.git;name=re2;destsuffix=${DEST_DIR}/re2 \
> - git://github.com/google/googletest.git;name=googletest;destsuffix=${DEST_DIR}/googletest \
> - file://0001-Respect-CMAKE_INSTALL_LIBDIR-in-installed-CMake-file.patch \
> - file://0001-Avoid-pessimizing-std-move-3124.patch \
> + git://github.com/KhronosGroup/SPIRV-Headers.git;name=spirv-headers;destsuffix=${DEST_DIR}/spirv-headers \
> + git://github.com/google/effcee.git;name=effcee;destsuffix=${DEST_DIR}/effcee \
> + git://github.com/google/re2.git;name=re2;destsuffix=${DEST_DIR}/re2 \
> + git://github.com/google/googletest.git;name=googletest;destsuffix=${DEST_DIR}/googletest \
> + file://0001-Respect-CMAKE_INSTALL_LIBDIR-in-installed-CMake-file.patch;destsuffix=${DEST_DIR}/effcee \
> + file://0001-Avoid-pessimizing-std-move-3124.patch \
> "
> SRCREV_spirv-tools = "c413b982c316b14e784f50d941814fc737b55b4a"
> SRCREV_spirv-headers = "af64a9e826bf5bb5fcd2434dd71be1e41e922563"
> @@ -27,10 +27,10 @@ inherit cmake python3native
> EXTRA_OECMAKE += "-DSPIRV_WERROR=OFF"
>
> do_install_append() {
> - install -d ${D}/${includedir}/spirv
> - install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/1.2/* ${D}/${includedir}/spirv
> - install -d ${D}/${includedir}/spirv/unified1
> - install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/unified1/* ${D}/${includedir}/spirv/unified1
> + install -d ${D}/${includedir}/spirv
> + install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/1.2/* ${D}/${includedir}/spirv
> + install -d ${D}/${includedir}/spirv/unified1
> + install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/unified1/* ${D}/${includedir}/spirv/unified1
Shell code in OE-Core is actually expected to be indented using tabs,
so this part should be reverted. However, while you are here, you
should change "${D}/${includedir}" to "${D}${includedir}".
> }
>
> FILES_SOLIBSDEV = ""
> --
> 2.28.0
//Peter
next prev parent reply other threads:[~2020-10-19 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 14:29 [PATCH v3 1/5] spirv-tools: import from meta-oe to OE core Jose Quaresma
2020-10-17 14:29 ` [PATCH v3 2/5] spirv-tools: enable native build and install more header files Jose Quaresma
2020-10-17 14:29 ` [PATCH v3 3/5] glslang: add receipe Jose Quaresma
2020-10-17 14:29 ` [PATCH v3 4/5] shaderc: " Jose Quaresma
2020-10-17 14:29 ` [PATCH v3 5/5] spirv-tools: fix identation Jose Quaresma
2020-10-19 8:29 ` Peter Kjellerstedt [this message]
2020-10-19 10:10 ` [OE-core] " Jose Quaresma
2020-10-26 11:35 ` Jose Quaresma
2020-10-25 14:51 ` [OE-core] [PATCH v3 1/5] spirv-tools: import from meta-oe to OE core Richard Purdie
2020-10-25 16:11 ` Jose Quaresma
2020-10-25 17:59 ` Alexander Kanavin
2020-10-26 11:09 ` Jose Quaresma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd4eccc67f224c21b957742e33988bfd@XBOX03.axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=quaresma.jose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox