Re: [PATCH 1/1] allarch: disable allarch when multilib is used

[richard.purdie@linuxfoundation.org]

On Fri, 2018-08-10 at 16:14 +0800, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> Some allarch packages rdepends non-allarch packages. When multilib is
> used, it doesn't expand the dependency chain correctly, e.g.
> 
> core-image-sato -> ca-certificates(allarch) -> openssl
> 
> we expect dependency chain for lib32-core-image-sato:
> 
> lib32-core-image-sato -> ca-certificates(allarch) -> lib32-openssl
> 
> it should install lib32-openssl for ca-certificates but openssl is
> still wrongly imported.
> 
> Disable allarch when multilib is used.
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/classes/allarch.bbclass         | 4 ++++
>  meta/classes/icecc.bbclass           | 2 +-
>  meta/classes/multilib.bbclass        | 3 ++-
>  meta/classes/multilib_global.bbclass | 4 +---
>  meta/classes/package.bbclass         | 9 ++++++---
>  meta/classes/staging.bbclass         | 2 +-
>  6 files changed, 15 insertions(+), 9 deletions(-)

Looks good at a quick glance, I'll put it in for testing. 

Since I just saw it for other reasons, could you also see if we could
remove the ${DEPLOY_DIR_RPM}/noarch/ mentioned as:

# For multilib rpm the allarch packagegroup files can overwrite (in theory they're identical)
SSTATE_DUPWHITELIST = "${DEPLOY_DIR}/licenses/ ${DEPLOY_DIR_RPM}/noarch/"

from sstate.bbclass please?

Cheers,

Richard