public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Yu, Mingli" <mingli.yu@windriver.com>
To: Steve Sakoman <steve@sakoman.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][kirkstone 01/35] curl: Fix multiple CVEs
Date: Mon, 25 Jul 2022 11:32:31 +0800	[thread overview]
Message-ID: <fedbda26-96ef-2918-6291-607e9a617c81@windriver.com> (raw)
In-Reply-To: <2749916ff534aecfd2a7871268b1166e5bb5bca4.1658155579.git.steve@sakoman.com>

Ping.

Thanks,

On 7/18/22 22:48, Steve Sakoman wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> From: Robert Joslyn <robert.joslyn@redrectangle.org>
> 
> Backport fixes for:
>   * CVE-2022-32205 - https://curl.se/docs/CVE-2022-32205.html
>   * CVE-2022-32206 - https://curl.se/docs/CVE-2022-32206.html
>   * CVE-2022-32207 - https://curl.se/docs/CVE-2022-32207.html
>   * CVE-2022-32208 - https://curl.se/docs/CVE-2022-32208.html
> 
> Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>   .../curl/curl/CVE-2022-32205.patch            | 174 +++++++++++
>   .../curl/curl/CVE-2022-32206.patch            |  51 ++++
>   .../curl/curl/CVE-2022-32207.patch            | 283 ++++++++++++++++++
>   .../curl/curl/CVE-2022-32208.patch            |  67 +++++
>   meta/recipes-support/curl/curl_7.82.0.bb      |   4 +
>   5 files changed, 579 insertions(+)
>   create mode 100644 meta/recipes-support/curl/curl/CVE-2022-32205.patch
>   create mode 100644 meta/recipes-support/curl/curl/CVE-2022-32206.patch
>   create mode 100644 meta/recipes-support/curl/curl/CVE-2022-32207.patch
>   create mode 100644 meta/recipes-support/curl/curl/CVE-2022-32208.patch
> 
> diff --git a/meta/recipes-support/curl/curl/CVE-2022-32205.patch b/meta/recipes-support/curl/curl/CVE-2022-32205.patch
> new file mode 100644
> index 0000000000..165fd8af47
> --- /dev/null
> +++ b/meta/recipes-support/curl/curl/CVE-2022-32205.patch
> @@ -0,0 +1,174 @@
> +From a91c22a072cbb32e296f1efba3502f1b7775dfaf Mon Sep 17 00:00:00 2001
> +From: Daniel Stenberg <daniel@haxx.se>
> +Date: Sun, 26 Jun 2022 11:00:48 +0200
> +Subject: [PATCH] cookie: apply limits
> +
> +- Send no more than 150 cookies per request
> +- Cap the max length used for a cookie: header to 8K
> +- Cap the max number of received Set-Cookie: headers to 50
> +
> +Bug: https://curl.se/docs/CVE-2022-32205.html
> +CVE-2022-32205
> +Reported-by: Harry Sintonen
> +Closes #9048
> +
> +Upstream-Status: Backport [https://github.com/curl/curl/commit/48d7064a49148f0394]
> +Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org>
> +---
> + lib/cookie.c  | 14 ++++++++++++--
> + lib/cookie.h  | 21 +++++++++++++++++++--
> + lib/http.c    | 13 +++++++++++--
> + lib/urldata.h |  1 +
> + 4 files changed, 43 insertions(+), 6 deletions(-)
> +
> +diff --git a/lib/cookie.c b/lib/cookie.c
> +index 1b8c8f9..8a6aa1a 100644
> +--- a/lib/cookie.c
> ++++ b/lib/cookie.c
> +@@ -477,6 +477,10 @@ Curl_cookie_add(struct Curl_easy *data,
> +   (void)data;
> + #endif
> +
> ++  DEBUGASSERT(MAX_SET_COOKIE_AMOUNT <= 255); /* counter is an unsigned char */
> ++  if(data->req.setcookies >= MAX_SET_COOKIE_AMOUNT)
> ++    return NULL;
> ++
> +   /* First, alloc and init a new struct for it */
> +   co = calloc(1, sizeof(struct Cookie));
> +   if(!co)
> +@@ -816,7 +820,7 @@ Curl_cookie_add(struct Curl_easy *data,
> +       freecookie(co);
> +       return NULL;
> +     }
> +-
> ++    data->req.setcookies++;
> +   }
> +   else {
> +     /*
> +@@ -1354,7 +1358,8 @@ static struct Cookie *dup_cookie(struct Cookie *src)
> +  *
> +  * It shall only return cookies that haven't expired.
> +  */
> +-struct Cookie *Curl_cookie_getlist(struct CookieInfo *c,
> ++struct Cookie *Curl_cookie_getlist(struct Curl_easy *data,
> ++                                   struct CookieInfo *c,
> +                                    const char *host, const char *path,
> +                                    bool secure)
> + {
> +@@ -1409,6 +1414,11 @@ struct Cookie *Curl_cookie_getlist(struct CookieInfo *c,
> +             mainco = newco;
> +
> +             matches++;
> ++            if(matches >= MAX_COOKIE_SEND_AMOUNT) {
> ++              infof(data, "Included max number of cookies (%u) in request!",
> ++                    matches);
> ++              break;
> ++            }
> +           }
> +           else
> +             goto fail;
> +diff --git a/lib/cookie.h b/lib/cookie.h
> +index 0ffe08e..7411980 100644
> +--- a/lib/cookie.h
> ++++ b/lib/cookie.h
> +@@ -81,10 +81,26 @@ struct CookieInfo {
> + */
> + #define MAX_COOKIE_LINE 5000
> +
> +-/* This is the maximum length of a cookie name or content we deal with: */
> ++/* Maximum length of an incoming cookie name or content we deal with. Longer
> ++   cookies are ignored. */
> + #define MAX_NAME 4096
> + #define MAX_NAME_TXT "4095"
> +
> ++/* Maximum size for an outgoing cookie line libcurl will use in an http
> ++   request. This is the default maximum length used in some versions of Apache
> ++   httpd. */
> ++#define MAX_COOKIE_HEADER_LEN 8190
> ++
> ++/* Maximum number of cookies libcurl will send in a single request, even if
> ++   there might be more cookies that match. One reason to cap the number is to
> ++   keep the maximum HTTP request within the maximum allowed size. */
> ++#define MAX_COOKIE_SEND_AMOUNT 150
> ++
> ++/* Maximum number of Set-Cookie: lines accepted in a single response. If more
> ++   such header lines are received, they are ignored. This value must be less
> ++   than 256 since an unsigned char is used to count. */
> ++#define MAX_SET_COOKIE_AMOUNT 50
> ++
> + struct Curl_easy;
> + /*
> +  * Add a cookie to the internal list of cookies. The domain and path arguments
> +@@ -97,7 +113,8 @@ struct Cookie *Curl_cookie_add(struct Curl_easy *data,
> +                                const char *domain, const char *path,
> +                                bool secure);
> +
> +-struct Cookie *Curl_cookie_getlist(struct CookieInfo *c, const char *host,
> ++struct Cookie *Curl_cookie_getlist(struct Curl_easy *data,
> ++                                   struct CookieInfo *c, const char *host,
> +                                    const char *path, bool secure);
> + void Curl_cookie_freelist(struct Cookie *cookies);
> + void Curl_cookie_clearall(struct CookieInfo *cookies);
> +diff --git a/lib/http.c b/lib/http.c
> +index 4433824..2c8b0c4 100644
> +--- a/lib/http.c
> ++++ b/lib/http.c
> +@@ -2709,12 +2709,14 @@ CURLcode Curl_http_bodysend(struct Curl_easy *data, struct connectdata *conn,
> + }
> +
> + #if !defined(CURL_DISABLE_COOKIES)
> ++
> + CURLcode Curl_http_cookies(struct Curl_easy *data,
> +                            struct connectdata *conn,
> +                            struct dynbuf *r)
> + {
> +   CURLcode result = CURLE_OK;
> +   char *addcookies = NULL;
> ++  bool linecap = FALSE;
> +   if(data->set.str[STRING_COOKIE] &&
> +      !Curl_checkheaders(data, STRCONST("Cookie")))
> +     addcookies = data->set.str[STRING_COOKIE];
> +@@ -2732,7 +2734,7 @@ CURLcode Curl_http_cookies(struct Curl_easy *data,
> +         !strcmp(host, "127.0.0.1") ||
> +         !strcmp(host, "[::1]") ? TRUE : FALSE;
> +       Curl_share_lock(data, CURL_LOCK_DATA_COOKIE, CURL_LOCK_ACCESS_SINGLE);
> +-      co = Curl_cookie_getlist(data->cookies, host, data->state.up.path,
> ++      co = Curl_cookie_getlist(data, data->cookies, host, data->state.up.path,
> +                                secure_context);
> +       Curl_share_unlock(data, CURL_LOCK_DATA_COOKIE);
> +     }
> +@@ -2746,6 +2748,13 @@ CURLcode Curl_http_cookies(struct Curl_easy *data,
> +             if(result)
> +               break;
> +           }
> ++          if((Curl_dyn_len(r) + strlen(co->name) + strlen(co->value) + 1) >=
> ++             MAX_COOKIE_HEADER_LEN) {
> ++            infof(data, "Restricted outgoing cookies due to header size, "
> ++                  "'%s' not sent", co->name);
> ++            linecap = TRUE;
> ++            break;
> ++          }
> +           result = Curl_dyn_addf(r, "%s%s=%s", count?"; ":"",
> +                                  co->name, co->value);
> +           if(result)
> +@@ -2756,7 +2765,7 @@ CURLcode Curl_http_cookies(struct Curl_easy *data,
> +       }
> +       Curl_cookie_freelist(store);
> +     }
> +-    if(addcookies && !result) {
> ++    if(addcookies && !result && !linecap) {
> +       if(!count)
> +         result = Curl_dyn_addn(r, STRCONST("Cookie: "));
> +       if(!result) {
> +diff --git a/lib/urldata.h b/lib/urldata.h
> +index e006495..54faf7d 100644
> +--- a/lib/urldata.h
> ++++ b/lib/urldata.h
> +@@ -707,6 +707,7 @@ struct SingleRequest {
> + #ifndef CURL_DISABLE_DOH
> +   struct dohdata *doh; /* DoH specific data for this request */
> + #endif
> ++  unsigned char setcookies;
> +   BIT(header);        /* incoming data has HTTP header */
> +   BIT(content_range); /* set TRUE if Content-Range: was found */
> +   BIT(upload_done);   /* set to TRUE when doing chunked transfer-encoding
> diff --git a/meta/recipes-support/curl/curl/CVE-2022-32206.patch b/meta/recipes-support/curl/curl/CVE-2022-32206.patch
> new file mode 100644
> index 0000000000..25f5b27cc7
> --- /dev/null
> +++ b/meta/recipes-support/curl/curl/CVE-2022-32206.patch
> @@ -0,0 +1,51 @@
> +From e12531340b03d242d3f892aa8797faf12b56dddf Mon Sep 17 00:00:00 2001
> +From: Daniel Stenberg <daniel@haxx.se>
> +Date: Mon, 16 May 2022 16:28:13 +0200
> +Subject: [PATCH] content_encoding: return error on too many compression steps
> +
> +The max allowed steps is arbitrarily set to 5.
> +
> +Bug: https://curl.se/docs/CVE-2022-32206.html
> +CVE-2022-32206
> +Reported-by: Harry Sintonen
> +Closes #9049
> +
> +Upstream-Status: Backport [https://github.com/curl/curl/commit/3a09fbb7f264c67c43]
> +Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org>
> +---
> + lib/content_encoding.c | 9 +++++++++
> + 1 file changed, 9 insertions(+)
> +
> +diff --git a/lib/content_encoding.c b/lib/content_encoding.c
> +index c03637a..6f994b3 100644
> +--- a/lib/content_encoding.c
> ++++ b/lib/content_encoding.c
> +@@ -1026,12 +1026,16 @@ static const struct content_encoding *find_encoding(const char *name,
> +   return NULL;
> + }
> +
> ++/* allow no more than 5 "chained" compression steps */
> ++#define MAX_ENCODE_STACK 5
> ++
> + /* Set-up the unencoding stack from the Content-Encoding header value.
> +  * See RFC 7231 section 3.1.2.2. */
> + CURLcode Curl_build_unencoding_stack(struct Curl_easy *data,
> +                                      const char *enclist, int maybechunked)
> + {
> +   struct SingleRequest *k = &data->req;
> ++  int counter = 0;
> +
> +   do {
> +     const char *name;
> +@@ -1066,6 +1070,11 @@ CURLcode Curl_build_unencoding_stack(struct Curl_easy *data,
> +       if(!encoding)
> +         encoding = &error_encoding;  /* Defer error at stack use. */
> +
> ++      if(++counter >= MAX_ENCODE_STACK) {
> ++        failf(data, "Reject response due to %u content encodings",
> ++              counter);
> ++        return CURLE_BAD_CONTENT_ENCODING;
> ++      }
> +       /* Stack the unencoding stage. */
> +       writer = new_unencoding_writer(data, encoding, k->writer_stack);
> +       if(!writer)
> diff --git a/meta/recipes-support/curl/curl/CVE-2022-32207.patch b/meta/recipes-support/curl/curl/CVE-2022-32207.patch
> new file mode 100644
> index 0000000000..bc16b62f39
> --- /dev/null
> +++ b/meta/recipes-support/curl/curl/CVE-2022-32207.patch
> @@ -0,0 +1,283 @@
> +From 759088694e2ba68ddc5ffe042b071dadad6ff675 Mon Sep 17 00:00:00 2001
> +From: Daniel Stenberg <daniel@haxx.se>
> +Date: Wed, 25 May 2022 10:09:53 +0200
> +Subject: [PATCH] fopen: add Curl_fopen() for better overwriting of files
> +
> +Bug: https://curl.se/docs/CVE-2022-32207.html
> +CVE-2022-32207
> +Reported-by: Harry Sintonen
> +Closes #9050
> +
> +Upstream-Status: Backport [https://github.com/curl/curl/commit/20f9dd6bae50b]
> +Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org>
> +---
> + CMakeLists.txt          |   1 +
> + configure.ac            |   1 +
> + lib/Makefile.inc        |   2 +
> + lib/cookie.c            |  19 ++-----
> + lib/curl_config.h.cmake |   3 ++
> + lib/fopen.c             | 113 ++++++++++++++++++++++++++++++++++++++++
> + lib/fopen.h             |  30 +++++++++++
> + 7 files changed, 154 insertions(+), 15 deletions(-)
> + create mode 100644 lib/fopen.c
> + create mode 100644 lib/fopen.h
> +
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index b77de6d..a0bfaad 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -1027,6 +1027,7 @@ elseif(HAVE_LIBSOCKET)
> +   set(CMAKE_REQUIRED_LIBRARIES socket)
> + endif()
> +
> ++check_symbol_exists(fchmod        "${CURL_INCLUDES}" HAVE_FCHMOD)
> + check_symbol_exists(basename      "${CURL_INCLUDES}" HAVE_BASENAME)
> + check_symbol_exists(socket        "${CURL_INCLUDES}" HAVE_SOCKET)
> + check_symbol_exists(select        "${CURL_INCLUDES}" HAVE_SELECT)
> +diff --git a/configure.ac b/configure.ac
> +index d431870..7433bb9 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -3351,6 +3351,7 @@ AC_CHECK_DECLS([getpwuid_r], [], [AC_DEFINE(HAVE_DECL_GETPWUID_R_MISSING, 1, "Se
> +
> +
> + AC_CHECK_FUNCS([fnmatch \
> ++  fchmod \
> +   geteuid \
> +   getpass_r \
> +   getppid \
> +diff --git a/lib/Makefile.inc b/lib/Makefile.inc
> +index e8f110f..5139b03 100644
> +--- a/lib/Makefile.inc
> ++++ b/lib/Makefile.inc
> +@@ -133,6 +133,7 @@ LIB_CFILES =         \
> +   escape.c           \
> +   file.c             \
> +   fileinfo.c         \
> ++  fopen.c            \
> +   formdata.c         \
> +   ftp.c              \
> +   ftplistparser.c    \
> +@@ -263,6 +264,7 @@ LIB_HFILES =         \
> +   escape.h           \
> +   file.h             \
> +   fileinfo.h         \
> ++  fopen.h            \
> +   formdata.h         \
> +   ftp.h              \
> +   ftplistparser.h    \
> +diff --git a/lib/cookie.c b/lib/cookie.c
> +index 8a6aa1a..cb0c03b 100644
> +--- a/lib/cookie.c
> ++++ b/lib/cookie.c
> +@@ -96,8 +96,8 @@ Example set of cookies:
> + #include "curl_get_line.h"
> + #include "curl_memrchr.h"
> + #include "parsedate.h"
> +-#include "rand.h"
> + #include "rename.h"
> ++#include "fopen.h"
> +
> + /* The last 3 #include files should be in this order */
> + #include "curl_printf.h"
> +@@ -1620,20 +1620,9 @@ static CURLcode cookie_output(struct Curl_easy *data,
> +     use_stdout = TRUE;
> +   }
> +   else {
> +-    unsigned char randsuffix[9];
> +-
> +-    if(Curl_rand_hex(data, randsuffix, sizeof(randsuffix)))
> +-      return 2;
> +-
> +-    tempstore = aprintf("%s.%s.tmp", filename, randsuffix);
> +-    if(!tempstore)
> +-      return CURLE_OUT_OF_MEMORY;
> +-
> +-    out = fopen(tempstore, FOPEN_WRITETEXT);
> +-    if(!out) {
> +-      error = CURLE_WRITE_ERROR;
> ++    error = Curl_fopen(data, filename, &out, &tempstore);
> ++    if(error)
> +       goto error;
> +-    }
> +   }
> +
> +   fputs("# Netscape HTTP Cookie File\n"
> +@@ -1680,7 +1669,7 @@ static CURLcode cookie_output(struct Curl_easy *data,
> +   if(!use_stdout) {
> +     fclose(out);
> +     out = NULL;
> +-    if(Curl_rename(tempstore, filename)) {
> ++    if(tempstore && Curl_rename(tempstore, filename)) {
> +       unlink(tempstore);
> +       error = CURLE_WRITE_ERROR;
> +       goto error;
> +diff --git a/lib/curl_config.h.cmake b/lib/curl_config.h.cmake
> +index d2a0f43..c254359 100644
> +--- a/lib/curl_config.h.cmake
> ++++ b/lib/curl_config.h.cmake
> +@@ -157,6 +157,9 @@
> + /* Define to 1 if you have the <assert.h> header file. */
> + #cmakedefine HAVE_ASSERT_H 1
> +
> ++/* Define to 1 if you have the `fchmod' function. */
> ++#cmakedefine HAVE_FCHMOD 1
> ++
> + /* Define to 1 if you have the `basename' function. */
> + #cmakedefine HAVE_BASENAME 1
> +
> +diff --git a/lib/fopen.c b/lib/fopen.c
> +new file mode 100644
> +index 0000000..ad3691b
> +--- /dev/null
> ++++ b/lib/fopen.c
> +@@ -0,0 +1,113 @@
> ++/***************************************************************************
> ++ *                                  _   _ ____  _
> ++ *  Project                     ___| | | |  _ \| |
> ++ *                             / __| | | | |_) | |
> ++ *                            | (__| |_| |  _ <| |___
> ++ *                             \___|\___/|_| \_\_____|
> ++ *
> ++ * Copyright (C) 1998 - 2022, Daniel Stenberg, <daniel@haxx.se>, et al.
> ++ *
> ++ * This software is licensed as described in the file COPYING, which
> ++ * you should have received as part of this distribution. The terms
> ++ * are also available at https://curl.se/docs/copyright.html.
> ++ *
> ++ * You may opt to use, copy, modify, merge, publish, distribute and/or sell
> ++ * copies of the Software, and permit persons to whom the Software is
> ++ * furnished to do so, under the terms of the COPYING file.
> ++ *
> ++ * This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
> ++ * KIND, either express or implied.
> ++ *
> ++ * SPDX-License-Identifier: curl
> ++ *
> ++ ***************************************************************************/
> ++
> ++#include "curl_setup.h"
> ++
> ++#if !defined(CURL_DISABLE_COOKIES) || !defined(CURL_DISABLE_ALTSVC) ||  \
> ++  !defined(CURL_DISABLE_HSTS)
> ++
> ++#ifdef HAVE_FCNTL_H
> ++#include <fcntl.h>
> ++#endif
> ++
> ++#include "urldata.h"
> ++#include "rand.h"
> ++#include "fopen.h"
> ++/* The last 3 #include files should be in this order */
> ++#include "curl_printf.h"
> ++#include "curl_memory.h"
> ++#include "memdebug.h"
> ++
> ++/*
> ++ * Curl_fopen() opens a file for writing with a temp name, to be renamed
> ++ * to the final name when completed. If there is an existing file using this
> ++ * name at the time of the open, this function will clone the mode from that
> ++ * file.  if 'tempname' is non-NULL, it needs a rename after the file is
> ++ * written.
> ++ */
> ++CURLcode Curl_fopen(struct Curl_easy *data, const char *filename,
> ++                    FILE **fh, char **tempname)
> ++{
> ++  CURLcode result = CURLE_WRITE_ERROR;
> ++  unsigned char randsuffix[9];
> ++  char *tempstore = NULL;
> ++  struct_stat sb;
> ++  int fd = -1;
> ++  *tempname = NULL;
> ++
> ++  if(stat(filename, &sb) == -1 || !S_ISREG(sb.st_mode)) {
> ++    /* a non-regular file, fallback to direct fopen() */
> ++    *fh = fopen(filename, FOPEN_WRITETEXT);
> ++    if(*fh)
> ++      return CURLE_OK;
> ++    goto fail;
> ++  }
> ++
> ++  result = Curl_rand_hex(data, randsuffix, sizeof(randsuffix));
> ++  if(result)
> ++    goto fail;
> ++
> ++  tempstore = aprintf("%s.%s.tmp", filename, randsuffix);
> ++  if(!tempstore) {
> ++    result = CURLE_OUT_OF_MEMORY;
> ++    goto fail;
> ++  }
> ++
> ++  result = CURLE_WRITE_ERROR;
> ++  fd = open(tempstore, O_WRONLY | O_CREAT | O_EXCL, 0600);
> ++  if(fd == -1)
> ++    goto fail;
> ++
> ++#ifdef HAVE_FCHMOD
> ++  {
> ++    struct_stat nsb;
> ++    if((fstat(fd, &nsb) != -1) &&
> ++       (nsb.st_uid == sb.st_uid) && (nsb.st_gid == sb.st_gid)) {
> ++      /* if the user and group are the same, clone the original mode */
> ++      if(fchmod(fd, sb.st_mode) == -1)
> ++        goto fail;
> ++    }
> ++  }
> ++#endif
> ++
> ++  *fh = fdopen(fd, FOPEN_WRITETEXT);
> ++  if(!*fh)
> ++    goto fail;
> ++
> ++  *tempname = tempstore;
> ++  return CURLE_OK;
> ++
> ++fail:
> ++  if(fd != -1) {
> ++    close(fd);
> ++    unlink(tempstore);
> ++  }
> ++
> ++  free(tempstore);
> ++
> ++  *tempname = NULL;
> ++  return result;
> ++}
> ++
> ++#endif /* ! disabled */
> +diff --git a/lib/fopen.h b/lib/fopen.h
> +new file mode 100644
> +index 0000000..289e55f
> +--- /dev/null
> ++++ b/lib/fopen.h
> +@@ -0,0 +1,30 @@
> ++#ifndef HEADER_CURL_FOPEN_H
> ++#define HEADER_CURL_FOPEN_H
> ++/***************************************************************************
> ++ *                                  _   _ ____  _
> ++ *  Project                     ___| | | |  _ \| |
> ++ *                             / __| | | | |_) | |
> ++ *                            | (__| |_| |  _ <| |___
> ++ *                             \___|\___/|_| \_\_____|
> ++ *
> ++ * Copyright (C) 1998 - 2022, Daniel Stenberg, <daniel@haxx.se>, et al.
> ++ *
> ++ * This software is licensed as described in the file COPYING, which
> ++ * you should have received as part of this distribution. The terms
> ++ * are also available at https://curl.se/docs/copyright.html.
> ++ *
> ++ * You may opt to use, copy, modify, merge, publish, distribute and/or sell
> ++ * copies of the Software, and permit persons to whom the Software is
> ++ * furnished to do so, under the terms of the COPYING file.
> ++ *
> ++ * This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
> ++ * KIND, either express or implied.
> ++ *
> ++ * SPDX-License-Identifier: curl
> ++ *
> ++ ***************************************************************************/
> ++
> ++CURLcode Curl_fopen(struct Curl_easy *data, const char *filename,
> ++                    FILE **fh, char **tempname);
> ++
> ++#endif
> diff --git a/meta/recipes-support/curl/curl/CVE-2022-32208.patch b/meta/recipes-support/curl/curl/CVE-2022-32208.patch
> new file mode 100644
> index 0000000000..9a4e398370
> --- /dev/null
> +++ b/meta/recipes-support/curl/curl/CVE-2022-32208.patch
> @@ -0,0 +1,67 @@
> +From fd2ffddec315c029e923e6e6f2c049809d01a5fc Mon Sep 17 00:00:00 2001
> +From: Daniel Stenberg <daniel@haxx.se>
> +Date: Thu, 9 Jun 2022 09:27:24 +0200
> +Subject: [PATCH] krb5: return error properly on decode errors
> +
> +Bug: https://curl.se/docs/CVE-2022-32208.html
> +CVE-2022-32208
> +Reported-by: Harry Sintonen
> +Closes #9051
> +
> +Upstream-Status: Backport [https://github.com/curl/curl/commit/6ecdf5136b52af7]
> +Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org>
> +---
> + lib/krb5.c | 18 +++++++++++-------
> + 1 file changed, 11 insertions(+), 7 deletions(-)
> +
> +diff --git a/lib/krb5.c b/lib/krb5.c
> +index 787137c..6f9e1f7 100644
> +--- a/lib/krb5.c
> ++++ b/lib/krb5.c
> +@@ -140,11 +140,8 @@ krb5_decode(void *app_data, void *buf, int len,
> +   enc.value = buf;
> +   enc.length = len;
> +   maj = gss_unwrap(&min, *context, &enc, &dec, NULL, NULL);
> +-  if(maj != GSS_S_COMPLETE) {
> +-    if(len >= 4)
> +-      strcpy(buf, "599 ");
> ++  if(maj != GSS_S_COMPLETE)
> +     return -1;
> +-  }
> +
> +   memcpy(buf, dec.value, dec.length);
> +   len = curlx_uztosi(dec.length);
> +@@ -506,6 +503,7 @@ static CURLcode read_data(struct connectdata *conn,
> + {
> +   int len;
> +   CURLcode result;
> ++  int nread;
> +
> +   result = socket_read(fd, &len, sizeof(len));
> +   if(result)
> +@@ -514,7 +512,10 @@ static CURLcode read_data(struct connectdata *conn,
> +   if(len) {
> +     /* only realloc if there was a length */
> +     len = ntohl(len);
> +-    buf->data = Curl_saferealloc(buf->data, len);
> ++    if(len > CURL_MAX_INPUT_LENGTH)
> ++      len = 0;
> ++    else
> ++      buf->data = Curl_saferealloc(buf->data, len);
> +   }
> +   if(!len || !buf->data)
> +     return CURLE_OUT_OF_MEMORY;
> +@@ -522,8 +523,11 @@ static CURLcode read_data(struct connectdata *conn,
> +   result = socket_read(fd, buf->data, len);
> +   if(result)
> +     return result;
> +-  buf->size = conn->mech->decode(conn->app_data, buf->data, len,
> +-                                 conn->data_prot, conn);
> ++  nread = conn->mech->decode(conn->app_data, buf->data, len,
> ++                             conn->data_prot, conn);
> ++  if(nread < 0)
> ++    return CURLE_RECV_ERROR;
> ++  buf->size = (size_t)nread;
> +   buf->index = 0;
> +   return CURLE_OK;
> + }
> diff --git a/meta/recipes-support/curl/curl_7.82.0.bb b/meta/recipes-support/curl/curl_7.82.0.bb
> index d5dfe62a39..67de0220c6 100644
> --- a/meta/recipes-support/curl/curl_7.82.0.bb
> +++ b/meta/recipes-support/curl/curl_7.82.0.bb
> @@ -24,6 +24,10 @@ SRC_URI = "https://curl.se/download/${BP}.tar.xz \
>              file://CVE-2022-27782-1.patch \
>              file://CVE-2022-27782-2.patch \
>              file://0001-openssl-fix-CN-check-error-code.patch \
> +           file://CVE-2022-32205.patch \
> +           file://CVE-2022-32206.patch \
> +           file://CVE-2022-32207.patch \
> +           file://CVE-2022-32208.patch \
>              "
>   SRC_URI[sha256sum] = "0aaa12d7bd04b0966254f2703ce80dd5c38dbbd76af0297d3d690cdce58a583c"
> 
> --
> 2.25.1
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168201): https://lists.openembedded.org/g/openembedded-core/message/168201
> Mute This Topic: https://lists.openembedded.org/mt/92460238/3618448
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mingli.yu@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


  reply	other threads:[~2022-07-25  3:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 14:48 [OE-core][kirkstone 00/35] Patch review Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 01/35] curl: Fix multiple CVEs Steve Sakoman
2022-07-25  3:32   ` Yu, Mingli [this message]
2022-07-25 14:18     ` Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 02/35] harfbuzz: Fix compilation with clang Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 03/35] udev-extraconf/initrdscripts/parted: Rename mount.blacklist -> mount.ignorelist Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 04/35] udev-extraconf: let automount base directory configurable Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 05/35] udev-extraconf/mount.sh: add LABELs to mountpoints Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 06/35] udev-extraconf/mount.sh: save mount name in our tmp filecache Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 07/35] udev-extraconf/mount.sh: only mount devices on hotplug Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 08/35] udev-extraconf: force systemd-udevd to use shared MountFlags Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 09/35] udev-extraconf/mount.sh: ignore lvm in automount Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 10/35] udev-extraconf: fix some systemd automount issues Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 11/35] udev-extraconf:mount.sh: fix path mismatching issues Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 12/35] python3: Backport patch to fix an issue in subinterpreters Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 13/35] package.bbclass: Fix base directory for debugsource files when using externalsrc Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 14/35] package.bbclass: Avoid stripping signed kernel modules in splitdebuginfo Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 15/35] package.bbclass: Fix kernel source handling when not using externalsrc Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 16/35] insane: Fix buildpaths test to work with special devices Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 17/35] waffle: correctly request wayland-scanner executable Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 18/35] lua: Fix multilib buildpath reproducibility issues Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 19/35] vala: Fix on target wrapper buildpaths issue Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 20/35] libmodule-build-perl: Use env utility to find perl interpreter Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 21/35] gtk-doc: Remove hardcoded buildpath Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 22/35] perl: don't install Makefile.old into perl-ptest Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 23/35] alsa-state: correct license Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 24/35] kernel-arch: Fix buildpaths leaking into external module compiles Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 25/35] devtool: ignore pn- overrides when determining SRC_URI overrides Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 26/35] bin_package: install into base_prefix Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 27/35] patch: handle if S points to a subdirectory of a git repo Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 28/35] devtool: finish: handle patching when S points to subdir " Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 29/35] oe-selftest: devtool: test modify git recipe building from a subdir Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 30/35] gcc-runtime: Fix build when using gold Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 31/35] gcc-runtime: Fix missing MLPREFIX in debug mappings Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 32/35] selftest/runtime_test/virgl: Disable for all almalinux Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 33/35] cargo_common.bbclass: enable bitbake vendoring for externalsrc Steve Sakoman
2022-07-18 14:48 ` [OE-core][kirkstone 34/35] externalsrc.bbclass: support crate fetcher on externalsrc Steve Sakoman
2022-07-18 14:49 ` [OE-core][kirkstone 35/35] pulseaudio: add m4-native to DEPENDS Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fedbda26-96ef-2918-6291-607e9a617c81@windriver.com \
    --to=mingli.yu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox