public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: adrian.freihofer@gmail.com
To: Enguerrand de Ribaucourt
	<enguerrand.de-ribaucourt@savoirfairelinux.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/5] devtool: ide_sdk: Use bitbake's python3 for generated scripts
Date: Tue, 20 Feb 2024 10:03:19 +0100	[thread overview]
Message-ID: <ff4b525bfe4e97abc41975a354784cc1f25f44a1.camel@gmail.com> (raw)
In-Reply-To: <20240219165525.714512-2-enguerrand.de-ribaucourt@savoirfairelinux.com>

On Mon, 2024-02-19 at 17:55 +0100, Enguerrand de Ribaucourt wrote:
> The generated scripts use the sys.path configuration found inside
> bitbake. It can be a different python version than the one used on
> the
> host through the IDE.
> 
> For instance, when running the generated script
> deploy_target_cmake-example-core2-64 from an eSDK generated on
> another
> machine, I got the following exception:
>     AssertionError: SRE module mismatch
> 
> We need to match the sys.executable to the sys.path.
> 
> Signed-off-by: Enguerrand de Ribaucourt
> <enguerrand.de-ribaucourt@savoirfairelinux.com>
> ---
>  scripts/lib/devtool/ide_sdk.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/devtool/ide_sdk.py
> b/scripts/lib/devtool/ide_sdk.py
> index 3986dc1436a..14679744807 100755
> --- a/scripts/lib/devtool/ide_sdk.py
> +++ b/scripts/lib/devtool/ide_sdk.py
> @@ -750,7 +750,7 @@ class RecipeModified:
>          does not need to start a bitbake server. All information
> from tinfoil
>          is hard-coded in the generated script.
>          """
> -        cmd_lines = ['#!/usr/bin/env python3']
> +        cmd_lines = ['#!%s' % str(sys.executable)]
>          cmd_lines.append('import sys')
>          cmd_lines.append('devtool_sys_path = %s' % str(sys.path))
>          cmd_lines.append('devtool_sys_path.reverse()')

LGTM.

Adrian


  reply	other threads:[~2024-02-20  9:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 16:55 [PATCH v2 0/5] devtool: ide: Improve VSCode support Enguerrand de Ribaucourt
2024-02-19 16:55 ` [PATCH v2 1/5] devtool: ide_sdk: Use bitbake's python3 for generated scripts Enguerrand de Ribaucourt
2024-02-20  9:03   ` adrian.freihofer [this message]
2024-02-19 16:55 ` [PATCH v2 2/5] devtool: code: Add source mapping for debug source files Enguerrand de Ribaucourt
2024-02-20  9:01   ` adrian.freihofer
2024-02-21 14:12     ` Enguerrand de Ribaucourt
2024-02-21 14:56       ` Enguerrand de Ribaucourt
2024-02-22 13:00         ` adrian.freihofer
2024-02-22 15:51           ` Enguerrand de Ribaucourt
2024-02-25 20:52             ` adrian.freihofer
2024-02-19 16:55 ` [PATCH v2 3/5] devtool: ide: vscode: Configure read-only files Enguerrand de Ribaucourt
2024-02-20  9:05   ` adrian.freihofer
2024-02-19 16:55 ` [PATCH v2 4/5] meson: use absolute cross-compiler paths Enguerrand de Ribaucourt
2024-02-20 12:54   ` [OE-core] " Richard Purdie
2024-02-19 16:55 ` [PATCH v2 5/5] devtool: code: Provide a generic C++ configuration Enguerrand de Ribaucourt
2024-02-20  9:20   ` adrian.freihofer
2024-02-20  9:27     ` Enguerrand de Ribaucourt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff4b525bfe4e97abc41975a354784cc1f25f44a1.camel@gmail.com \
    --to=adrian.freihofer@gmail.com \
    --cc=enguerrand.de-ribaucourt@savoirfairelinux.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox