Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 1/1] sanity.bbclass: fix splitting on newlines of SANITY_TESTED_DISTROS
Date: Thu,  1 Sep 2011 12:36:12 +0100	[thread overview]
Message-ID: <ff51425aa7ce3a4fd4f9329ff1df5e47774f56e0.1314876902.git.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <cover.1314876902.git.paul.eggleton@linux.intel.com>
In-Reply-To: <cover.1314876902.git.paul.eggleton@linux.intel.com>

This variable should be split with \n sequences and these need to be
specified literally in the string. A corrected version of the example
given in the original commit (OE-core rev
75e3875341ddc8940e9ee2ccbbb2ec18194a68e6):

SANITY_TESTED_DISTROS = " \
        Ubuntu 11.04 \n \
        Fedora release 14 (Laughlin) \n \
        "

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 37b9028..44b0688 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -149,7 +149,7 @@ def check_supported_distro(e):
                 finally:
                     f.close()
     if distro:
-        if distro not in [x.strip() for x in tested_distros.split('\n')]:
+        if distro not in [x.strip() for x in tested_distros.split('\\n')]:
             bb.warn('Host distribution "%s" has not been validated with this version of the build system; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.' % distro)
     else:
         bb.warn('Host distribution could not be determined; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.')
-- 
1.7.4.1




  reply	other threads:[~2011-09-01 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01 11:36 [PATCH 0/1] Minor fix for SANITY_TESTED_DISTROS feature Paul Eggleton
2011-09-01 11:36 ` Paul Eggleton [this message]
2011-09-02 17:28   ` [PATCH 1/1] sanity.bbclass: fix splitting on newlines of SANITY_TESTED_DISTROS Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff51425aa7ce3a4fd4f9329ff1df5e47774f56e0.1314876902.git.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox