Re: [PATCH 3/8] [rpm] force a configure before make distclean

[Mark Hatle <mark.hatle@windriver.com>]

On 8/23/16 11:54 AM, Burton, Ross wrote:
> 
> On 23 August 2016 at 08:25, Jérémy Rosen <jeremy.rosen@smile.fr
> <mailto:jeremy.rosen@smile.fr>> wrote:
> 
>     -       ( cd ${S}/syck ; set +e ; rm -- -l* ; make distclean ) || :
>     +       ( cd ${S}/syck ; set +e ; rm -- -l* ; ./configure ; make distclean )
>     || :
> 
> 
> Running configure without all the options it needs to actually work just so that
> distclean works in a subbuild that shouldn't be breaking on rebuilds because we
> have out of tree builds scares me a little.
> 
> Mark, you added this line, can you remember what it was for?

The syck version can be preconfigured, and if it is -- it's wrong.

The 'set +e' is specifically in there to ALLOW it to fail.

If it is configured, we much remove the junk and clean it.. if it's not been
configured, we ignore the make distclean failure.

So I'm not sure why it is necessary to make the change.  'Failure is permitted',
and make distclean shouldn't be using any 'BUILD_CC' values from prior builds...
since it's only wiping everything that MAY have been previously built and leaked
into the release archive.

--Mark

> Ross