Re: [OE-core] [RFC PATCH 1/5] attr: Fix the ptest path to test-driver

[Ola x Nilsson <ola.x.nilsson@axis.com>]

On Tue, Nov 12 2024, Richard Purdie wrote:

> On Mon, 2024-11-11 at 09:35 +0100, Ola x Nilsson via lists.openembedded.org wrote:
>> From: Ola x Nilsson <olani@axis.com>
>> 
>> Add a sed substitution for ${PTEST_PATH}/Makefile that transforms
>>  TEST_LOG_DRIVER = $(SHELL) $(top_srcdir)/build-aux/test-driver
>> to
>>  TEST_LOG_DRIVER = $(SHELL) $(top_builddir)/build-aux/test-driver
>> which is where the test-driver script can be found when installed.
>> 
>> There used to be an oe-core automake patch to do this, but it
>> broke non-ptest use of automake.
>> 
>> Relates to [YOCTO #15635]
>> ---
>>  meta/recipes-support/attr/attr.inc | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> Your patches are missing Signed-off-by lines. There is also a
> consistent ptest failure in acl:
>
> https://valkyrie.yoctoproject.org/#/builders/61/builds/366
> https://valkyrie.yoctoproject.org/#/builders/73/builds/366
> https://valkyrie.yoctoproject.org/#/builders/73/builds/367

I've found two recipes in meta-openembedded where ptests will fail if
the patch is removed.  Patches for those were just sent to openembedded-devel.

I don't understand the issue with acl.  The error in the log looks just
like if the updated sed substitution was not done.  I have not been able
to reproduce this, but I'll keep trying.

I've resent the series as v2 with Signed-off-by lines, but no other
changes.  


/Ola