From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: "Burton\, Ross" <ross.burton@intel.com>
Cc: Christopher Larson <clarson@kergoth.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] sanity: removed broken compiler check
Date: Tue, 22 Nov 2016 13:16:57 +0100 [thread overview]
Message-ID: <lyk2bvn1za.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <CAJTo0LYMQP__k=as6kbPtuU=JK8ZeJ4ucOdTw8NDoefO-+upPw@mail.gmail.com> (Ross Burton's message of "Tue, 22 Nov 2016 12:11:26 +0000")
"Burton, Ross" <ross.burton@intel.com> writes:
>> Is this check really so useful? gcc + g++ are elementary tools which can
>> be expected.
>
> But they're not if BUILD_CC is overridden. For example if the host gcc is
> actually too old/new for OE to work and BUILD_CC has been set to point at a
> different compiler.
then, you will see a '<your-gcc>: command not found' very early in the
build and every developer knows that '<your-gcc>' could not be found.
When a misconfiguration is difficulty to detect or causes hidden breakage,
sanity checks are important.
But in this case, the check causes much more harm than it tries to solve
(it will trigger e.g. for 'gcc -m32' too).
Enrico
next prev parent reply other threads:[~2016-11-22 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 11:39 [PATCH] sanity: removed broken compiler check Enrico Scholz
2016-11-22 3:22 ` Christopher Larson
2016-11-22 11:11 ` Enrico Scholz
2016-11-22 11:42 ` Burton, Ross
2016-11-22 12:01 ` Enrico Scholz
2016-11-22 12:11 ` Burton, Ross
2016-11-22 12:16 ` Enrico Scholz [this message]
2016-11-22 20:33 ` Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lyk2bvn1za.fsf@ensc-virt.intern.sigma-chemnitz.de \
--to=enrico.scholz@sigma-chemnitz.de \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox