From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: "Ross Burton via lists.openembedded.org"
<ross.burton=arm.com@lists.openembedded.org>
Cc: openembedded-core@lists.openembedded.org, ross.burton@arm.com
Subject: Re: [OE-core] [PATCH 8/9] classes/cargo-c: pass flags via CARGO_BUILD_FLAGS
Date: Thu, 17 Sep 2026 18:31:06 +0200 [thread overview]
Message-ID: <lytsnnzvp1.fsf@ensc-pc.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <20260804165803.598030-8-ross.burton@arm.com> (Ross Burton via lists openembedded org's message of "Tue, 4 Aug 2026 17:58:02 +0100")
"Ross Burton via lists.openembedded.org"
<ross.burton=arm.com@lists.openembedded.org> writes:
> Add the flags to CARGO_BUILD_FLAGS so that they get used in all calls
> and do_install no longer does any building.
>
> +CARGO_BUILD_FLAGS += "\
> + --destdir ${D} \
> + --prefix ${prefix} \
> + --libdir ${libdir} \
> + --library-type cdylib \
> + "
Most/all of these flags are not supported by cargo and will break recipes
which use it directly (e.g. by inheriting the ptest-cargo class):
| ERROR: ... do_compile_ptest_cargo: Unable to compile test with cargo, '.../cargo build ... --destdir ...' failed
It would be better to define and use a dedicated variable
(e.g. CARGO_C_BUILD_FLAGS).
Enrico
next prev parent reply other threads:[~2026-09-17 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 16:57 [PATCH 1/9] classes/cargo_common: move PKG_CONFIG_ALLOW_CROSS export to oe_cargo_fix_env Ross Burton
2026-08-04 16:57 ` [PATCH 2/9] classes/rust: remove unused variables Ross Burton
2026-08-04 16:57 ` [PATCH 3/9] classes/cargo: move general assignments to cargo_common.bbclass Ross Burton
2026-08-04 16:57 ` [PATCH 4/9] classes/cargo: consolidate dependencies Ross Burton
2026-08-05 9:02 ` [OE-core] " Mathieu Dubois-Briand
2026-08-04 16:57 ` [PATCH 5/9] rust: clean up dependencies Ross Burton
2026-08-04 16:58 ` [PATCH 6/9] classes/cargo_c: inherit cargo_common Ross Burton
2026-08-04 16:58 ` [PATCH 7/9] classes/cargo-c: remove CARGO_C_BUILD/CARGO_C_INSTALL variables Ross Burton
2026-08-04 16:58 ` [PATCH 8/9] classes/cargo-c: pass flags via CARGO_BUILD_FLAGS Ross Burton
2026-09-17 16:31 ` Enrico Scholz [this message]
2026-09-23 16:55 ` [OE-core] " Ross Burton
2026-09-23 17:17 ` Enrico Scholz
2026-08-04 16:58 ` [PATCH 9/9] classes/cargo: merge oe_cargo_build into cargo_do_compile Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lytsnnzvp1.fsf@ensc-pc.intern.sigma-chemnitz.de \
--to=enrico.scholz@sigma-chemnitz.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton=arm.com@lists.openembedded.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox