Re: [PATCH 7/8] oe-git-proxy.sh: Add a new comprehensive git proxy script

Darren Hart
2013-02-05T19:34:25Z

On 02/05/2013 11:08 AM, Enrico Scholz wrote:
> Otavio Salvador <otavio@ossystems.com.br> writes:
>
>> Please give it a try in dash as well.
>
> fwiw, what's the point in writing such scripts plain sh? I guess. every
> machine where this script is running has /bin/bash and performance is
> not critical for it. Using '#! /bin/bash' shebang fixes the problem
> where sh is non bash.
>
> Some constructs in the scripts can be expressed mor efficiently in bash
> (e.g. the '... | sed' statements, or using arrays for the arguments).

Indeed, in fact I had to remove the bash parameter expansions
(substrings, etc) I had in my original script in order to make it
dash-able. I hate dash and personally find it to be completely
pointless, but for better or worse, people like it and there is an
expectation that scripts run in both dash and bash in OE-core.

If RP tells me a #!/bin/bash is acceptable, I'll restore the bashisms in
a heartbeat.

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel