Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] util-linux: Use PACKAGECONFIG to control pam and system config options
Date: Thu, 25 Jul 2013 17:58:57 +0200	[thread overview]
Message-ID: <lyy58uljge.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <4F2BF532-D3A4-431E-8905-E4F33FBF80D5@dominion.thruhere.net> (Koen Kooi's message of "Thu, 25 Jul 2013 15:02:20 +0200")

Koen Kooi <koen-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>
writes:

>     The ??= operator is too weak
> ...
> -PACKAGECONFIG_class-target ??= "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)} \
> +PACKAGECONFIG_class-target ?= "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \
>                                  ${@base_contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} "

good to see that I am not the only one hitting this problem.  But does
there exist some explanation for this behavior?  Lots of other packages
have

| PACKAGECONFIG ??=

and it seems to work there.  It might be related to the '_class-target'
override but that's a nasty, unpredictable bug causing silent breakage.

Something like

| localconfig = ""
| localconfig_class-target = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}...
|
| PACKAGECONFIG ??= "${localconfig}"

and forbidding '??' in override-constructs might make things clearer.


Enrico


      parent reply	other threads:[~2013-07-25 15:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 23:10 [PATCH v2] util-linux: Use PACKAGECONFIG to control pam and system config options Saul Wold
2013-07-10 16:26 ` Enrico Scholz
2013-07-25 12:58   ` Koen Kooi
2013-07-25 13:02     ` Koen Kooi
2013-07-25 14:17       ` Saul Wold
2013-07-25 15:58       ` Enrico Scholz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lyy58uljge.fsf@ensc-virt.intern.sigma-chemnitz.de \
    --to=enrico.scholz@sigma-chemnitz.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox