* [PATCH v2 08/13] selftest: imagefeatures: skip bmap test in case of poky-tiny
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Poky-tiny distro cannot execute bmap test because ext4 filesystem
is used, so skip test in this is the case.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/imagefeatures.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta/lib/oeqa/selftest/imagefeatures.py b/meta/lib/oeqa/selftest/imagefeatures.py
index a61510b..6e00fe9 100644
--- a/meta/lib/oeqa/selftest/imagefeatures.py
+++ b/meta/lib/oeqa/selftest/imagefeatures.py
@@ -111,7 +111,10 @@ class ImageFeatures(oeSelfTest):
Author: Ed Bartosh <ed.bartosh@linux.intel.com>
"""
- features = 'IMAGE_FSTYPES += " ext4 ext4.bmap"'
+ ext4_features = "ext4 ext4.bmap"
+ features = 'IMAGE_FSTYPES += " %s"' % ext4_features
+ if self.distro == 'poky-tiny':
+ self.skipTest('Features (%s) not supported for poky-tiny' % ext4_features)
self.write_config(features)
image_name = 'core-image-minimal'
--
2.1.4
^ permalink raw reply related
* [PATCH v2 07/13] selftest: imagefeatures: skip tests in case distro feature is missing
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
core-image-clutter and core-image-weston, both required opengl in distro
features, skip relevant tests if this is not the case.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/imagefeatures.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/lib/oeqa/selftest/imagefeatures.py b/meta/lib/oeqa/selftest/imagefeatures.py
index d015c49..a61510b 100644
--- a/meta/lib/oeqa/selftest/imagefeatures.py
+++ b/meta/lib/oeqa/selftest/imagefeatures.py
@@ -78,6 +78,8 @@ class ImageFeatures(oeSelfTest):
"""
# Build a core-image-clutter
+ if 'opengl' not in get_bb_var('DISTRO_FEATURES'):
+ self.skipTest('opengl not present on DISTRO_FEATURES so core-image-clutter cannot be built')
bitbake('core-image-clutter')
@testcase(1117)
@@ -96,6 +98,8 @@ class ImageFeatures(oeSelfTest):
self.write_config(features)
# Build a core-image-weston
+ if 'opengl' not in get_bb_var('DISTRO_FEATURES'):
+ self.skipTest('opengl not present on DISTRO_FEATURES so core-image-weston cannot be built')
bitbake('core-image-weston')
def test_bmap(self):
--
2.1.4
^ permalink raw reply related
* [PATCH v2 06/13] selftest: devtool: use mraa instead of libmatchbox to lessen distro requirements
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
libmatchbox requires x11 distro feature to be present, so use another recipe
(mraa) with no extra requirements, allowing test execution of all supported
distros.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/devtool.py | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/meta/lib/oeqa/selftest/devtool.py b/meta/lib/oeqa/selftest/devtool.py
index 7db286f..6fb54dd 100644
--- a/meta/lib/oeqa/selftest/devtool.py
+++ b/meta/lib/oeqa/selftest/devtool.py
@@ -340,12 +340,11 @@ class DevtoolTests(DevtoolBase):
@testcase(1161)
def test_devtool_add_fetch_git(self):
- # Fetch source
tempdir = tempfile.mkdtemp(prefix='devtoolqa')
self.track_for_cleanup(tempdir)
- url = 'git://git.yoctoproject.org/libmatchbox'
- checkrev = '462f0652055d89c648ddd54fd7b03f175c2c6973'
- testrecipe = 'libmatchbox2'
+ url = 'gitsm://git.yoctoproject.org/mraa'
+ checkrev = 'ae127b19a50aa54255e4330ccfdd9a5d058e581d'
+ testrecipe = 'mraa'
srcdir = os.path.join(tempdir, testrecipe)
# Test devtool add
self.track_for_cleanup(self.workspacedir)
@@ -353,7 +352,7 @@ class DevtoolTests(DevtoolBase):
self.add_command_to_tearDown('bitbake-layers remove-layer */workspace')
result = runCmd('devtool add %s %s -a -f %s' % (testrecipe, srcdir, url))
self.assertTrue(os.path.exists(os.path.join(self.workspacedir, 'conf', 'layer.conf')), 'Workspace directory not created: %s' % result.output)
- self.assertTrue(os.path.isfile(os.path.join(srcdir, 'configure.ac')), 'Unable to find configure.ac in source directory')
+ self.assertTrue(os.path.isfile(os.path.join(srcdir, 'imraa', 'imraa.c')), 'Unable to find configure.ac in source directory')
# Test devtool status
result = runCmd('devtool status')
self.assertIn(testrecipe, result.output)
@@ -363,7 +362,7 @@ class DevtoolTests(DevtoolBase):
self.assertIn('_git.bb', recipefile, 'Recipe file incorrectly named')
checkvars = {}
checkvars['S'] = '${WORKDIR}/git'
- checkvars['PV'] = '1.12+git${SRCPV}'
+ checkvars['PV'] = '1.0+git${SRCPV}'
checkvars['SRC_URI'] = url
checkvars['SRCREV'] = '${AUTOREV}'
self._test_recipe_contents(recipefile, checkvars, [])
@@ -372,7 +371,7 @@ class DevtoolTests(DevtoolBase):
shutil.rmtree(srcdir)
url_rev = '%s;rev=%s' % (url, checkrev)
result = runCmd('devtool add %s %s -f "%s" -V 1.5' % (testrecipe, srcdir, url_rev))
- self.assertTrue(os.path.isfile(os.path.join(srcdir, 'configure.ac')), 'Unable to find configure.ac in source directory')
+ self.assertTrue(os.path.isfile(os.path.join(srcdir, 'imraa', 'imraa.c')), 'Unable to find imraa/imraa.c in source directory')
# Test devtool status
result = runCmd('devtool status')
self.assertIn(testrecipe, result.output)
@@ -580,6 +579,8 @@ class DevtoolTests(DevtoolBase):
@testcase(1378)
def test_devtool_modify_virtual(self):
+ if self.distro == 'poky-tiny':
+ self.skipTest('Test not possible with poky-tiny because it requires a libx11 provider')
# Try modifying a virtual recipe
virtrecipe = 'virtual/libx11'
realrecipe = 'libx11'
@@ -1013,6 +1014,8 @@ class DevtoolTests(DevtoolBase):
@testcase(1379)
def test_devtool_extract_virtual(self):
+ if self.distro == 'poky-tiny':
+ self.skipTest('Test not possible with poky-tiny because it requires a libx11 provider')
tempdir = tempfile.mkdtemp(prefix='devtoolqa')
# Try devtool extract
self.track_for_cleanup(tempdir)
--
2.1.4
^ permalink raw reply related
* [PATCH v2 05/13] selftest: buildoptions: skip test in case features are missing
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
The sato image needs opengl and x11 as distro features, so skip
test if this is not the case.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/buildoptions.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/lib/oeqa/selftest/buildoptions.py b/meta/lib/oeqa/selftest/buildoptions.py
index b228c56..25d14f7 100644
--- a/meta/lib/oeqa/selftest/buildoptions.py
+++ b/meta/lib/oeqa/selftest/buildoptions.py
@@ -43,8 +43,9 @@ class ImageOptionsTests(oeSelfTest):
@testcase(1435)
def test_read_only_image(self):
- if self.distro == 'poky-tiny':
- self.skipTest('core-image-sato is not buildable with poky-tiny')
+ distro_features = get_bb_var('DISTRO_FEATURES')
+ if not ('x11' in distro_features and 'opengl' in distro_features):
+ self.skipTest('core-image-sato requires x11 and opengl in distro features')
self.write_config('IMAGE_FEATURES += "read-only-rootfs"')
bitbake("core-image-sato")
# do_image will fail if there are any pending postinsts
--
2.1.4
^ permalink raw reply related
* [PATCH v2 04/13] selftest: buildoptions: skip read-only-image test depending on distro
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Poky-tiny cannot build core-image-sato, so skip test (read-only-image)
in this case.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/buildoptions.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/lib/oeqa/selftest/buildoptions.py b/meta/lib/oeqa/selftest/buildoptions.py
index 9487898..b228c56 100644
--- a/meta/lib/oeqa/selftest/buildoptions.py
+++ b/meta/lib/oeqa/selftest/buildoptions.py
@@ -43,6 +43,8 @@ class ImageOptionsTests(oeSelfTest):
@testcase(1435)
def test_read_only_image(self):
+ if self.distro == 'poky-tiny':
+ self.skipTest('core-image-sato is not buildable with poky-tiny')
self.write_config('IMAGE_FEATURES += "read-only-rootfs"')
bitbake("core-image-sato")
# do_image will fail if there are any pending postinsts
--
2.1.4
^ permalink raw reply related
* [PATCH v2 03/13] selftest: bbtests: run non-gplv3 test only on relevant distros
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
The non-gplv3 test makes sense just for poky and poky-tiny distros which
include only non-gplv3 packages, thus skip other distros.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/bbtests.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/lib/oeqa/selftest/bbtests.py b/meta/lib/oeqa/selftest/bbtests.py
index 08cc401..370e6e5 100644
--- a/meta/lib/oeqa/selftest/bbtests.py
+++ b/meta/lib/oeqa/selftest/bbtests.py
@@ -229,6 +229,10 @@ INHERIT_remove = \"report-error\"
@testcase(1119)
def test_non_gplv3(self):
+ supported_distros = ['poky', 'poky-tiny']
+ if self.distro not in supported_distros:
+ self.skipTest('Test considers only %s distros' % ','.join(supported_distros))
+
data = 'INCOMPATIBLE_LICENSE = "GPLv3"'
conf = os.path.join(self.builddir, 'conf/local.conf')
ftools.append_file(conf ,data)
--
2.1.4
^ permalink raw reply related
* [PATCH v2 02/13] selftest: bbtests: use minimal image so all distros can execute it
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
poky-tiny distro cannot build full-cmdline image, so use an image
(core-image-minimal) that can be built in all distros.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/bbtests.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/lib/oeqa/selftest/bbtests.py b/meta/lib/oeqa/selftest/bbtests.py
index baae1e0..08cc401 100644
--- a/meta/lib/oeqa/selftest/bbtests.py
+++ b/meta/lib/oeqa/selftest/bbtests.py
@@ -114,11 +114,11 @@ class BitbakeTests(oeSelfTest):
@testcase(167)
def test_bitbake_g(self):
- result = bitbake('-g core-image-full-cmdline')
+ result = bitbake('-g core-image-minimal')
for f in ['pn-buildlist', 'pn-depends.dot', 'package-depends.dot', 'task-depends.dot']:
self.addCleanup(os.remove, f)
self.assertTrue('NOTE: PN build list saved to \'pn-buildlist\'' in result.output, msg = "No dependency \"pn-buildlist\" file was generated for the given task target. bitbake output: %s" % result.output)
- self.assertTrue('openssh' in ftools.read_file(os.path.join(self.builddir, 'pn-buildlist')), msg = "No \"openssh\" dependency found in pn-buildlist file.")
+ self.assertTrue('busybox' in ftools.read_file(os.path.join(self.builddir, 'pn-buildlist')), msg = "No \"busybox\" dependency found in pn-buildlist file.")
@testcase(899)
def test_image_manifest(self):
--
2.1.4
^ permalink raw reply related
* [PATCH v2 01/13] selftest: base: new object member to store the DISTRO value
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:58 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1480020435.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Instead of quering it multiple times, query once and use it on
test method skip checks. Also, rename current distro sstate object
member to a more meaninful name.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/selftest/base.py | 1 +
meta/lib/oeqa/selftest/sstate.py | 10 +++++-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/meta/lib/oeqa/selftest/base.py b/meta/lib/oeqa/selftest/base.py
index 26c93f9..b477db3 100644
--- a/meta/lib/oeqa/selftest/base.py
+++ b/meta/lib/oeqa/selftest/base.py
@@ -41,6 +41,7 @@ class oeSelfTest(unittest.TestCase):
self.testinc_path, self.testinc_bblayers_path,
self.machineinc_path, self.localconf_backup,
self.local_bblayers_backup]
+ self.distro = get_bb_var('DISTRO')
super(oeSelfTest, self).__init__(methodName)
def setUp(self):
diff --git a/meta/lib/oeqa/selftest/sstate.py b/meta/lib/oeqa/selftest/sstate.py
index 5989724..d27a45c 100644
--- a/meta/lib/oeqa/selftest/sstate.py
+++ b/meta/lib/oeqa/selftest/sstate.py
@@ -14,8 +14,8 @@ class SStateBase(oeSelfTest):
def setUpLocal(self):
self.temp_sstate_location = None
self.sstate_path = get_bb_var('SSTATE_DIR')
- self.distro = get_bb_var('NATIVELSBSTRING')
- self.distro_specific_sstate = os.path.join(self.sstate_path, self.distro)
+ self.hostdistro = get_bb_var('NATIVELSBSTRING')
+ self.distro_specific_sstate = os.path.join(self.sstate_path, self.hostdistro)
# Creates a special sstate configuration with the option to add sstate mirrors
def config_sstate(self, temp_sstate_location=False, add_local_mirrors=[]):
@@ -27,8 +27,8 @@ class SStateBase(oeSelfTest):
self.append_config(config_temp_sstate)
self.track_for_cleanup(temp_sstate_path)
self.sstate_path = get_bb_var('SSTATE_DIR')
- self.distro = get_bb_var('NATIVELSBSTRING')
- self.distro_specific_sstate = os.path.join(self.sstate_path, self.distro)
+ self.hostdistro = get_bb_var('NATIVELSBSTRING')
+ self.distro_specific_sstate = os.path.join(self.sstate_path, self.hostdistro)
if add_local_mirrors:
config_set_sstate_if_not_set = 'SSTATE_MIRRORS ?= ""'
@@ -42,7 +42,7 @@ class SStateBase(oeSelfTest):
def search_sstate(self, filename_regex, distro_specific=True, distro_nonspecific=True):
result = []
for root, dirs, files in os.walk(self.sstate_path):
- if distro_specific and re.search("%s/[a-z0-9]{2}$" % self.distro, root):
+ if distro_specific and re.search("%s/[a-z0-9]{2}$" % self.hostdistro, root):
for f in files:
if re.search(filename_regex, f):
result.append(f)
--
2.1.4
^ permalink raw reply related
* [PATCH v2 00/13] Skip selftests depending on distro and its features
From: leonardo.sandoval.gonzalez @ 2016-11-24 20:55 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1476462963.git.leonardo.sandoval.gonzalez@linux.intel.com>
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Originally, the selftests were defined for the 'poky' distro. However, there
are more supported distros, including nodistro, poky-lsb and poky-tiny.
These series takes into consideration the distro name and its features
to skip certain tests.
[YOCTO #8525]
The following changes since commit 12a0ee049e453b6d0d2ce2f3fa981d1b6e02bd78:
dev-manual: Added note about RPM not dealing with post-install (2016-11-23 11:10:35 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib lsandov1/oe-selftest-distro-agnostic
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=lsandov1/oe-selftest-distro-agnostic
Leonardo Sandoval (13):
selftest: base: new object member to store the DISTRO value
selftest: bbtests: use minimal image so all distros can execute it
selftest: bbtests: run non-gplv3 test only on relevant distros
selftest: buildoptions: skip read-only-image test depending on distro
selftest: buildoptions: skip test in case features are missing
selftest: devtool: use mraa instead of libmatchbox to lessen distro
requirements
selftest: imagefeatures: skip tests in case distro feature is missing
selftest: imagefeatures: skip bmap test in case of poky-tiny
selftest: recipetool: use mraa instead of libmatchbox to lessen distro
requirements
selftest: runtime-test: skip image-install test for poky-tiny
selftest: sstatetests: skip methods in case of poky-tiny or opengl is
missing
selftest: wic: skip tests for poky-tiny distro policy
selftest: bblayers: remove linux kernel checks for show-recipes check
meta/lib/oeqa/selftest/base.py | 1 +
meta/lib/oeqa/selftest/bblayers.py | 6 +---
meta/lib/oeqa/selftest/bbtests.py | 8 +++--
meta/lib/oeqa/selftest/buildoptions.py | 3 ++
meta/lib/oeqa/selftest/devtool.py | 17 ++++++----
meta/lib/oeqa/selftest/imagefeatures.py | 9 +++++-
meta/lib/oeqa/selftest/recipetool.py | 27 ++++++++++------
meta/lib/oeqa/selftest/runtime-test.py | 2 ++
meta/lib/oeqa/selftest/sstate.py | 10 +++---
meta/lib/oeqa/selftest/sstatetests.py | 57 ++++++++++++++++++++++++++++-----
meta/lib/oeqa/selftest/wic.py | 9 ++++++
11 files changed, 112 insertions(+), 37 deletions(-)
--
2.1.4
^ permalink raw reply
* Re: [PATCH 2/2] base-passwd: set root's default password to 'root'
From: Paul Eggleton @ 2016-11-24 18:59 UTC (permalink / raw)
To: Patrick Ohly, Robert Yang; +Cc: openembedded-core
In-Reply-To: <1479973589.6873.15.camel@intel.com>
On Thu, 24 Nov 2016 08:46:29 Patrick Ohly wrote:
> On Thu, 2016-11-24 at 11:38 +0800, Robert Yang wrote:
> > Currently, debug-tweaks is in EXTRA_IMAGE_FEATURES by default for poky,
> > and
> > there is no passwd, so that user can login easily without a passwd, I
> > think
> > that current status is more unsafe ?
>
> Both well-known password and no password are unsafe. User "root" with
> password "root" is not even "more" safe already now, because tools that
> brute-force logins try that. Choosing something else would be a bit
> safer for a short while until the tools add it to their dictionary.
>
> Poky is also targeting a different audience than OE-core. Poky can
> assume to be used in a secure environment, OE-core can't (because it
> might be used for all kinds of devices).
I don't think that's part of the design goals on either side, it's simply
about making development easier. The feature is clearly labelled "debug-
tweaks" because it's for debugging not for production. It could be that we
should make it do other things like append a notice to /etc/issue to avoid
people leaving it on for production, if that is a concern.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply
* [PATCH] runtime: Update test cases numbers for runtime tests
From: jose.perez.carranza @ 2016-11-24 17:22 UTC (permalink / raw)
To: openembedded-core
From: Jose Perez Carranza <jose.perez.carranza@linux.intel.com>
Update test case numbers on runtime tests to do match
with templates defined on Testopia for 2.3 release
Signed-off-by: Jose Perez Carranza <jose.perez.carranza@linux.intel.com>
---
meta/lib/oeqa/runtime/buildgalculator.py | 1 +
meta/lib/oeqa/runtime/kernelmodule.py | 2 +-
meta/lib/oeqa/runtime/logrotate.py | 3 ++-
meta/lib/oeqa/runtime/pam.py | 2 +-
4 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/meta/lib/oeqa/runtime/buildgalculator.py b/meta/lib/oeqa/runtime/buildgalculator.py
index 28ba29e..220101d 100644
--- a/meta/lib/oeqa/runtime/buildgalculator.py
+++ b/meta/lib/oeqa/runtime/buildgalculator.py
@@ -7,6 +7,7 @@ def setUpModule():
skipModule("Image doesn't have tools-sdk in IMAGE_FEATURES")
class GalculatorTest(oeRuntimeTest):
+ @testcase(1526)
@skipUnlessPassed("test_ssh")
def test_galculator(self):
try:
diff --git a/meta/lib/oeqa/runtime/kernelmodule.py b/meta/lib/oeqa/runtime/kernelmodule.py
index 38ca184..2ac1bc9 100644
--- a/meta/lib/oeqa/runtime/kernelmodule.py
+++ b/meta/lib/oeqa/runtime/kernelmodule.py
@@ -14,7 +14,7 @@ class KernelModuleTest(oeRuntimeTest):
self.target.copy_to(os.path.join(oeRuntimeTest.tc.filesdir, "hellomod.c"), "/tmp/hellomod.c")
self.target.copy_to(os.path.join(oeRuntimeTest.tc.filesdir, "hellomod_makefile"), "/tmp/Makefile")
- @testcase('316')
+ @testcase('1541')
@skipUnlessPassed('test_ssh')
@skipUnlessPassed('test_gcc_compile')
def test_kernel_module(self):
diff --git a/meta/lib/oeqa/runtime/logrotate.py b/meta/lib/oeqa/runtime/logrotate.py
index de300bf..cf88c54 100644
--- a/meta/lib/oeqa/runtime/logrotate.py
+++ b/meta/lib/oeqa/runtime/logrotate.py
@@ -12,6 +12,7 @@ def setUpModule():
class LogrotateTest(oeRuntimeTest):
+ @testcase(1544)
@skipUnlessPassed("test_ssh")
def test_1_logrotate_setup(self):
(status, output) = self.target.run('mkdir $HOME/logrotate_dir')
@@ -19,7 +20,7 @@ class LogrotateTest(oeRuntimeTest):
(status, output) = self.target.run("sed -i \"s#wtmp {#wtmp {\\n olddir $HOME/logrotate_dir#\" /etc/logrotate.conf")
self.assertEqual(status, 0, msg = "Could not write to logrotate.conf file. Status and output: %s and %s)" % (status, output))
- @testcase(289)
+ @testcase(1542)
@skipUnlessPassed("test_1_logrotate_setup")
def test_2_logrotate(self):
(status, output) = self.target.run('logrotate -f /etc/logrotate.conf')
diff --git a/meta/lib/oeqa/runtime/pam.py b/meta/lib/oeqa/runtime/pam.py
index c8205c9..b7f2dfa 100644
--- a/meta/lib/oeqa/runtime/pam.py
+++ b/meta/lib/oeqa/runtime/pam.py
@@ -12,7 +12,7 @@ def setUpModule():
class PamBasicTest(oeRuntimeTest):
- @testcase(287)
+ @testcase(1543)
@skipUnlessPassed('test_ssh')
def test_pam(self):
(status, output) = self.target.run('login --help')
--
2.1.4
^ permalink raw reply related
* Re: migrating simple tarballs over to OE recipes?
From: Burton, Ross @ 2016-11-24 16:50 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: OE Core mailing list
In-Reply-To: <alpine.LFD.2.20.1611231143100.13816@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
On 23 November 2016 at 16:52, Robert P. J. Day <rpjday@crashcourse.ca>
wrote:
> what is the relationship between bin_package_do_install() and the
> EXPORTed do_install()? seems like an overriding/inheritance thing,
> yes?
>
Pretty much, that says that bin_package_do_install is this classes
do_install implementation. This lets you inherit the class and override
do_install(), calling bin_package_do_install as required. If you don't
provide an alternative implementation of do_install then
bin_package_do_install will be called.
This inheritance isn't used very often as generally it's sufficient to just
do_install_append() or _prepend().
Ross
[-- Attachment #2: Type: text/html, Size: 1152 bytes --]
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Kristian Amlie @ 2016-11-24 16:40 UTC (permalink / raw)
To: Patrick Ohly; +Cc: openembedded-core
In-Reply-To: <1480004493.6873.51.camel@intel.com>
On 24/11/16 17:21, Patrick Ohly wrote:
> On Thu, 2016-11-24 at 16:51 +0100, Kristian Amlie wrote:
>> On 24/11/16 16:28, Andreas Oberritter wrote:
>>> Note that in a shell, "data/*" doesn't include "data/.*". So this syntax
>>> avoids the confusing rsync syntax in trade for another one. I'd prefer
>>> the rsync flavour, because "behaves like rsync" is easier to remember
>>> than "behaves like a shell glob, but differently". Confusion could be
>>> prevented with good documentation, FWIW.
>>
>> This is turning into a bit of a bikeshed discussion. I have a slight
>> preference for the glob version, because I think it's less surprising,
>> but I'm fine either way.
>>
>> I count myself and Ed in favor of glob version, Ulrich and Andreas in
>> favor of rsync version. Patrick, you wanna be tie breaker? :-)
>
> But I said I was undecided ;-} Okay, I vote for the rsync flavor.
Rsync flavor it is then, unless anyone has strong objections!
--
Kristian
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Patrick Ohly @ 2016-11-24 16:21 UTC (permalink / raw)
To: Kristian Amlie; +Cc: openembedded-core
In-Reply-To: <23608ccc-ebaa-f2a6-6b39-02121e7b4287@mender.io>
On Thu, 2016-11-24 at 16:51 +0100, Kristian Amlie wrote:
> On 24/11/16 16:28, Andreas Oberritter wrote:
> > Note that in a shell, "data/*" doesn't include "data/.*". So this syntax
> > avoids the confusing rsync syntax in trade for another one. I'd prefer
> > the rsync flavour, because "behaves like rsync" is easier to remember
> > than "behaves like a shell glob, but differently". Confusion could be
> > prevented with good documentation, FWIW.
>
> This is turning into a bit of a bikeshed discussion. I have a slight
> preference for the glob version, because I think it's less surprising,
> but I'm fine either way.
>
> I count myself and Ed in favor of glob version, Ulrich and Andreas in
> favor of rsync version. Patrick, you wanna be tie breaker? :-)
But I said I was undecided ;-} Okay, I vote for the rsync flavor.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
^ permalink raw reply
* Re: [PATCH] meta/conf/layer.conf: Add recommended download layer
From: Burton, Ross @ 2016-11-24 16:14 UTC (permalink / raw)
To: Philip Balister; +Cc: OE-core
In-Reply-To: <fa116937-6c95-06a5-c63d-345cedcb304b@balister.org>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On 24 November 2016 at 14:03, Philip Balister <philip@balister.org> wrote:
> It is useful for the larger community to see what vendors have to do.
> Possibly we could decide vendor specific patches code benefit the larer
> community. I'd much rather vendors over publish then under publish.
>
Yeah, exactly.
All I ask is that vendors, when sending patches they know are for
compliance and don't expect to be merged for whatever reason, mark the
patch appropriately.
Ross
[-- Attachment #2: Type: text/html, Size: 963 bytes --]
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Kristian Amlie @ 2016-11-24 15:52 UTC (permalink / raw)
To: Patrick Ohly, ed.bartosh; +Cc: openembedded-core
In-Reply-To: <1480001047.6873.49.camel@intel.com>
On 24/11/16 16:24, Patrick Ohly wrote:
> On Thu, 2016-11-24 at 16:51 +0200, Ed Bartosh wrote:
>> On Thu, Nov 24, 2016 at 03:43:18PM +0100, Kristian Amlie wrote:
>>> On 24/11/16 14:23, Ed Bartosh wrote:
>>>> Would this way be less intuitive?
>>>> --exclude-path data/*
>>>> --exclude-path data
>>>>
>>>> We can go even further with it allowing any level of directories:
>>>> --exclude-path data/tmp/*
>
> Just to clarify, that is meant to also match data/tmp/.hidden-file,
> right? I.e. fnmatch() without the special FNM_PERIOD flag.
Yes, I think that makes the most sense, even if it breaks with shell
defaults.
--
Kristian
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Kristian Amlie @ 2016-11-24 15:51 UTC (permalink / raw)
To: Andreas Oberritter, ed.bartosh; +Cc: openembedded-core
In-Reply-To: <1bac8afc-7037-3891-7e3a-5a590dbed9e2@opendreambox.org>
On 24/11/16 16:28, Andreas Oberritter wrote:
> Note that in a shell, "data/*" doesn't include "data/.*". So this syntax
> avoids the confusing rsync syntax in trade for another one. I'd prefer
> the rsync flavour, because "behaves like rsync" is easier to remember
> than "behaves like a shell glob, but differently". Confusion could be
> prevented with good documentation, FWIW.
This is turning into a bit of a bikeshed discussion. I have a slight
preference for the glob version, because I think it's less surprising,
but I'm fine either way.
I count myself and Ed in favor of glob version, Ulrich and Andreas in
favor of rsync version. Patrick, you wanna be tie breaker? :-)
--
Kristian
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Andreas Oberritter @ 2016-11-24 15:28 UTC (permalink / raw)
To: ed.bartosh, Kristian Amlie; +Cc: openembedded-core
In-Reply-To: <20161124145136.GA31813@linux.intel.com>
On 24.11.2016 15:51, Ed Bartosh wrote:
> On Thu, Nov 24, 2016 at 03:43:18PM +0100, Kristian Amlie wrote:
>> On 24/11/16 14:23, Ed Bartosh wrote:
>>> On Thu, Nov 24, 2016 at 08:38:46AM +0100, Kristian Amlie wrote:
>>>> On 24/11/16 07:15, Ulrich Ölmann wrote:
>>>>> Hi,
>>>>>
>>>>> On Wed, Nov 23, 2016 at 04:56:56PM +0100, Patrick Ohly wrote:
>>>>>> On Wed, 2016-11-23 at 15:22 +0200, Ed Bartosh wrote:
>>>>>>> On Wed, Nov 23, 2016 at 02:08:28PM +0100, Kristian Amlie wrote:
>>>>>>>> On 23/11/16 13:08, Ed Bartosh wrote:
>>>>>>>>> On Tue, Nov 22, 2016 at 12:54:52PM +0100, Kristian Amlie wrote:
>>>>>>>>> [...]
>>>>>>>>> This can be done by extending existing rootfs plugin. It should be able
>>>>>>>>> to do 2 things:
>>>>>>>>>
>>>>>>>>> - populate content of one rootfs directory to the partition. We can
>>>>>>>>> extend syntax of --rootfs-dir parameter to specify optional directory path to use
>>>>>>>>>
>>>>>>>>> - exclude rootfs directories when populating partitions. I'd propose to
>>>>>>>>> introduce --exclude-dirs wks parser option to handle this.
>>>>>>>>>
>>>>>>>>> Example of wks file with proposed new options:
>>>>>>>>> part / --source rootfs --rootfs-dir=core-image-minimal --ondisk sda --fstype=ext4 --label root --align 1024 --exclude-dirs data --exclude-dirs home
>>>>>>>>> part /data --source rootfs --rootfs-dir=core-image-minimal:/home --ondisk sda --fstype=ext4 --label data --align 1024
>>>>>>>>> part /home --source rootfs --rootfs-dir=core-image-minimal:/data --ondisk sda --fstype=ext4 --label data --align 1024
>>>>>>>>>
>>>>>>>>> Does this make sense?
>>>>>>>>
>>>>>>>> Looks good. The only thing I would question is that, in the interest of
>>>>>>>> reducing redundancy, maybe we should omit --exclude-dirs and have wic
>>>>>>>> figure this out by combining all the entries, since "--exclude-dirs
>>>>>>>> <dir>" and the corresponding "part <dir>" will almost always come in
>>>>>>>> pairs. Possibly we could mark the "/" partition with one single
>>>>>>>> --no-overlapping-dirs to force wic to make this consideration. Or do you
>>>>>>>> think that's too magical?
>>>>>>>>
>>>>>>> Tt's quite implicit from my point of view. However, if people like it we
>>>>>>> can implement it this way.
>>>>>>
>>>>>> I prefer the explicit --exclude-dirs. It's less surprising and perhaps
>>>>>> there are usages for having the same content in different partitions
>>>>>> (redundancy, factory reset, etc.).
>>>>>>
>>>>>> Excluding only the directory content but not the actual directory is
>>>>>> indeed a good point. I'm a bit undecided. When excluding only the
>>>>>> directory content, there's no way of building a rootfs without that
>>>>>> mount point, if that's desired. OTOH, when excluding also the directory,
>>>>>> the data would have to be staged under a different path in the rootfs
>>>>>> and the mount point would have to be a separate, empty directory.
>>>>>>
>>>>>> I'm leaning towards excluding the directory content and keeping the
>>>>>> directory.
>>>>>
>>>>> what about having both possibilities by leaning against the syntax that rsync
>>>>> uses to specify if a whole source directory or only it's contents shall be
>>>>> synced to some destination site (see [1])?
>>>>>
>>>>> In analogy to this to exclude only the contents of the directory named 'data'
>>>>> you would use
>>>>>
>>>>> --exclude-dirs data/
>>>>>
>>>>> but to additionally exclude the dir itself as well it would read
>>>>>
>>>>> --exclude-dirs data
>>>>
>>>> This is creative, but ultimately too unintuitive IMHO. Rsync is the only
>>>> tool which uses this syntax AFAIK, and it's a constant source of
>>>> confusion, especially when mixed with cp or similar commands.
>>>>
>>>
>>> Would this way be less intuitive?
>>> --exclude-path data/*
>>> --exclude-path data
>>>
>>> We can go even further with it allowing any level of directories:
>>> --exclude-path data/tmp/*
>>> --exclude-path data/db/tmp
>>> ...
>>
>> I agree, this is pretty unambiguous and easy to understand.
>>
>> But this raises the question: Should we go all the way and support
>> wildcards? Which might make it a bit complicated. Maybe support only
>> pure '*' for now?
>
> As it shouldn't be hard to implement I'd go for it.
Note that in a shell, "data/*" doesn't include "data/.*". So this syntax
avoids the confusing rsync syntax in trade for another one. I'd prefer
the rsync flavour, because "behaves like rsync" is easier to remember
than "behaves like a shell glob, but differently". Confusion could be
prevented with good documentation, FWIW.
Regards,
Andreas
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Patrick Ohly @ 2016-11-24 15:24 UTC (permalink / raw)
To: ed.bartosh; +Cc: openembedded-core
In-Reply-To: <20161124145136.GA31813@linux.intel.com>
On Thu, 2016-11-24 at 16:51 +0200, Ed Bartosh wrote:
> On Thu, Nov 24, 2016 at 03:43:18PM +0100, Kristian Amlie wrote:
> > On 24/11/16 14:23, Ed Bartosh wrote:
> > > Would this way be less intuitive?
> > > --exclude-path data/*
> > > --exclude-path data
> > >
> > > We can go even further with it allowing any level of directories:
> > > --exclude-path data/tmp/*
Just to clarify, that is meant to also match data/tmp/.hidden-file,
right? I.e. fnmatch() without the special FNM_PERIOD flag.
> > > --exclude-path data/db/tmp
> > > ...
> >
> > I agree, this is pretty unambiguous and easy to understand.
> >
> > But this raises the question: Should we go all the way and support
> > wildcards? Which might make it a bit complicated. Maybe support only
> > pure '*' for now?
>
> As it shouldn't be hard to implement I'd go for it.
Additional code implies additional testing. Remember that it also should
better be supported by mkfs.ext4 and friends.
I'd rather start simple and only add additional complexity when needed.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
^ permalink raw reply
* Re: [PATCH 2/2] base-passwd: set root's default password to 'root'
From: Patrick Ohly @ 2016-11-24 14:54 UTC (permalink / raw)
To: Philip Balister; +Cc: Paul Eggleton, openembedded-core
In-Reply-To: <d0a381df-850b-6a63-7f7e-47741618cf87@balister.org>
On Thu, 2016-11-24 at 09:09 -0500, Philip Balister wrote:
> On 11/24/2016 02:46 AM, Patrick Ohly wrote:
> > On Thu, 2016-11-24 at 11:38 +0800, Robert Yang wrote:
> >> Currently, debug-tweaks is in EXTRA_IMAGE_FEATURES by default for poky, and
> >> there is no passwd, so that user can login easily without a passwd, I think
> >> that current status is more unsafe ?
> >
> > Both well-known password and no password are unsafe. User "root" with
> > password "root" is not even "more" safe already now, because tools that
> > brute-force logins try that. Choosing something else would be a bit
> > safer for a short while until the tools add it to their dictionary.
> >
> > Poky is also targeting a different audience than OE-core. Poky can
> > assume to be used in a secure environment, OE-core can't (because it
> > might be used for all kinds of devices).
> >
>
> That is the first time I've heard Poky is targeting an audience assumed
> to be running in a secure environment.
At least the default local.conf seems to be meant for that (easy-of-use
for developers preferred over security in a hostile environment).
> Should we document what Poky this
> somewhere? From where I sit, this seems to be an odd limitation.
I'm not aware of a document explicitly documenting this either. I
wouldn't call it a limitation, though: a real product could be built
with a configuration that doesn't enable debug-tweaks.
As Paul said before, more documentation about first boot, login
mechanisms, security considerations, etc. certainly would be useful.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Ed Bartosh @ 2016-11-24 14:51 UTC (permalink / raw)
To: Kristian Amlie; +Cc: openembedded-core
In-Reply-To: <1e1a7126-15dc-33be-a863-ea93063b554f@mender.io>
On Thu, Nov 24, 2016 at 03:43:18PM +0100, Kristian Amlie wrote:
> On 24/11/16 14:23, Ed Bartosh wrote:
> > On Thu, Nov 24, 2016 at 08:38:46AM +0100, Kristian Amlie wrote:
> >> On 24/11/16 07:15, Ulrich Ölmann wrote:
> >>> Hi,
> >>>
> >>> On Wed, Nov 23, 2016 at 04:56:56PM +0100, Patrick Ohly wrote:
> >>>> On Wed, 2016-11-23 at 15:22 +0200, Ed Bartosh wrote:
> >>>>> On Wed, Nov 23, 2016 at 02:08:28PM +0100, Kristian Amlie wrote:
> >>>>>> On 23/11/16 13:08, Ed Bartosh wrote:
> >>>>>>> On Tue, Nov 22, 2016 at 12:54:52PM +0100, Kristian Amlie wrote:
> >>>>>>> [...]
> >>>>>>> This can be done by extending existing rootfs plugin. It should be able
> >>>>>>> to do 2 things:
> >>>>>>>
> >>>>>>> - populate content of one rootfs directory to the partition. We can
> >>>>>>> extend syntax of --rootfs-dir parameter to specify optional directory path to use
> >>>>>>>
> >>>>>>> - exclude rootfs directories when populating partitions. I'd propose to
> >>>>>>> introduce --exclude-dirs wks parser option to handle this.
> >>>>>>>
> >>>>>>> Example of wks file with proposed new options:
> >>>>>>> part / --source rootfs --rootfs-dir=core-image-minimal --ondisk sda --fstype=ext4 --label root --align 1024 --exclude-dirs data --exclude-dirs home
> >>>>>>> part /data --source rootfs --rootfs-dir=core-image-minimal:/home --ondisk sda --fstype=ext4 --label data --align 1024
> >>>>>>> part /home --source rootfs --rootfs-dir=core-image-minimal:/data --ondisk sda --fstype=ext4 --label data --align 1024
> >>>>>>>
> >>>>>>> Does this make sense?
> >>>>>>
> >>>>>> Looks good. The only thing I would question is that, in the interest of
> >>>>>> reducing redundancy, maybe we should omit --exclude-dirs and have wic
> >>>>>> figure this out by combining all the entries, since "--exclude-dirs
> >>>>>> <dir>" and the corresponding "part <dir>" will almost always come in
> >>>>>> pairs. Possibly we could mark the "/" partition with one single
> >>>>>> --no-overlapping-dirs to force wic to make this consideration. Or do you
> >>>>>> think that's too magical?
> >>>>>>
> >>>>> Tt's quite implicit from my point of view. However, if people like it we
> >>>>> can implement it this way.
> >>>>
> >>>> I prefer the explicit --exclude-dirs. It's less surprising and perhaps
> >>>> there are usages for having the same content in different partitions
> >>>> (redundancy, factory reset, etc.).
> >>>>
> >>>> Excluding only the directory content but not the actual directory is
> >>>> indeed a good point. I'm a bit undecided. When excluding only the
> >>>> directory content, there's no way of building a rootfs without that
> >>>> mount point, if that's desired. OTOH, when excluding also the directory,
> >>>> the data would have to be staged under a different path in the rootfs
> >>>> and the mount point would have to be a separate, empty directory.
> >>>>
> >>>> I'm leaning towards excluding the directory content and keeping the
> >>>> directory.
> >>>
> >>> what about having both possibilities by leaning against the syntax that rsync
> >>> uses to specify if a whole source directory or only it's contents shall be
> >>> synced to some destination site (see [1])?
> >>>
> >>> In analogy to this to exclude only the contents of the directory named 'data'
> >>> you would use
> >>>
> >>> --exclude-dirs data/
> >>>
> >>> but to additionally exclude the dir itself as well it would read
> >>>
> >>> --exclude-dirs data
> >>
> >> This is creative, but ultimately too unintuitive IMHO. Rsync is the only
> >> tool which uses this syntax AFAIK, and it's a constant source of
> >> confusion, especially when mixed with cp or similar commands.
> >>
> >
> > Would this way be less intuitive?
> > --exclude-path data/*
> > --exclude-path data
> >
> > We can go even further with it allowing any level of directories:
> > --exclude-path data/tmp/*
> > --exclude-path data/db/tmp
> > ...
>
> I agree, this is pretty unambiguous and easy to understand.
>
> But this raises the question: Should we go all the way and support
> wildcards? Which might make it a bit complicated. Maybe support only
> pure '*' for now?
As it shouldn't be hard to implement I'd go for it.
--
Regards,
Ed
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Kristian Amlie @ 2016-11-24 14:43 UTC (permalink / raw)
To: ed.bartosh; +Cc: openembedded-core
In-Reply-To: <20161124132315.GA14497@linux.intel.com>
On 24/11/16 14:23, Ed Bartosh wrote:
> On Thu, Nov 24, 2016 at 08:38:46AM +0100, Kristian Amlie wrote:
>> On 24/11/16 07:15, Ulrich Ölmann wrote:
>>> Hi,
>>>
>>> On Wed, Nov 23, 2016 at 04:56:56PM +0100, Patrick Ohly wrote:
>>>> On Wed, 2016-11-23 at 15:22 +0200, Ed Bartosh wrote:
>>>>> On Wed, Nov 23, 2016 at 02:08:28PM +0100, Kristian Amlie wrote:
>>>>>> On 23/11/16 13:08, Ed Bartosh wrote:
>>>>>>> On Tue, Nov 22, 2016 at 12:54:52PM +0100, Kristian Amlie wrote:
>>>>>>> [...]
>>>>>>> This can be done by extending existing rootfs plugin. It should be able
>>>>>>> to do 2 things:
>>>>>>>
>>>>>>> - populate content of one rootfs directory to the partition. We can
>>>>>>> extend syntax of --rootfs-dir parameter to specify optional directory path to use
>>>>>>>
>>>>>>> - exclude rootfs directories when populating partitions. I'd propose to
>>>>>>> introduce --exclude-dirs wks parser option to handle this.
>>>>>>>
>>>>>>> Example of wks file with proposed new options:
>>>>>>> part / --source rootfs --rootfs-dir=core-image-minimal --ondisk sda --fstype=ext4 --label root --align 1024 --exclude-dirs data --exclude-dirs home
>>>>>>> part /data --source rootfs --rootfs-dir=core-image-minimal:/home --ondisk sda --fstype=ext4 --label data --align 1024
>>>>>>> part /home --source rootfs --rootfs-dir=core-image-minimal:/data --ondisk sda --fstype=ext4 --label data --align 1024
>>>>>>>
>>>>>>> Does this make sense?
>>>>>>
>>>>>> Looks good. The only thing I would question is that, in the interest of
>>>>>> reducing redundancy, maybe we should omit --exclude-dirs and have wic
>>>>>> figure this out by combining all the entries, since "--exclude-dirs
>>>>>> <dir>" and the corresponding "part <dir>" will almost always come in
>>>>>> pairs. Possibly we could mark the "/" partition with one single
>>>>>> --no-overlapping-dirs to force wic to make this consideration. Or do you
>>>>>> think that's too magical?
>>>>>>
>>>>> Tt's quite implicit from my point of view. However, if people like it we
>>>>> can implement it this way.
>>>>
>>>> I prefer the explicit --exclude-dirs. It's less surprising and perhaps
>>>> there are usages for having the same content in different partitions
>>>> (redundancy, factory reset, etc.).
>>>>
>>>> Excluding only the directory content but not the actual directory is
>>>> indeed a good point. I'm a bit undecided. When excluding only the
>>>> directory content, there's no way of building a rootfs without that
>>>> mount point, if that's desired. OTOH, when excluding also the directory,
>>>> the data would have to be staged under a different path in the rootfs
>>>> and the mount point would have to be a separate, empty directory.
>>>>
>>>> I'm leaning towards excluding the directory content and keeping the
>>>> directory.
>>>
>>> what about having both possibilities by leaning against the syntax that rsync
>>> uses to specify if a whole source directory or only it's contents shall be
>>> synced to some destination site (see [1])?
>>>
>>> In analogy to this to exclude only the contents of the directory named 'data'
>>> you would use
>>>
>>> --exclude-dirs data/
>>>
>>> but to additionally exclude the dir itself as well it would read
>>>
>>> --exclude-dirs data
>>
>> This is creative, but ultimately too unintuitive IMHO. Rsync is the only
>> tool which uses this syntax AFAIK, and it's a constant source of
>> confusion, especially when mixed with cp or similar commands.
>>
>
> Would this way be less intuitive?
> --exclude-path data/*
> --exclude-path data
>
> We can go even further with it allowing any level of directories:
> --exclude-path data/tmp/*
> --exclude-path data/db/tmp
> ...
I agree, this is pretty unambiguous and easy to understand.
But this raises the question: Should we go all the way and support
wildcards? Which might make it a bit complicated. Maybe support only
pure '*' for now?
--
Kristian
^ permalink raw reply
* [wic][PATCH] qemux86*.conf: set wic-related parameters
From: Ed Bartosh @ 2016-11-24 14:40 UTC (permalink / raw)
To: openembedded-core
Set directdisk.wks as default wks to use for qemux86 machines.
Set requried dependeincies to build directdisk image.
This should simplify building wic images for qemux86* machines.
It should be enough to add wic to the list of IMAGE_FSTYPES to get
the images built.
[YOCTO #10637, YOCTO #8719]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
meta/conf/machine/qemux86-64.conf | 3 +++
meta/conf/machine/qemux86.conf | 3 +++
2 files changed, 6 insertions(+)
diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
index f2b2aeb..7559724 100644
--- a/meta/conf/machine/qemux86-64.conf
+++ b/meta/conf/machine/qemux86-64.conf
@@ -28,3 +28,6 @@ XSERVER = "xserver-xorg \
MACHINE_FEATURES += "x86"
MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "v86d"
+
+WKS_FILE = "directdisk.wks"
+do_image_wic[depends] += "syslinux:do_build syslinux-native:do_populate_sysroot mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot"
diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
index 09555ad..7785999 100644
--- a/meta/conf/machine/qemux86.conf
+++ b/meta/conf/machine/qemux86.conf
@@ -27,3 +27,6 @@ XSERVER = "xserver-xorg \
MACHINE_FEATURES += "x86"
MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "v86d"
+
+WKS_FILE = "directdisk.wks"
+do_image_wic[depends] += "syslinux:do_build syslinux-native:do_populate_sysroot mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot"
--
2.1.4
^ permalink raw reply related
* Re: [PATCH 2/2] base-passwd: set root's default password to 'root'
From: Philip Balister @ 2016-11-24 14:09 UTC (permalink / raw)
To: Patrick Ohly, Robert Yang; +Cc: Paul Eggleton, openembedded-core
In-Reply-To: <1479973589.6873.15.camel@intel.com>
On 11/24/2016 02:46 AM, Patrick Ohly wrote:
> On Thu, 2016-11-24 at 11:38 +0800, Robert Yang wrote:
>> Currently, debug-tweaks is in EXTRA_IMAGE_FEATURES by default for poky, and
>> there is no passwd, so that user can login easily without a passwd, I think
>> that current status is more unsafe ?
>
> Both well-known password and no password are unsafe. User "root" with
> password "root" is not even "more" safe already now, because tools that
> brute-force logins try that. Choosing something else would be a bit
> safer for a short while until the tools add it to their dictionary.
>
> Poky is also targeting a different audience than OE-core. Poky can
> assume to be used in a secure environment, OE-core can't (because it
> might be used for all kinds of devices).
>
That is the first time I've heard Poky is targeting an audience assumed
to be running in a secure environment. Should we document what Poky this
somewhere? From where I sit, this seems to be an odd limitation.
Philip
^ permalink raw reply
* Re: [PATCH] meta/conf/layer.conf: Add recommended download layer
From: Philip Balister @ 2016-11-24 14:03 UTC (permalink / raw)
To: Martin Jansa, Mark Hatle; +Cc: openembedded-core
In-Reply-To: <20161123185617.GH3265@jama>
[-- Attachment #1.1: Type: text/plain, Size: 2303 bytes --]
On 11/23/2016 01:56 PM, Martin Jansa wrote:
> On Wed, Nov 23, 2016 at 12:38:42PM -0600, Mark Hatle wrote:
>> On 11/23/16 12:10 PM, Martin Jansa wrote:
>>> On Wed, Nov 23, 2016 at 11:42:09AM -0600, Mark Hatle wrote:
>>>> This is a Wind River specific patch and not generally applicable.
>>>
>>> Then why is it sent to oe-core ML?
>>
>> As noted in the cover letter, I'm required to by Yocto Project compliance
>> requirements.
>>
>> As indicated LAST time I got scolded, I was told to indicate this in the patch
>> summary email -- which I did.
>
> Sorry I've noticed the cover letter only after the response.
>
> So it's only because of this requirement from Yocto Project compliance?
>
> "Have all patches applied to BitBake and OpenEmbedded-Core (if present)
> been submitted to the open source community?"
>
> Shouldn't the wording be change to something like "all applicable
> patches" or "all generally useful patches"?
>
> It seems strange to send project specific patches together with cover
> saying that they aren't generally applicable and shouldn't be merged,
> just because of this requirement.
It is useful for the larger community to see what vendors have to do.
Possibly we could decide vendor specific patches code benefit the larer
community. I'd much rather vendors over publish then under publish.
Philip
>
> Regards,
>
>>>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>>>> ---
>>>> meta/conf/layer.conf | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
>>>> index 24b4df0..a94e524 100644
>>>> --- a/meta/conf/layer.conf
>>>> +++ b/meta/conf/layer.conf
>>>> @@ -11,6 +11,8 @@ BBFILE_PRIORITY_core = "5"
>>>> # cause compatibility issues with other layers
>>>> LAYERVERSION_core = "9"
>>>>
>>>> +LAYERRECOMMENDS_core = "oe-core-dl-2-2"
>>>> +
>>>> BBLAYERS_LAYERINDEX_NAME_core = "openembedded-core"
>>>>
>>>> # Set a variable to get to the top of the metadata location
>>>> --
>>>> 2.9.3
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
>
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 514 bytes --]
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox