* [PATCH] wic/isoimage-isohybrid: check for grub-mkimage
From: Ioan-Adrian Ratiu @ 2017-01-04 18:34 UTC (permalink / raw)
To: openembedded-core; +Cc: ken.sharp
The isohybrid plugin uses grub-mkimage but doesn't make sure it gets built.
Add a check to avoid the following error:
Error: A native program grub-mkimage required to build the image was not found (see details above).
Wic failed to find a recipe to build native grub-mkimage. Please file a bug against wic.
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
scripts/lib/wic/plugins/source/isoimage-isohybrid.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
index 3858fd439b..9c408d046f 100644
--- a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
+++ b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
@@ -242,6 +242,11 @@ class IsoImagePlugin(SourcePlugin):
msger.info("Building mtools-native...\n")
exec_cmd("bitbake mtools-native")
+ # Make sure grub-mkconfig is available in native sysroot
+ if not os.path.isfile("%s/usr/bin/grub-mkimage" % native_sysroot):
+ msger.info("Building grub-native...\n")
+ exec_cmd("bitbake grub-native")
+
@classmethod
def do_configure_partition(cls, part, source_params, creator, cr_workdir,
oe_builddir, bootimg_dir, kernel_dir,
--
2.11.0
^ permalink raw reply related
* [PATCH 1/2] populate_sdk_ext: fix working with uninative sstate
From: Ed Bartosh @ 2017-01-04 18:48 UTC (permalink / raw)
To: openembedded-core
Mapped uninative sstate directories to make ext SDK installer to
use them when it's run on systems with gcc version different from
gcc version used to build installer.
[YOCTO #10832]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index 0812eea..fc9cc22 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -308,7 +308,10 @@ python copy_buildsystem () {
f.write('BB_SETSCENE_ENFORCE_WHITELIST = "%:* *:do_shared_workdir *:do_rm_work"\n\n')
# Hide the config information from bitbake output (since it's fixed within the SDK)
- f.write('BUILDCFG_HEADER = ""\n')
+ f.write('BUILDCFG_HEADER = ""\n\n')
+
+ # Map gcc-dependent uninative sstate cache for installer usage
+ f.write('SSTATE_MIRRORS = "file://universal/(.*) file://universal-4.9/\\1\\nfile://universal-4.9/(.*) file://universal-4.8/\\1"\n\n')
# Allow additional config through sdk-extra.conf
fn = bb.cookerdata.findConfigFile('sdk-extra.conf', d)
--
2.1.4
^ permalink raw reply related
* [PATCH 2/2] populate_sdk_ext: whitelist do_package tasks
From: Ed Bartosh @ 2017-01-04 18:48 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <1483555698-27838-1-git-send-email-ed.bartosh@linux.intel.com>
With enabled SSTATE_MIRRORS sstate code expects mirrors to
contain entries for all tasks, which is not the case for ext
installer as it uses reduced sstate cache.
Added do_package tasks to BB_SETSCENE_ENFORCE_WHITELIST to prevent
installer failing with ERROR: Sstate artifact unavailable
[YOCTO #10832]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index fc9cc22..d1b3fb4 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -305,7 +305,7 @@ python copy_buildsystem () {
f.write('SIGGEN_LOCKEDSIGS_TASKSIG_CHECK = "warn"\n\n')
# Set up whitelist for run on install
- f.write('BB_SETSCENE_ENFORCE_WHITELIST = "%:* *:do_shared_workdir *:do_rm_work"\n\n')
+ f.write('BB_SETSCENE_ENFORCE_WHITELIST = "%:* *:do_shared_workdir *:do_rm_work *:do_package"\n\n')
# Hide the config information from bitbake output (since it's fixed within the SDK)
f.write('BUILDCFG_HEADER = ""\n\n')
--
2.1.4
^ permalink raw reply related
* [PATCH v2] wic/isoimage-isohybrid: check for grub-mkimage
From: Ioan-Adrian Ratiu @ 2017-01-04 19:04 UTC (permalink / raw)
To: openembedded-core; +Cc: ken.sharp
The isohybrid plugin uses grub-mkimage but doesn't make sure it gets built.
Add a check to avoid the following error:
Error: A native program grub-mkimage required to build the image was not found (see details above).
Wic failed to find a recipe to build native grub-mkimage. Please file a bug against wic.
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
scripts/lib/wic/plugins/source/isoimage-isohybrid.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
index 849fd8bea3..d616316d61 100644
--- a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
+++ b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
@@ -242,6 +242,11 @@ class IsoImagePlugin(SourcePlugin):
msger.info("Building mtools-native...\n")
exec_cmd("bitbake mtools-native")
+ # Make sure grub-mkimage is available in native sysroot
+ if not os.path.isfile("%s/usr/bin/grub-mkimage" % native_sysroot):
+ msger.info("Building grub-native...\n")
+ exec_cmd("bitbake grub-native")
+
@classmethod
def do_configure_partition(cls, part, source_params, creator, cr_workdir,
oe_builddir, bootimg_dir, kernel_dir,
--
2.11.0
^ permalink raw reply related
* [PATCH] mtd-utils: Upgrade to 2.0.0
From: Mike Crowe @ 2017-01-04 19:28 UTC (permalink / raw)
To: openembedded-core; +Cc: Mike Crowe
Upstream has started using automake which means that the recipe must now
inherit from autotools and pkgconfig.
The source tree has been reorganised too which requires the paths in the
patches to be modified. None of the patches appear to have been applied
upstream.
Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
meta/recipes-devtools/mtd/mtd-utils/0001-Fix-build-with-musl.patch | 4 ++--
.../mtd/mtd-utils/add-exclusion-to-mkfs-jffs2-git-2.patch | 2 +-
meta/recipes-devtools/mtd/mtd-utils/fix-armv7-neon-alignment.patch | 4 ++--
...-utils-fix-corrupt-cleanmarker-with-flash_erase--j-command.patch | 4 ++--
meta/recipes-devtools/mtd/mtd-utils_git.bb | 6 ++++--
5 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/meta/recipes-devtools/mtd/mtd-utils/0001-Fix-build-with-musl.patch b/meta/recipes-devtools/mtd/mtd-utils/0001-Fix-build-with-musl.patch
index 305be52..6a9bd1c 100644
--- a/meta/recipes-devtools/mtd/mtd-utils/0001-Fix-build-with-musl.patch
+++ b/meta/recipes-devtools/mtd/mtd-utils/0001-Fix-build-with-musl.patch
@@ -14,8 +14,8 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
diff --git a/mkfs.jffs2.c b/mkfs.jffs2.c
index f09c0b2..ed2dc43 100644
---- a/mkfs.jffs2.c
-+++ b/mkfs.jffs2.c
+--- a/jffsX-utils/mkfs.jffs2.c
++++ b/jffsX-utils/mkfs.jffs2.c
@@ -72,6 +72,7 @@
#include <byteswap.h>
#include <crc32.h>
diff --git a/meta/recipes-devtools/mtd/mtd-utils/add-exclusion-to-mkfs-jffs2-git-2.patch b/meta/recipes-devtools/mtd/mtd-utils/add-exclusion-to-mkfs-jffs2-git-2.patch
index 57d6a30..0e3776a 100644
--- a/meta/recipes-devtools/mtd/mtd-utils/add-exclusion-to-mkfs-jffs2-git-2.patch
+++ b/meta/recipes-devtools/mtd/mtd-utils/add-exclusion-to-mkfs-jffs2-git-2.patch
@@ -1,7 +1,7 @@
Upstream-Status: Pending
--- /tmp/mkfs.jffs2.c 2009-01-11 15:28:41.000000000 +0100
-+++ git/mkfs.jffs2.c 2009-01-11 15:59:29.000000000 +0100
++++ git/jffsX-utils/mkfs.jffs2.c 2009-01-11 15:59:29.000000000 +0100
@@ -100,6 +100,11 @@
struct rb_node hardlink_rb;
};
diff --git a/meta/recipes-devtools/mtd/mtd-utils/fix-armv7-neon-alignment.patch b/meta/recipes-devtools/mtd/mtd-utils/fix-armv7-neon-alignment.patch
index 05f1629..a279d84 100644
--- a/meta/recipes-devtools/mtd/mtd-utils/fix-armv7-neon-alignment.patch
+++ b/meta/recipes-devtools/mtd/mtd-utils/fix-armv7-neon-alignment.patch
@@ -8,8 +8,8 @@ Signed-off-by: Yuanjie Huang <Yuanjie.Huang@windriver.com>
diff --git a/mkfs.ubifs/key.h b/mkfs.ubifs/key.h
index d3a02d4..e7e9218 100644
---- a/mkfs.ubifs/key.h
-+++ b/mkfs.ubifs/key.h
+--- a/ubifs-utils/mkfs.ubifs/key.h
++++ b/ubifs-utils/mkfs.ubifs/key.h
@@ -141,10 +141,12 @@ static inline void data_key_init(union ubifs_key *key, ino_t inum,
*/
static inline void key_write(const union ubifs_key *from, void *to)
diff --git a/meta/recipes-devtools/mtd/mtd-utils/mtd-utils-fix-corrupt-cleanmarker-with-flash_erase--j-command.patch b/meta/recipes-devtools/mtd/mtd-utils/mtd-utils-fix-corrupt-cleanmarker-with-flash_erase--j-command.patch
index 7207cfc..0f42e73 100644
--- a/meta/recipes-devtools/mtd/mtd-utils/mtd-utils-fix-corrupt-cleanmarker-with-flash_erase--j-command.patch
+++ b/meta/recipes-devtools/mtd/mtd-utils/mtd-utils-fix-corrupt-cleanmarker-with-flash_erase--j-command.patch
@@ -49,8 +49,8 @@ v2 : get length of availble freeoob bytes from oobinfo information,
diff --git a/flash_erase.c b/flash_erase.c
index 933373a..4b9d84b 100644
---- a/flash_erase.c
-+++ b/flash_erase.c
+--- a/misc-utils/flash_erase.c
++++ b/misc-utils/flash_erase.c
@@ -99,6 +99,7 @@ int main(int argc, char *argv[])
bool isNAND;
int error = 0;
diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-utils_git.bb
index 8a3afaf..d09ac84 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
@@ -5,11 +5,13 @@ LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
file://include/common.h;beginline=1;endline=17;md5=ba05b07912a44ea2bf81ce409380049c"
+inherit autotools pkgconfig
+
DEPENDS = "zlib lzo e2fsprogs util-linux"
-PV = "1.5.2"
+PV = "2.0.0"
-SRCREV = "aea36417067dade75192bafa03af70b6eb2677b1"
+SRCREV = "1bfee8660131fca7a18f68e9548a18ca6b3378a0"
SRC_URI = "git://git.infradead.org/mtd-utils.git \
file://add-exclusion-to-mkfs-jffs2-git-2.patch \
file://fix-armv7-neon-alignment.patch \
--
2.1.4
^ permalink raw reply related
* Re: [meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities
From: Moritz Fischer @ 2017-01-04 20:25 UTC (permalink / raw)
To: Leonardo Sandoval; +Cc: koen, openembedded-core
In-Reply-To: <740a7531-d635-8191-d901-ffaa0deffae4@linux.intel.com>
Leonardo,
On Wed, Jan 4, 2017 at 10:36 AM, Leonardo Sandoval
<leonardo.sandoval.gonzalez@linux.intel.com> wrote:
>
>> +}
>> diff --git
>> a/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
>> b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
>> new file mode 100644
>> index 0000000..46e8cad
>> --- /dev/null
>> +++
>> b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
>> @@ -0,0 +1,26 @@
>> +From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001
>> +From: Moritz Fischer <moritz.fischer@ettus.com>
>> +Date: Tue, 27 Dec 2016 22:24:07 -0800
>> +Subject: [PATCH] build Add HOST_LDFLAGS
>> +
>
>
> what is the Upstream Status of this patch? At least for oe-core, you need to
> provide it. More info at
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Good catch, thanks. I submitted it upstream. I'll just wait for that
to resubmit my v4 here, maybe by then I don't need the patch anymore
then.
Moritz
^ permalink raw reply
* Re: [PATCH v2] wic/isoimage-isohybrid: check for grub-mkimage
From: Ed Bartosh @ 2017-01-04 20:12 UTC (permalink / raw)
To: Ioan-Adrian Ratiu; +Cc: ken.sharp, openembedded-core
In-Reply-To: <20170104190443.25931-1-adrian.ratiu@ni.com>
On Wed, Jan 04, 2017 at 09:04:43PM +0200, Ioan-Adrian Ratiu wrote:
> The isohybrid plugin uses grub-mkimage but doesn't make sure it gets built.
> Add a check to avoid the following error:
>
> Error: A native program grub-mkimage required to build the image was not found (see details above).
>
> Wic failed to find a recipe to build native grub-mkimage. Please file a bug against wic.
>
> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> ---
> scripts/lib/wic/plugins/source/isoimage-isohybrid.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
> index 849fd8bea3..d616316d61 100644
> --- a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
> +++ b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
> @@ -242,6 +242,11 @@ class IsoImagePlugin(SourcePlugin):
> msger.info("Building mtools-native...\n")
> exec_cmd("bitbake mtools-native")
>
> + # Make sure grub-mkimage is available in native sysroot
> + if not os.path.isfile("%s/usr/bin/grub-mkimage" % native_sysroot):
> + msger.info("Building grub-native...\n")
> + exec_cmd("bitbake grub-native")
> +
> @classmethod
> def do_configure_partition(cls, part, source_params, creator, cr_workdir,
> oe_builddir, bootimg_dir, kernel_dir,
Unfortunately this approach will not work if wic is run from bitbake.
I'd suggest to simply add grub-native to NATIVE_RECIPES dictionary in
scripts/lib/wic/utils/oe/misc.py
It will make error message more informative and useful.
--
Regards,
Ed
^ permalink raw reply
* Re: [PATCH v2] wic/isoimage-isohybrid: check for grub-mkimage
From: Ed Bartosh @ 2017-01-04 20:19 UTC (permalink / raw)
To: Ioan-Adrian Ratiu; +Cc: ken.sharp, openembedded-core
In-Reply-To: <20170104201255.GA28112@linux.intel.com>
On Wed, Jan 04, 2017 at 10:12:55PM +0200, Ed Bartosh wrote:
> On Wed, Jan 04, 2017 at 09:04:43PM +0200, Ioan-Adrian Ratiu wrote:
> > The isohybrid plugin uses grub-mkimage but doesn't make sure it gets built.
> > Add a check to avoid the following error:
> >
> > Error: A native program grub-mkimage required to build the image was not found (see details above).
> >
> > Wic failed to find a recipe to build native grub-mkimage. Please file a bug against wic.
> >
> > Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> > ---
> > scripts/lib/wic/plugins/source/isoimage-isohybrid.py | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
> > index 849fd8bea3..d616316d61 100644
> > --- a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
> > +++ b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
> > @@ -242,6 +242,11 @@ class IsoImagePlugin(SourcePlugin):
> > msger.info("Building mtools-native...\n")
> > exec_cmd("bitbake mtools-native")
> >
> > + # Make sure grub-mkimage is available in native sysroot
> > + if not os.path.isfile("%s/usr/bin/grub-mkimage" % native_sysroot):
> > + msger.info("Building grub-native...\n")
> > + exec_cmd("bitbake grub-native")
> > +
> > @classmethod
> > def do_configure_partition(cls, part, source_params, creator, cr_workdir,
> > oe_builddir, bootimg_dir, kernel_dir,
>
> Unfortunately this approach will not work if wic is run from bitbake.
>
> I'd suggest to simply add grub-native to NATIVE_RECIPES dictionary in
> scripts/lib/wic/utils/oe/misc.py
> It will make error message more informative and useful.
>
The same should probably be done with the rest of native tools called from
this module. It's better to avoid building them implicitly.
--
Regards,
Ed
^ permalink raw reply
* Re: [meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities
From: Burton, Ross @ 2017-01-04 20:39 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Koen Kooi, OE-core
In-Reply-To: <CAAtXAHe=ob8N-Z6OzVPm_Fbc91Z3Ve+=K4Mubp79PJhik8a+bA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On 4 January 2017 at 20:25, Moritz Fischer <moritz.fischer@ettus.com> wrote:
> Good catch, thanks. I submitted it upstream. I'll just wait for that
> to resubmit my v4 here, maybe by then I don't need the patch anymore
> then.
>
Is there a good rationale to put this in oe-core, instead of a BSP layer or
meta-oe? How widespread are boards that use this tool?
Ross
[-- Attachment #2: Type: text/html, Size: 791 bytes --]
^ permalink raw reply
* [PATCH RFC] kernel.bbclass: symlink initramfs kernel bundle to kernel
From: California Sullivan @ 2017-01-04 20:57 UTC (permalink / raw)
To: openembedded-core; +Cc: bruce.ashfield
Image creation seems to always grab ${type} (usually bzImage), even if
we specifically use INITRAMFS_IMAGE_BUNDLE to create a bundled
initramfs/kernel. Work around this by linking ${type}.initramfs to
${type} as a final step when it exists.
Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
---
I've been experimenting with initramfs stuff lately and discovered that
despite the bundled initramfs being built, it isn't being used by image
creation by default. This is one way to solve the issue, but ultimately
its probably a deficiency with image creation. Anyone with more
knowledge in this area have some thoughts?
meta/classes/kernel.bbclass | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 3630042..5b5a642 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -618,6 +618,10 @@ kernel_do_deploy() {
initramfs_symlink_name=${type}-initramfs-${MACHINE}
install -m 0644 ${KERNEL_OUTPUT_DIR}/${type}.initramfs ${DEPLOYDIR}/${initramfs_base_name}.bin
ln -sf ${initramfs_base_name}.bin ${DEPLOYDIR}/${initramfs_symlink_name}.bin
+ if [ x"${INITRAMFS_IMAGE_BUNDLE}" = x1 ]; then
+ echo "INITRAMFS_IMAGE_BUNDLE is set. Linking to ${type}..."
+ ln -sf ${initramfs_base_name}.bin ${DEPLOYDIR}/${type}
+ fi
fi
done
}
--
2.5.5
^ permalink raw reply related
* Re: [PATCH 3/6] ksize.py: Python 3 fixes
From: Alejandro Hernandez @ 2017-01-04 22:18 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
In-Reply-To: <2122f031-db47-1dc5-7080-1271e6fc1527@linux.intel.com>
Hey Khem,
Ok, now I'm actually awake when reading this, are you saying these
changes should go in the same patch as the one for ksum.py?
On 01/04/2017 12:21 PM, Alejandro Hernandez wrote:
> Hey Khem,
>
>
> Its an old script fro Tom, but as far as I remember it worked fine on
> python3, although thanks for checking and sending the patch!
>
> Cheers
>
> Alejandro
>
>
> On 01/04/2017 12:39 AM, Khem Raj wrote:
>> On Tue, Jan 3, 2017 at 2:30 PM, Alejandro Hernandez
>> <alejandro.hernandez@linux.intel.com> wrote:
>>> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>>>
>>> String errors and partial __cmp__ fix.
>> may be fold it into previous patch.
>>
>>> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>>> ---
>>> scripts/tiny/ksize.py | 17 ++++++++++++-----
>>> 1 file changed, 12 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/scripts/tiny/ksize.py b/scripts/tiny/ksize.py
>>> index b9d2b19..ea1ca7f 100755
>>> --- a/scripts/tiny/ksize.py
>>> +++ b/scripts/tiny/ksize.py
>>> @@ -41,7 +41,7 @@ def usage():
>>> class Sizes:
>>> def __init__(self, glob):
>>> self.title = glob
>>> - p = Popen("size -t " + glob, shell=True, stdout=PIPE,
>>> stderr=PIPE)
>>> + p = Popen("size -t " + str(glob), shell=True, stdout=PIPE,
>>> stderr=PIPE)
>>> output = p.communicate()[0].splitlines()
>>> if len(output) > 2:
>>> sizes = output[-1].split()[0:4]
>>> @@ -62,18 +62,18 @@ class Report:
>>> r = Report(filename, title)
>>> path = os.path.dirname(filename)
>>>
>>> - p = Popen("ls " + path + "/*.o | grep -v built-in.o",
>>> + p = Popen("ls " + str(path) + "/*.o | grep -v built-in.o",
>>> shell=True, stdout=PIPE, stderr=PIPE)
>>> glob = ' '.join(p.communicate()[0].splitlines())
>>> - oreport = Report(glob, path + "/*.o")
>>> - oreport.sizes.title = path + "/*.o"
>>> + oreport = Report(glob, str(path) + "/*.o")
>>> + oreport.sizes.title = str(path) + "/*.o"
>>> r.parts.append(oreport)
>>>
>>> if subglob:
>>> p = Popen("ls " + subglob, shell=True, stdout=PIPE,
>>> stderr=PIPE)
>>> for f in p.communicate()[0].splitlines():
>>> path = os.path.dirname(f)
>>> - r.parts.append(Report.create(f, path, path +
>>> "/*/built-in.o"))
>>> + r.parts.append(Report.create(f, path, str(path) +
>>> "/*/built-in.o"))
>>> r.parts.sort(reverse=True)
>>>
>>> for b in r.parts:
>>> @@ -116,6 +116,13 @@ class Report:
>>> self.deltas["data"], self.deltas["bss"]))
>>> print("\n")
>>>
>>> + def __lt__(this, that):
>>> + if that is None:
>>> + return 1
>>> + if not isinstance(that, Report):
>>> + raise TypeError
>>> + return this.sizes.total < that.sizes.total
>>> +
>>> def __cmp__(this, that):
>>> if that is None:
>>> return 1
>>> --
>>> 2.6.6
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply
* [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes
From: Christopher Larson @ 2017-01-04 22:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
From: Christopher Larson <chris_larson@mentor.com>
These aren't buildable without it, and adding it fixes oe-core world builds
with nodistro (which does not have the opengl feature by default).
The following changes since commit 425afe2484707640ac71194885fdb263e95e9950:
lib/oe/utils: Drop python2 compatibility code (2016-12-22 08:50:21 +0000)
are available in the git repository at:
git://github.com/kergoth/openembedded-core without-opengl-fixes
https://github.com/kergoth/openembedded-core/tree/without-opengl-fixes
Christopher Larson (6):
waffle: add opengl to REQUIRED_DISTRO_FEATURES
piglit: add opengl to REQUIRED_DISTRO_FEATURES
libglu: add opengl to REQUIRED_DISTRO_FEATURES
eglinfo-x11: add opengl to REQUIRED_DISTRO_FEATURES
packagegroup-self-hosted: add opengl to REQUIRED_DISTRO_FEATURES
packagegroup-core-lsb: add opengl to REQUIRED_DISTRO_FEATURES
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 3 +++
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 3 +++
meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.0.bb | 3 ++-
meta/recipes-graphics/mesa/libglu_9.0.0.bb | 2 +-
meta/recipes-graphics/piglit/piglit_git.bb | 3 +++
meta/recipes-graphics/waffle/waffle_1.5.2.bb | 3 +++
6 files changed, 15 insertions(+), 2 deletions(-)
--
2.8.0
^ permalink raw reply
* [PATCH 1/6] waffle: add opengl to REQUIRED_DISTRO_FEATURES
From: Christopher Larson @ 2017-01-04 22:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
In-Reply-To: <cover.1483570577.git.chris_larson@mentor.com>
From: Christopher Larson <chris_larson@mentor.com>
Multiple packageconfigs depend upon virtual/libgl, whose providers require the
opengl distro feature.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/recipes-graphics/waffle/waffle_1.5.2.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-graphics/waffle/waffle_1.5.2.bb b/meta/recipes-graphics/waffle/waffle_1.5.2.bb
index f7db1bc..9d6b0e0 100644
--- a/meta/recipes-graphics/waffle/waffle_1.5.2.bb
+++ b/meta/recipes-graphics/waffle/waffle_1.5.2.bb
@@ -20,6 +20,9 @@ PACKAGECONFIG ??= "glx"
# libx11 requires x11 in DISTRO_FEATURES.
REQUIRED_DISTRO_FEATURES = "${@bb.utils.contains('PACKAGECONFIG', 'glx', 'x11', '', d)}"
+# virtual/libgl requires opengl in DISTRO_FEATURES.
+REQUIRED_DISTRO_FEATURES += "${@bb.utils.contains('DEPENDS', 'virtual/libgl', 'opengl', '', d)}"
+
# I say virtual/libgl, actually wants gl.pc
PACKAGECONFIG[glx] = "-Dwaffle_has_glx=1,-Dwaffle_has_glx=0,virtual/libgl libx11"
--
2.8.0
^ permalink raw reply related
* [PATCH 2/6] piglit: add opengl to REQUIRED_DISTRO_FEATURES
From: Christopher Larson @ 2017-01-04 22:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
In-Reply-To: <cover.1483570577.git.chris_larson@mentor.com>
From: Christopher Larson <chris_larson@mentor.com>
This recipe depend on virtual/libgl, whose providers require the opengl distro
feature.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/recipes-graphics/piglit/piglit_git.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb
index 82adcde..b9cdce8 100644
--- a/meta/recipes-graphics/piglit/piglit_git.bb
+++ b/meta/recipes-graphics/piglit/piglit_git.bb
@@ -22,6 +22,9 @@ inherit cmake python3native distro_features_check bash-completion
# depends on virtual/libx11
REQUIRED_DISTRO_FEATURES = "x11"
+# depends on virtual/libgl
+REQUIRED_DISTRO_FEATURES += "opengl"
+
# The built scripts go into the temporary directory according to tempfile
# (typically /tmp) which can race if multiple builds happen on the same machine,
# so tell it to use a directory in ${B} to avoid overwriting.
--
2.8.0
^ permalink raw reply related
* [PATCH 3/6] libglu: add opengl to REQUIRED_DISTRO_FEATURES
From: Christopher Larson @ 2017-01-04 22:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
In-Reply-To: <cover.1483570577.git.chris_larson@mentor.com>
From: Christopher Larson <chris_larson@mentor.com>
This requires libgl, and mesa requires the opengl distro feature.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/recipes-graphics/mesa/libglu_9.0.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/mesa/libglu_9.0.0.bb b/meta/recipes-graphics/mesa/libglu_9.0.0.bb
index 010998d..8b94613 100644
--- a/meta/recipes-graphics/mesa/libglu_9.0.0.bb
+++ b/meta/recipes-graphics/mesa/libglu_9.0.0.bb
@@ -24,7 +24,7 @@ DEPENDS = "virtual/libgl"
inherit autotools pkgconfig distro_features_check
# Requires libGL.so which is provided by mesa when x11 in DISTRO_FEATURES
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
# Remove the mesa-glu dependency in mesa-glu-dev, as mesa-glu is empty
RDEPENDS_${PN}-dev = ""
--
2.8.0
^ permalink raw reply related
* [PATCH 4/6] eglinfo-x11: add opengl to REQUIRED_DISTRO_FEATURES
From: Christopher Larson @ 2017-01-04 22:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
In-Reply-To: <cover.1483570577.git.chris_larson@mentor.com>
From: Christopher Larson <chris_larson@mentor.com>
The .inc already included this, but the x11 version was overriding it. This is
a problem, as the x11 version still needs opengl as well as x11. Append
instead.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.0.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.0.bb b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.0.bb
index 3427fdf..db00f76 100644
--- a/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.0.bb
+++ b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.0.bb
@@ -6,7 +6,8 @@ include eglinfo.inc
DEPENDS += "virtual/libx11"
inherit distro_features_check
+
# depends on virtual/libx11
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES += "x11"
SUMMARY += "(X11 version)"
--
2.8.0
^ permalink raw reply related
* [PATCH 5/6] packagegroup-self-hosted: add opengl to REQUIRED_DISTRO_FEATURES
From: Christopher Larson @ 2017-01-04 22:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
In-Reply-To: <cover.1483570577.git.chris_larson@mentor.com>
From: Christopher Larson <chris_larson@mentor.com>
This rdepends on libgl.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
index 73430b8..c1bbdfc 100644
--- a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
@@ -10,6 +10,9 @@ inherit packagegroup distro_features_check
# rdepends on libx11-dev
REQUIRED_DISTRO_FEATURES = "x11"
+# rdepends on libgl
+REQUIRED_DISTRO_FEATURES += "opengl"
+
PACKAGES = "\
packagegroup-self-hosted \
packagegroup-self-hosted-debug \
--
2.8.0
^ permalink raw reply related
* [PATCH 6/6] packagegroup-core-lsb: add opengl to REQUIRED_DISTRO_FEATURES
From: Christopher Larson @ 2017-01-04 22:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
In-Reply-To: <cover.1483570577.git.chris_larson@mentor.com>
From: Christopher Larson <chris_larson@mentor.com>
This group pulls in libglu, which needs virtual/libgl, whose providers require
opengl in DISTRO_FEATURES.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb b/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb
index 734dda1..3aedf6b 100644
--- a/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb
+++ b/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb
@@ -11,6 +11,9 @@ inherit packagegroup distro_features_check
# The libxt, libxtst and others require x11 in DISTRO_FEATURES
REQUIRED_DISTRO_FEATURES = "x11"
+# libglu needs virtual/libgl, which requires opengl in DISTRO_FEATURES
+REQUIRED_DISTRO_FEATURES += "opengl"
+
#
# We will skip parsing this packagegeoup for non-glibc systems
#
--
2.8.0
^ permalink raw reply related
* Re: [PATCH 3/6] libglu: add opengl to REQUIRED_DISTRO_FEATURES
From: Phil Blundell @ 2017-01-04 23:34 UTC (permalink / raw)
To: Christopher Larson, openembedded-core
In-Reply-To: <0f858d235ef2116b29251f6e471abdb62490532d.1483570577.git.chris_larson@mentor.com>
On Wed, 2017-01-04 at 15:57 -0700, Christopher Larson wrote:
>
> # Requires libGL.so which is provided by mesa when x11 in
> DISTRO_FEATURES
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
I sort of have the sense that something has gone a bit wrong with the
way {REQUIRED_}DISTRO_FEATURES is now being used.
The original concept with DISTRO_FEATURES was that it would just be a
global way of controlling the PACKAGECONFIG options for each recipe.
That is, if you have x11 in DISTRO_FEATURES then PACKAGECONFIG[x11]
would be turned on automatically for every recipe that supports it, and
so on. It was never really intended to be, and I still feel it
probably ought not to be, a filtering mechanism.
Or, to put it another way, just because you don't have x11 in
DISTRO_FEATURES doesn't necessarily mean that your distro refuses to
support x11 at all. It ought simply to mean that you don't
want packages compiled with X11 support where this is avoidable.
But in the particular case above, if the comment is correct then the
presence of x11 in REQUIRED_DISTRO_FEATURES seems bogus by any
interpretation. If it's really true that libGLU simply "Requires
libGL.so" then either:
a) it ought to have nothing at all in REQUIRED_DISTRO_FEATURES and
simply express a dependency on virtual/libgl (which would be my
preference); or
b) it ought to mention only opengl in REQUIRED_DISTRO_FEATURES
p.
^ permalink raw reply
* [PATCH] oe-selftest: Improve BUILDDIR environment handling
From: Richard Purdie @ 2017-01-04 23:48 UTC (permalink / raw)
To: openembedded-core
Its possible something (like bitbake/tinfoil2) may mess around with the
environment and using the enviroment as a global variable store isn't
particularly nice anyway.
This patch changes the BUILDDIR usages so that the environment isn't used
as a global store and a global variable is used instead. Whilst that
is still not perfect, it does avoid the current double and triple backtraces
we're seeing where tinfoil2/bitbake has trampled the enviroment leading
to failures of failures making debugging even harder.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
scripts/oe-selftest | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/scripts/oe-selftest b/scripts/oe-selftest
index bfcea66..e166521 100755
--- a/scripts/oe-selftest
+++ b/scripts/oe-selftest
@@ -111,9 +111,13 @@ def get_args_parser():
help='Submit test results to a repository')
return parser
+builddir = None
+
def preflight_check():
+ global builddir
+
log.info("Checking that everything is in order before running the tests")
if not os.environ.get("BUILDDIR"):
@@ -135,7 +139,7 @@ def preflight_check():
return True
def add_include():
- builddir = os.environ.get("BUILDDIR")
+ global builddir
if "#include added by oe-selftest.py" \
not in ftools.read_file(os.path.join(builddir, "conf/local.conf")):
log.info("Adding: \"include selftest.inc\" in local.conf")
@@ -149,7 +153,7 @@ def add_include():
"\n#include added by oe-selftest.py\ninclude bblayers.inc")
def remove_include():
- builddir = os.environ.get("BUILDDIR")
+ global builddir
if builddir is None:
return
if "#include added by oe-selftest.py" \
@@ -165,18 +169,21 @@ def remove_include():
"\n#include added by oe-selftest.py\ninclude bblayers.inc")
def remove_inc_files():
+ global builddir
+ if builddir is None:
+ return
try:
- os.remove(os.path.join(os.environ.get("BUILDDIR"), "conf/selftest.inc"))
+ os.remove(os.path.join(builddir, "conf/selftest.inc"))
for root, _, files in os.walk(get_test_layer()):
for f in files:
if f == 'test_recipe.inc':
os.remove(os.path.join(root, f))
- except (AttributeError, OSError,) as e: # AttributeError may happen if BUILDDIR is not set
+ except OSError as e:
pass
for incl_file in ['conf/bblayers.inc', 'conf/machine.inc']:
try:
- os.remove(os.path.join(os.environ.get("BUILDDIR"), incl_file))
+ os.remove(os.path.join(builddir, incl_file))
except:
pass
@@ -394,7 +401,7 @@ def coverage_setup(coverage_source, coverage_include, coverage_omit):
""" Set up the coverage measurement for the testcases to be run """
import datetime
import subprocess
- builddir = os.environ.get("BUILDDIR")
+ global builddir
pokydir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
curcommit= subprocess.check_output(["git", "--git-dir", os.path.join(pokydir, ".git"), "rev-parse", "HEAD"]).decode('utf-8')
coveragerc = "%s/.coveragerc" % builddir
--
2.7.4
^ permalink raw reply related
* Re: [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes
From: Burton, Ross @ 2017-01-04 23:49 UTC (permalink / raw)
To: Christopher Larson; +Cc: Christopher Larson, OE-core
In-Reply-To: <cover.1483570577.git.chris_larson@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
On 4 January 2017 at 22:57, Christopher Larson <kergoth@gmail.com> wrote:
> These aren't buildable without it, and adding it fixes oe-core world builds
> with nodistro (which does not have the opengl feature by default).
>
Am I still the only person who thinks skipping of recipes should be
recursive, so if say libx11 throws a SkipRecipe then everything else that
depends on it is also magically skipped?
Ross
[-- Attachment #2: Type: text/html, Size: 833 bytes --]
^ permalink raw reply
* Re: [PATCH 3/6] ksize.py: Python 3 fixes
From: Khem Raj @ 2017-01-04 23:52 UTC (permalink / raw)
To: Alejandro Hernandez; +Cc: Patches and discussions about the oe-core layer
In-Reply-To: <3bafb872-955d-88a1-a627-243c8fe40fa3@linux.intel.com>
On Wed, Jan 4, 2017 at 2:18 PM, Alejandro Hernandez
<alejandro.hernandez@linux.intel.com> wrote:
> Hey Khem,
>
> Ok, now I'm actually awake when reading this, are you saying these changes
> should go in the same patch as the one for ksum.py?
>
yes thats right.
>
>
> On 01/04/2017 12:21 PM, Alejandro Hernandez wrote:
>>
>> Hey Khem,
>>
>>
>> Its an old script fro Tom, but as far as I remember it worked fine on
>> python3, although thanks for checking and sending the patch!
>>
>> Cheers
>>
>> Alejandro
>>
>>
>> On 01/04/2017 12:39 AM, Khem Raj wrote:
>>>
>>> On Tue, Jan 3, 2017 at 2:30 PM, Alejandro Hernandez
>>> <alejandro.hernandez@linux.intel.com> wrote:
>>>>
>>>> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>>>>
>>>> String errors and partial __cmp__ fix.
>>>
>>> may be fold it into previous patch.
>>>
>>>> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>>>> ---
>>>> scripts/tiny/ksize.py | 17 ++++++++++++-----
>>>> 1 file changed, 12 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/scripts/tiny/ksize.py b/scripts/tiny/ksize.py
>>>> index b9d2b19..ea1ca7f 100755
>>>> --- a/scripts/tiny/ksize.py
>>>> +++ b/scripts/tiny/ksize.py
>>>> @@ -41,7 +41,7 @@ def usage():
>>>> class Sizes:
>>>> def __init__(self, glob):
>>>> self.title = glob
>>>> - p = Popen("size -t " + glob, shell=True, stdout=PIPE,
>>>> stderr=PIPE)
>>>> + p = Popen("size -t " + str(glob), shell=True, stdout=PIPE,
>>>> stderr=PIPE)
>>>> output = p.communicate()[0].splitlines()
>>>> if len(output) > 2:
>>>> sizes = output[-1].split()[0:4]
>>>> @@ -62,18 +62,18 @@ class Report:
>>>> r = Report(filename, title)
>>>> path = os.path.dirname(filename)
>>>>
>>>> - p = Popen("ls " + path + "/*.o | grep -v built-in.o",
>>>> + p = Popen("ls " + str(path) + "/*.o | grep -v built-in.o",
>>>> shell=True, stdout=PIPE, stderr=PIPE)
>>>> glob = ' '.join(p.communicate()[0].splitlines())
>>>> - oreport = Report(glob, path + "/*.o")
>>>> - oreport.sizes.title = path + "/*.o"
>>>> + oreport = Report(glob, str(path) + "/*.o")
>>>> + oreport.sizes.title = str(path) + "/*.o"
>>>> r.parts.append(oreport)
>>>>
>>>> if subglob:
>>>> p = Popen("ls " + subglob, shell=True, stdout=PIPE,
>>>> stderr=PIPE)
>>>> for f in p.communicate()[0].splitlines():
>>>> path = os.path.dirname(f)
>>>> - r.parts.append(Report.create(f, path, path +
>>>> "/*/built-in.o"))
>>>> + r.parts.append(Report.create(f, path, str(path) +
>>>> "/*/built-in.o"))
>>>> r.parts.sort(reverse=True)
>>>>
>>>> for b in r.parts:
>>>> @@ -116,6 +116,13 @@ class Report:
>>>> self.deltas["data"], self.deltas["bss"]))
>>>> print("\n")
>>>>
>>>> + def __lt__(this, that):
>>>> + if that is None:
>>>> + return 1
>>>> + if not isinstance(that, Report):
>>>> + raise TypeError
>>>> + return this.sizes.total < that.sizes.total
>>>> +
>>>> def __cmp__(this, that):
>>>> if that is None:
>>>> return 1
>>>> --
>>>> 2.6.6
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
>
^ permalink raw reply
* Re: [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes
From: Khem Raj @ 2017-01-05 0:52 UTC (permalink / raw)
To: Burton, Ross; +Cc: Christopher Larson, OE-core
In-Reply-To: <CAJTo0LYepu3mAAc=Y76RxBW20w1gEVH1+ms7gpfmSTB-ePfrcQ@mail.gmail.com>
On Wed, Jan 4, 2017 at 3:49 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 4 January 2017 at 22:57, Christopher Larson <kergoth@gmail.com> wrote:
>>
>> These aren't buildable without it, and adding it fixes oe-core world
>> builds
>> with nodistro (which does not have the opengl feature by default).
>
>
> Am I still the only person who thinks skipping of recipes should be
> recursive, so if say libx11 throws a SkipRecipe then everything else that
> depends on it is also magically skipped?
Somewhere, we need to flag that user is shooting his own foot by
skipping a given recipe.
>
> Ross
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply
* Re: [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes
From: Christopher Larson @ 2017-01-05 1:13 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
In-Reply-To: <CAJTo0LYepu3mAAc=Y76RxBW20w1gEVH1+ms7gpfmSTB-ePfrcQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On Wed, Jan 4, 2017 at 4:49 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 4 January 2017 at 22:57, Christopher Larson <kergoth@gmail.com> wrote:
>
>> These aren't buildable without it, and adding it fixes oe-core world
>> builds
>> with nodistro (which does not have the opengl feature by default).
>>
>
> Am I still the only person who thinks skipping of recipes should be
> recursive, so if say libx11 throws a SkipRecipe then everything else that
> depends on it is also magically skipped?
I’d agree with that. It’d be a nice improvement. The user would see an
explicit error if they try to build it, as is always the case with skipped
recipes, but it’d be silently excluded from world the way skipped recipes
usually are.
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
[-- Attachment #2: Type: text/html, Size: 1700 bytes --]
^ permalink raw reply
* Re: [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes
From: Khem Raj @ 2017-01-05 1:27 UTC (permalink / raw)
To: Christopher Larson; +Cc: OE-core
In-Reply-To: <CABcZAN=yV3qbbQVVcSeWjdEBpf9uSd-f93LDFs-HsEYDjb6tDQ@mail.gmail.com>
On Wed, Jan 4, 2017 at 5:13 PM, Christopher Larson <kergoth@gmail.com> wrote:
>
> On Wed, Jan 4, 2017 at 4:49 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> On 4 January 2017 at 22:57, Christopher Larson <kergoth@gmail.com> wrote:
>>>
>>> These aren't buildable without it, and adding it fixes oe-core world
>>> builds
>>> with nodistro (which does not have the opengl feature by default).
>>
>>
>> Am I still the only person who thinks skipping of recipes should be
>> recursive, so if say libx11 throws a SkipRecipe then everything else that
>> depends on it is also magically skipped?
>
>
> I’d agree with that. It’d be a nice improvement. The user would see an
> explicit error if they try to build it, as is always the case with skipped
> recipes, but it’d be silently excluded from world the way skipped recipes
> usually are.
excluding from world builds is a fair argument.
> --
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox