From: "John Willis" <John.Willis@Distant-earth.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: Request to revert latest devicekit patch
Date: Sun, 24 Jan 2010 18:26:33 -0000 [thread overview]
Message-ID: <01a901ca9d22$c508d620$4f1a8260$@Willis@Distant-earth.com> (raw)
In-Reply-To: <hjhssf$55g$1@ger.gmane.org>
Rolf,
Replying to your mail on-list.
As the author of said patch if people want it reverted go ahead. It has my
ACK.
> Koen Kooi wrote:
> > On 24-01-10 12:35, Holger Hans Peter Freyther wrote:
> >> Can anyone ack the revert please?
> >
> > The commit says:
> >
> > Note: Another (maybe better) fix would be to package up docbook-xsl
> but
> > that is overkill for these two recipes.
>
> To introduce something new that patch breaks something for somebody
> else
> that was previously working. I thought it was commonly accepted that
> it's then the author's (and possibly the committer's) responsibility to
> come up with something better to fix this regression.
>
> > Wouldn't that be a better option than introducing a regression?
>
> The regression was introduced with the patch. Not by reverting it.
>
> A revert gets my ACK if this bothers Holger enough in his workflow. I
> would suggest Holger and David-John should talk about a time-frame in
> which David-John can cook up a proper patch. Based on this information
> a decision should be made if a revert is necessary in the meantime or
> not. I trust Holger's judgment here.
>
>
> PS: David-John, the whole discussion is at
> http://thread.gmane.org/gmane.comp.handhelds.openembedded/29524
As I stated in the original patch the correct fix is to sort out the
docbook-xsl packages but that was not something I had any intention at the
time to tackle (limited OE dev time and a seemingly infinite TODO list). I
may be able to look at it in the near future but as for being the best man
for the job, that I am not so sure about.
The sole reason for the patch was to fix a build failure on systems where
the host system docbook-xsl stuff was not available (or desired).
Reverting the -nonet will reintroduce dependencies on components being
installed on the host system outside OE but if that is fine then go for the
revert. I understood (at the time, this is back in October) that depending
on host items outside oe's -native was a 'very bad thing' (tm) ;). Maybe
worse than requiring an internet connection but I am not the person to judge
that.
I'll leave it to core OE devs to decide what is the lesser of 2 evils in
this case.
Regards,
John
prev parent reply other threads:[~2010-01-24 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 11:35 Request to revert latest devicekit patch Holger Hans Peter Freyther
2010-01-24 12:48 ` Koen Kooi
2010-01-24 13:49 ` Stanislav Brabec
2010-01-24 15:54 ` Rolf Leggewie
2010-01-24 16:24 ` Koen Kooi
2010-01-24 16:35 ` Rolf Leggewie
2010-01-24 18:26 ` John Willis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01a901ca9d22$c508d620$4f1a8260$@Willis@Distant-earth.com' \
--to=john.willis@distant-earth.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox