Re: [PATCH 8/8] xz: add xz package

[Phil Blundell <philb@gnu.org>]

On Wed, 2010-02-10 at 21:13 +0100, Bernhard Reutner-Fischer wrote:
> xz is the lzma successor
> tested with automake-1.11.1, autoconf-2.65

Thanks for the patch.  I think this could use a little cleanup before it
is committed, though; please see below.

> index 0000000..bc5e9ff
> --- /dev/null
> +++ b/recipes/xz/xz-native.inc
> @@ -0,0 +1,2 @@
> +inherit native
> +require xz_${PV}.bb

You could consider using BBCLASSEXTEND to eliminate the need for this
separate recipe.

> diff --git a/recipes/xz/xz-native_4.999.9beta.bb b/recipes/xz/xz-native_4.999.9beta.bb
> new file mode 100644
> index 0000000..c4f0da9
> --- /dev/null
> +++ b/recipes/xz/xz-native_4.999.9beta.bb
> @@ -0,0 +1,3 @@
> +PV = "4.999.9beta"
> +
> +require xz-native.inc

Is it necessary to set PV here?  I would have thought base.bbclass would
infer that same value from the filename.

> diff --git a/recipes/xz/xz-native_git.bb b/recipes/xz/xz-native_git.bb
> new file mode 100644
> index 0000000..006b9d7
> --- /dev/null
> +++ b/recipes/xz/xz-native_git.bb
> @@ -0,0 +1,7 @@
> +# XZ_BASE should be the latest released version of xz.
> +# It can be set in the distro file.
> +#XZ_BASE ?= "4.999.9"
> +#SRCREV = "HEAD"
> +#PV = "${XZ_BASE}+gitr${SRCREV}"

Please don't leave this sort of stuff commented out in the file.  If
it's not needed, just delete those lines.

> +#FILESDIR = "${@os.path.dirname(bb.data.getVar('FILE',d,1))}/xz-${PV}"

Likewise for that.

> --- /dev/null
> +++ b/recipes/xz/xz_4.999.9beta.bb
> @@ -0,0 +1,8 @@
> +PV = "4.999.9beta"

See above regarding PV.

> +
> +require xz.inc
> +PR = "${INC_PR}.0"
> +SRC_URI = "http://tukaani.org/xz/xz-${PV}.tar.bz2;name=xz"

Wouldn't that SRC_URI be better in the .inc file?  Presumably this is
the correct URI for everything except the _git version.

> +SRC_URI[xz.md5sum] = "cc4044fcc073b8bcf3164d1d0df82161"
> +SRC_URI[xz.sha256sum] = "330312c4397608d8b7be362cc7edbfeafa6101614bc2164d816ea767656aa15c"
> +EXTRA_OECONF = "--enable-shared"

Likewise for that EXTRA_OECONF, I would have thought that would also
belong in the .inc really.

p.