Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@rpsys.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: gcc Recipes
Date: Wed, 31 Mar 2010 21:20:18 +0100	[thread overview]
Message-ID: <1270066818.1681.981.camel@rex> (raw)
In-Reply-To: <x2z19c1b8a91003311025w5516e09at69ad3d50134f0380@mail.gmail.com>

On Wed, 2010-03-31 at 10:25 -0700, Khem Raj wrote:
> On Wed, Mar 31, 2010 at 4:28 AM, Richard Purdie <rpurdie@rpsys.net> wrote:
> > To illustrate the kind of thing I mean, have a look at this commit:
> >
> > http://git.openembedded.net/cgit.cgi/openembedded/commit/?h=rpurdie/work-in-progress&id=35481122d7e484fb740ad9440fb4c70cb01de48f
> >
> 
> in one place you removed DEPENDS that may not be correct. Because
> DEPENDS get overwritten in gcc-cross-initial.inc

Ah, I messed up the commits. That bit should have been in the previous
commit where it makes more sense:

http://git.openembedded.net/cgit.cgi/openembedded/commit/?h=rpurdie/work-in-progress&id=ec04a8b72958e616da55e30ec1d731424d77ed9d

> > The nice thing about this is all of a sudden we have all the flags in
> > the same place and it becomes obvious if something is wrong. There are a
> > few things that raise an eyebrow there. It also becomes easier to
> > abstract some of the gcc-X.Y.Z.inc data into a common include file
> > (maybe a gcc-4.3.X.inc for example).
> 
> I this this is a good idea. We could even capture some bugs like in
> some recipes we use EXTRA_OECONF_BASE += and in some EXTRA_OECONF_BASE
> =

Exactly the kind of thing I'd like to catch!

> > Does anyone else fancy helping trying to clean this mess up. I'm happy
> > to review some cleanup patches?
> 
> I plan to do some of this restructuring when I am back from my time
> off in end of april.

Great, any help would be welcome with this kind of thing :)

Cheers

Richard




      reply	other threads:[~2010-03-31 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 11:28 gcc Recipes Richard Purdie
2010-03-31 11:45 ` Frans Meulenbroeks
2010-03-31 12:10   ` Phil Blundell
2010-03-31 13:00   ` Richard Purdie
2010-03-31 16:12 ` Mark Richards
2010-03-31 17:25 ` Khem Raj
2010-03-31 20:20   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270066818.1681.981.camel@rex \
    --to=rpurdie@rpsys.net \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox