Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@rpsys.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [RFC] Badness with -ibad, a replacement for zecke-no-host-includes.patch.
Date: Fri, 09 Jul 2010 11:44:54 +0100	[thread overview]
Message-ID: <1278672294.28835.95.camel@rex> (raw)
In-Reply-To: <4C35F08F.1040705@freyther.de>

On Thu, 2010-07-08 at 23:36 +0800, Holger Freyther wrote:
> On 07/08/2010 01:39 PM, Graham Gower wrote:
> > This patch introduces a new command line parameter to gcc (at
> > Zecke's suggestion), -ibad, which may be used to specify
> > blacklisted include prefixes. E.g.
> > 
> > grg@eye7:/tmp$ ~/oe2/tmp/cross/mipsel/bin/mipsel-angstrom-linux-gcc -c test.c -ibad /usr/include -I /usr/include
> > CROSS COMPILE Badness: /usr/include in INCLUDEPATH: /usr/include
> 
> nice! The only thing that is worrying is the question how we make sure
> these bad path's are enforced.
> 
> E.g. a recipe not honoring our CPPFLAGS might silently pass this check
> (while before it was hardcoded into the compiler). My proposal would be
> to extend the sanity check and grep the compile log for gcc and -ibad
> and fail if gcc exists but -ibad does not occur?

How about making this option an environmental variable rather than a
flag? I've seen that technique used to great effect for this exact
reason before...

Cheers,

Richard




  parent reply	other threads:[~2010-07-09 10:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  5:39 [RFC] Badness with -ibad, a replacement for zecke-no-host-includes.patch Graham Gower
2010-07-08  5:41 ` Graham Gower
2010-07-08 10:01 ` Koen Kooi
2010-07-08 10:56   ` Graham Gower
2010-07-08 12:12     ` Koen Kooi
2010-07-08 15:36 ` Holger Freyther
2010-07-09  9:41   ` Phil Blundell
2010-07-09 10:44   ` Richard Purdie [this message]
2010-07-10  7:04     ` Graham Gower
2010-07-08 17:21 ` Denys Dmytriyenko
2010-07-10  6:57   ` Graham Gower
2010-07-08 21:00 ` Khem Raj
2010-07-13  2:27 ` [PATCH] gcc: badness " Graham Gower

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278672294.28835.95.camel@rex \
    --to=rpurdie@rpsys.net \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox