Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Phil Blundell <philb@gnu.org>]

On Mon, 2010-07-19 at 09:29 -0700, Khem Raj wrote:
> On Mon, Jul 19, 2010 at 7:26 AM, Phil Blundell <philb@gnu.org> wrote:
> > On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
> >> -THUMB_INTERWORK = "yes"
> >> +# armv4 does not have thumb instruction set therefore no interworking instructions
> >> +# so if machine is based on armv4 we dont have choice.
> >> +
> >> +THUMB_INTERWORK_armv4 = "no"
> >> +THUMB_INTERWORK ?= "yes"
> >
> > I don't think this is necessary or desirable.  If you are building for
> > v4 then the BX instructions ought to be fixed up during final link.
> 
> Yes with --fix-v4bx/--fix-v4bx-interworking its possible.
> 
> 
> Is
> > there a particular problem that you're trying to solve?
> >
> 
> Not any particular case but some versions of compiler do not pass
> flags to --fix-v4bx-interworking ld.

True.  But this is sane-toolchain we're talking about, and the version
that it selects by default (4.4.4) does get this right.  So I don't
think it's going to be a big deal in practice.

p.