From: Phil Blundell <philb@gnu.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 1/2] recipes: fix LICENSE fields
Date: Tue, 10 May 2011 10:40:03 +0100 [thread overview]
Message-ID: <1305020403.8000.141.camel@phil-desktop> (raw)
In-Reply-To: <20110510093616.GB3673@jama.jama.net>
On Tue, 2011-05-10 at 11:36 +0200, Martin Jansa wrote:
> it calls cd tmp/deploy/sources/$license/pixman
> where with $license == '&' (because LICENSE field is splitted by ' ' and
> then '|'), it ends doing cd on background and then complaing about /pixman
Right, so that is a bug. The argument to cd should be quoted. (There
is no need for backslashes as your mail implied.)
> Directory named & even when created with right backslash
> is still hard to use, so I think it would be better to have QA check
> that LICENSE field has sane value, even better when we have list of
> possible values etc.
Yes, agreed, but I think the quoting bug should also be fixed.
p.
next prev parent reply other threads:[~2011-05-10 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 7:39 [PATCH 1/2] recipes: fix LICENSE fields Martin Jansa
2011-05-10 7:39 ` [PATCH 2/2] recipes: drop '+' from " Martin Jansa
2011-05-10 8:01 ` Koen Kooi
2011-05-10 8:00 ` [PATCH 1/2] recipes: fix " Koen Kooi
2011-05-10 9:28 ` Phil Blundell
2011-05-10 9:36 ` Martin Jansa
2011-05-10 9:40 ` Phil Blundell [this message]
2011-05-12 16:39 ` Denys Dmytriyenko
2011-05-12 18:21 ` Martin Jansa
2011-05-12 20:32 ` Denys Dmytriyenko
2011-05-12 20:36 ` [OE-core] " Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305020403.8000.141.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox