From: Paul Menzel <paulepanter@users.sourceforge.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-efl][meta-oe 05/12] id3lib: Import from openembedded classic
Date: Sat, 29 Oct 2011 14:33:27 +0200 [thread overview]
Message-ID: <1319891607.3756.18.camel@mattotaupa> (raw)
In-Reply-To: <3bcd2fb9e853253747293c584109ab394ba3fd4e.1319884094.git.Martin.Jansa@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2319 bytes --]
Dear Martin, dear Denis,
Am Samstag, den 29.10.2011, 12:29 +0200 schrieb Martin Jansa:
> From: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
>
> Added LIC_FILES_CHKSUM, and fixed LICENSE
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
NACK.
please add the version you import and the commit ID you import from.
This is all written in the guide lines [1]!
> ---
> meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb | 18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
> create mode 100644 meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb
>
> diff --git a/meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb b/meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb
> new file mode 100644
> index 0000000..9be4ffb
> --- /dev/null
> +++ b/meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "Library for interacting with ID3 tags."
> +SECTION = "libs/multimedia"
> +PRIORITY = "optional"
> +DEPENDS = "zlib"
> +LICENSE = "GPLv2+"
That is not correct [2], it is `LGPLv2+`. Additionally the header
ordering is not the standard. I thought migration to meta-oe was
supposed to be a chance to clean up the recipes.
> +LIC_FILES_CHKSUM = "files://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7"
> +PR = "r0"
According to Koen these are going away. Unfortunately these things are
discussed on oe-core instead of openembedded-devel as described in the
Wiki [3].
> +inherit autotools
> +
> +SRC_URI = "${SOURCEFORGE_MIRROR}/id3lib/id3lib-${PV}.tar.gz;name=archive \
> + http://ftp.de.debian.org/debian/pool/main/i/id3lib3.8.3/id3lib3.8.3_3.8.3-7.2.diff.gz;name=patch \
> + "
> +
> +SRC_URI[archive.md5sum] = "19f27ddd2dda4b2d26a559a4f0f402a7"
> +SRC_URI[archive.sha256sum] = "2749cc3c0cd7280b299518b1ddf5a5bcfe2d1100614519b68702230e26c7d079"
> +SRC_URI[patch.md5sum] = "805c0320a2efb21c40ce06fa13cd7c4b"
> +SRC_URI[patch.sha256sum] = "9f03b59ccc8826a5be55a3dcde2f889067d58bdc72bf846416a198c9b933704c"
Thanks,
Paul
[1] http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
[2] http://git.openembedded.org/openembedded/log/recipes/id3lib/id3lib_3.8.3.bb
[3] http://www.openembedded.org/wiki/Mailing_lists
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2011-10-29 12:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 10:28 [meta-efl][meta-oe 00/12] EFL upgrade and few small fixes and additions Martin Jansa
2011-10-29 10:28 ` [meta-efl][meta-oe 01/12] midori: fix build with dirty vala Martin Jansa
2011-10-29 10:28 ` [meta-efl][meta-oe 02/12] xserver-common_1.34: patch Xserver to add support for gta04 Martin Jansa
2011-10-29 10:28 ` [meta-efl][meta-oe 03/12] navit: upgrade to latest SRCREV and remove navit-icons Martin Jansa
2011-10-29 10:29 ` [meta-efl][meta-oe 04/12] xserver-nodm-init: set USER and HOME Martin Jansa
2011-10-29 10:29 ` [meta-efl][meta-oe 05/12] id3lib: Import from openembedded classic Martin Jansa
2011-10-29 12:33 ` Paul Menzel [this message]
2011-10-31 9:55 ` Paul Eggleton
2011-10-31 10:50 ` Koen Kooi
2011-10-31 16:23 ` Paul Menzel
2011-10-31 10:50 ` Koen Kooi
2011-10-31 16:24 ` Paul Menzel
2011-10-31 16:36 ` Dodji Seketeli
2011-10-31 17:48 ` Koen Kooi
2011-10-31 21:18 ` Philip Balister
2011-10-31 22:12 ` Koen Kooi
2011-10-31 22:33 ` Frans Meulenbroeks
2011-11-01 11:40 ` Paul Eggleton
2011-11-01 19:21 ` Denys Dmytriyenko
2011-10-29 10:29 ` [meta-efl][meta-oe 06/12] liblinebreak: import " Martin Jansa
2011-10-29 12:37 ` Paul Menzel
2011-10-31 10:51 ` Koen Kooi
2011-10-29 10:29 ` [meta-efl][meta-oe 07/12] e-base: bump EFL_SRCREV and refresh patches and elementary version Martin Jansa
2011-11-01 8:27 ` Koen Kooi
2011-11-01 8:36 ` Martin Jansa
2011-10-29 10:29 ` [meta-efl][meta-oe 08/12] elsa: add new login manager for Enlightenment Martin Jansa
2011-10-29 11:56 ` Paul Menzel
2011-10-29 12:42 ` Martin Jansa
2011-10-29 10:29 ` [meta-efl][meta-oe 09/12] task-x11-server: import from Angstrom Martin Jansa
2011-10-29 11:59 ` Paul Menzel
2011-10-29 12:35 ` Martin Jansa
2011-11-01 7:48 ` Koen Kooi
2011-11-01 8:08 ` Martin Jansa
2011-10-29 10:29 ` [meta-efl][meta-oe 10/12] task-x11: remove server parts and add VIRTUAL_RUNTIME variables to be able to select different -common and init providers Martin Jansa
2011-11-01 7:52 ` Koen Kooi
2011-11-01 8:04 ` Martin Jansa
2011-10-29 10:29 ` [meta-efl][meta-oe 11/12] systemd-serialgetty: use better default SERIAL_CONSOLE Martin Jansa
2011-10-31 10:53 ` Koen Kooi
2011-10-31 13:25 ` Martin Jansa
2011-10-29 10:29 ` [meta-efl][meta-oe 12/12] elfe: add another patch to fix API changes Martin Jansa
2011-10-29 12:02 ` Paul Menzel
2011-10-29 12:33 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319891607.3756.18.camel@mattotaupa \
--to=paulepanter@users.sourceforge.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox