From: Elvis Dowson <elvis.dowson@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Elvis Dowson <elvis.dowson@gmail.com>
Subject: [meta-xilinx] xilinx-boot: Change string comparision checks to use strict POSIX compliance.
Date: Sun, 3 Jun 2012 00:28:07 +0200 [thread overview]
Message-ID: <1338676087-29276-1-git-send-email-elvis.dowson@gmail.com> (raw)
This commit fixes an issue with string comparision checks failing because
of not using strict POSIX compliance, therby resulting in wrong definitions
being generated into the ${xparam} file.
Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
---
classes/xilinx-boot.bbclass | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/classes/xilinx-boot.bbclass b/classes/xilinx-boot.bbclass
index d85ab80..a7f1f1d 100644
--- a/classes/xilinx-boot.bbclass
+++ b/classes/xilinx-boot.bbclass
@@ -21,10 +21,10 @@
do_export_xparam() {
bbnote "Replacing xparameters header to match hardware model"
xparam=$1
-if [ "${TARGET_ARCH}" == "powerpc" ]; then
+if [ "${TARGET_ARCH}" = "powerpc" ]; then
cpu="PPC`echo ${TARGET_CPU} | tr '[:lower:]' '[:upper:]'`"
else
- cpu=`echo ${TARGET_CPU} | tr '[:lower:]' '[:upper:]'`
+ cpu="`echo ${TARGET_CPU} | tr '[:lower:]' '[:upper:]'`"
fi
cp ${xparam} ${S}/board/xilinx/${XILINX_BOARD}
echo "/*** Cannonical definitions ***/
@@ -39,7 +39,7 @@ echo "/*** Cannonical definitions ***/
do_mk_xparam() {
bbnote "Replacing xparameters.mk configuration file"
xparam=$1
-if [ "${TARGET_ARCH}" == "powerpc" ]; then
+if [ "${TARGET_ARCH}" = "powerpc" ]; then
if grep -qoe XPAR_IIC_0_DEVICE_ID ${xparam}; then
echo -e "XPAR_IIC := y" > ${S}/board/xilinx/${XILINX_BOARD}/xparameters.mk
else
@@ -65,7 +65,7 @@ bbnote "Generate system ace image"
# Set Xilinx EDK tools
if [ -z ${XILINX_EDK} ]; then
# Get Xilinx version
- if [ ${BUILD_ARCH} == "x86_64" ]; then
+ if [ "${BUILD_ARCH}" = "x86_64" ]; then
EDK_SRCIPT="settings64.sh"
else
EDK_SRCIPT="settings.sh"
@@ -98,7 +98,7 @@ if [ ! -f implementation/download.bit ]; then
make -f ${XILINX_BSP_PATH}/system.make init_bram
fi
-if [ "${TARGET_ARCH}" == "powerpc" ]; then
+if [ "${TARGET_ARCH}" = "powerpc" ]; then
# Find u-boot start address
start_address=`${TARGET_PREFIX}objdump -x u-boot | grep -w "start address" | cut -d ' ' -f3`
# Generate ACE image
--
1.7.9.5
reply other threads:[~2012-06-02 22:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338676087-29276-1-git-send-email-elvis.dowson@gmail.com \
--to=elvis.dowson@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox