From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>,
Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-devel@lists.openembedded.org,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [oe-commits] Mark Hatle : base.bbclass: Deprecate the PRINC logic
Date: Tue, 28 May 2013 15:06:17 +0100 [thread overview]
Message-ID: <1369749977.14887.165.camel@ted> (raw)
In-Reply-To: <20130528134606.GJ3192@jama>
On Tue, 2013-05-28 at 15:46 +0200, Martin Jansa wrote:
> On Tue, May 28, 2013 at 01:28:41PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master-next
> > Commit: e1cf564ebc8e7b4fa626a645356f6a4d7f5ba064
> > URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=e1cf564ebc8e7b4fa626a645356f6a4d7f5ba064
> >
> > Author: Mark Hatle <mark.hatle@windriver.com>
> > Date: Tue May 21 13:29:03 2013 -0500
> >
> > base.bbclass: Deprecate the PRINC logic
> >
> > The PRINC logic is now deprecated, the PR server should be used to handle
> > the automatic incrementing of the PR (package release) field. The default
> > setting of '0' has been removed, and a warning message has been added.
>
> How are people supposed to remove existing PRINC without causing version
> going backwards?
>
> Do I have to choose between seeing 100 warnings about deprecated PRINC
> or 100 ERRORs from buildhistory about versions going backwards?
Sorry, this is coming out a bit backwards.
At the TSC meeting, we discussed ways of progressing with removal of
PRINC as it is causing pain and we shouldn't need it any more. We were
wondering if we could have the system warn on usage of PRINC, then
accept PR bumps to the main recipe at the same time that the usage of
PRINC was removed (taking PR bumps and removing PRINC seems to be the
only way to proceed). Initially I wondered if we could make it a hard
error, which would then force the PR bump to be in sync with the
removal. People are justifiably concerned at the idea of hard errors
though.
Mark sent me a patch, I thought it was an RFC on the list and applied it
to master-next to experiment with. It wasn't send to the list, I'm not
sure what Mark's intention was, its possible I was supposed to raise the
subject, then post the patch.
Anyhow, as you point out, the patch has a couple of issues. We need to
put back the default value into local.conf for now at the very least so
this warns, rather than gives an obtuse error. Its not going into master
until there is more discussion.
So lets reset here, Mark will post the RFC patch and we can discuss
whether there is a way we can get rid of the PRINC usage without causing
people too many problems. Sorry for the confusion caused :/.
Cheers,
Richard
next prev parent reply other threads:[~2013-05-28 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130528132841.A450B5039B@opal>
2013-05-28 13:46 ` [oe-commits] Mark Hatle : base.bbclass: Deprecate the PRINC logic Martin Jansa
2013-05-28 13:56 ` Martin Jansa
2013-05-28 14:06 ` Richard Purdie [this message]
2013-05-28 15:36 ` [OE-core] " Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369749977.14887.165.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=mark.hatle@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox