Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Sujith H <sujith.h@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Christopher Larson <chris_larson@mentor.com>
Subject: [meta-java][PATCH] xpp[23]: fix/remove bashism
Date: Mon, 12 Sep 2016 13:44:51 +0530	[thread overview]
Message-ID: <1473668091-5615-1-git-send-email-sujith.h@gmail.com> (raw)

From: Christopher Larson <chris_larson@mentor.com>

This was breaking on hosts with dash as /bin/sh.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 recipes-core/xml-commons/xpp2_2.1.10.bb    | 2 +-
 recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-core/xml-commons/xpp2_2.1.10.bb b/recipes-core/xml-commons/xpp2_2.1.10.bb
index d3baca4..c926722 100644
--- a/recipes-core/xml-commons/xpp2_2.1.10.bb
+++ b/recipes-core/xml-commons/xpp2_2.1.10.bb
@@ -19,7 +19,7 @@ do_compile() {
 
     sourcepath="src/java/drivers/jaxp11:src/java/drivers/sax2:src/java/impl/factory:src/java/impl/format:src/java/impl/node:src/java/impl/pullparser:src/java/impl/tag:src/java/intf"
 
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name "*.java"`
 
diff --git a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
index bedb8a9..f264022 100644
--- a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
+++ b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
@@ -19,7 +19,7 @@ do_compile() {
     mkdir -p build-oe
 
     sourcepath="src/java/api:src/java/builder:src/java/dom2_builder:src/java/mxp1_min:src/java/mxp1_standard:src/java/parser_pool:src/java/sax2_driver:src/java/serializer_impl:src/java/util:src/java/wrapper"
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name "*.java"`
 
-- 
1.9.1



             reply	other threads:[~2016-09-12  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  8:14 Sujith H [this message]
2016-09-12  9:47 ` [meta-java][PATCH] xpp[23]: fix/remove bashism sujith h
2016-09-12 12:11   ` Maxin B. John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473668091-5615-1-git-send-email-sujith.h@gmail.com \
    --to=sujith.h@gmail.com \
    --cc=chris_larson@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox