Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: [PATCH v2] netcat-openbsd: fix implicit dependency on pkg-config
Date: Sun, 19 Feb 2017 20:15:49 -0500	[thread overview]
Message-ID: <1487553349-22706-1-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <CAMKF1sqyxtRoLsi1QvABn7kVsskgLcUXXb7N_0JFct5ukiqUwg@mail.gmail.com>

In the report at http://errors.yoctoproject.org/Errors/Details/130673/
we see the following:

i586-oe-linux-gcc  -m32 -march=i586 <snip> netcat.o atomicio.o socks.o `pkg-config --libs libbsd` -lresolv -o nc
/bin/sh: 1: pkg-config: not found

What follows is a bunch of link errors for BSD library functions, as
the backtick didn't return anything but an empty string and hence no
BSD library was involved in the link.

I was able to reproduce this by temporarily removing my host version
of pkg-config, and then validated that this fix solves it while still
having the host binary removed.  So it should fix the reported issue.
I also confirmed pkg-config was in the sysroot after the change.

Cc: Khem Raj <raj.khem@gmail.com>
Cc: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[v2: use inherit pkgconfig vs. depending on it, as per what
 Khem suggested as being the more conventional route. ]

 meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb b/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
index bb21e0cfeede..e0a0328eccfc 100644
--- a/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
+++ b/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
@@ -14,6 +14,8 @@ SRC_URI[netcat.sha256sum] = "40653fe66c1516876b61b07e093d826e2a5463c5d994f1b7e6c
 SRC_URI[netcat-patch.md5sum] = "e914f8eb7eda5c75c679dd77787ac76b"
 SRC_URI[netcat-patch.sha256sum] = "eee759327ffea293e81d0dde67921b7fcfcad279ffd7a2c9d037bbc8f882b363"
 
+inherit pkgconfig
+
 S = "${WORKDIR}/${BPN}-${PV}"
 
 EXTRA_OEMAKE += "'LDFLAGS=${LDFLAGS}'"
@@ -42,5 +44,3 @@ do_install() {
     install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN}
 }
 ALTERNATIVE_PRIORITY = "60"
-
-PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130673/"
-- 
2.7.4



      parent reply	other threads:[~2017-02-20  1:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-19  1:11 [PATCH] netcat-openbsd: fix implicit dependency on pkg-config Paul Gortmaker
2017-02-19  6:07 ` Khem Raj
2017-02-19 22:56   ` Paul Gortmaker
2017-02-20  1:15   ` Paul Gortmaker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487553349-22706-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox