Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Koen Kooi <koen@openembedded.org>
Subject: Re: [PATCH] gcc-cross: fix gfortran -> g77 linking logic
Date: Tue, 30 Mar 2010 10:47:00 -0700	[thread overview]
Message-ID: <19c1b8a91003301047o5ccd93e5v32779d478b071825@mail.gmail.com> (raw)
In-Reply-To: <1269958983.6277.37.camel@trini-m4400>

On Tue, Mar 30, 2010 at 7:23 AM, Tom Rini <tom_rini@mentor.com> wrote:
> On Mon, 2010-03-29 at 20:16 +0200, Koen Kooi wrote:
>> From: Koen Kooi <koen@openembedded.org>
>
> Acked-by: Tom Rini <tom_rini@mentor.com>

Looks good.

 Acked-by: Khem Raj <raj.khem@gmail.com>

>
>>
>> ---
>>  recipes/gcc/gcc-configure-cross.inc |   13 +++++++++++++
>>  recipes/gcc/gcc-package-cross.inc   |   14 ++++++++------
>>  2 files changed, 21 insertions(+), 6 deletions(-)
>>
>> diff --git a/recipes/gcc/gcc-configure-cross.inc b/recipes/gcc/gcc-configure-cross.inc
>> index 1c37de8..7dde9de 100644
>> --- a/recipes/gcc/gcc-configure-cross.inc
>> +++ b/recipes/gcc/gcc-configure-cross.inc
>> @@ -51,5 +51,18 @@ do_stage_append () {
>>               sed -i "s|dependency_libs\s*=\s*.*|dependency_libs='-L${CROSS_DIR}/${TARGET_SYS}/$d ${LIBGCCS_VAR} -lc -lm '|" ${CROSS_DIR}/${TARGET_SYS}/$d/libsupc++.la || true
>>               sed -i "s|dependency_libs\s*=\s*.*|dependency_libs='-L${CROSS_DIR}/${TARGET_SYS}/$d ${LIBGCCS_VAR} -lc -lm '|" ${CROSS_DIR}/${TARGET_SYS}/$d/libstdc++.la || true
>>       done
>> +
>> +    # Link gfortran to g77 to satisfy not-so-smart configure or hard coded g77
>> +    # gfortran is fully backwards compatible. This is a safe and practical solution.
>> +    if [ -f ${CROSS_DIR}/bin/${TARGET_PREFIX}gfortran ]; then
>> +           currdir="$PWD"
>> +           cd ${CROSS_DIR}/bin/
>> +           ln -sf ${TARGET_PREFIX}gfortran ${TARGET_PREFIX}g77 || true
>> +           if [ -d ${CROSS_DIR}/${TARGET_SYS}/bin/ ] ; then
>> +               cd ${CROSS_DIR}/${TARGET_SYS}/bin/
>> +               ln -sf gfortran g77 || true
>> +           fi
>> +           cd $currdir
>> +    fi
>>  }
>>
>> diff --git a/recipes/gcc/gcc-package-cross.inc b/recipes/gcc/gcc-package-cross.inc
>> index 6c4f9bb..0f91861 100644
>> --- a/recipes/gcc/gcc-package-cross.inc
>> +++ b/recipes/gcc/gcc-package-cross.inc
>> @@ -63,16 +63,18 @@ do_install () {
>>                 ${TARGET_PREFIX}strip ${D}${target_libdir}/libg2c.so.* || true
>>                 ${TARGET_PREFIX}strip ${D}${target_base_libdir}/libgcc_s.so.* || true
>>                 ${TARGET_PREFIX}strip ${D}${target_libdir}/libgfortran*.so* || true
>> -     fi
>> +       fi
>>
>>         # Link gfortran to g77 to satisfy not-so-smart configure or hard coded g77
>>         # gfortran is fully backwards compatible. This is a safe and practical solution.
>> -       if [ -f ${CROSS_DIR}/bin/${TARGET_PREFIX}gfortran ]; then
>> +       if [ -f ${D}${CROSS_DIR}/bin/${TARGET_PREFIX}gfortran ]; then
>>                currdir="$PWD"
>> -              cd ${CROSS_DIR}/bin/
>> +              cd ${D}${CROSS_DIR}/bin/
>>                ln -sf ${TARGET_PREFIX}gfortran ${TARGET_PREFIX}g77 || true
>> -              cd ${CROSS_DIR}/${TARGET_SYS}/bin/
>> -              ln -sf gfortran g77 || true
>> +              if [ -d ${CROSS_DIR}/${TARGET_SYS}/bin/ ] ; then
>> +                  cd ${CROSS_DIR}/${TARGET_SYS}/bin/
>> +                  ln -sf gfortran g77 || true
>> +              fi
>>                cd $currdir
>> -       fi
>> +        fi
>>  }
>
>
> --
> Tom Rini <tom_rini@mentor.com>
> Mentor Graphics Corporation
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



      reply	other threads:[~2010-03-30 17:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 18:16 [PATCH] gcc-cross: fix gfortran -> g77 linking logic Koen Kooi
2010-03-30  9:24 ` Koen Kooi
2010-03-30 14:23 ` Tom Rini
2010-03-30 17:47   ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19c1b8a91003301047o5ccd93e5v32779d478b071825@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=koen@openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox