From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 3EF6B7C168 for ; Mon, 25 Feb 2019 01:59:43 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id x1P1xgER012104 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 24 Feb 2019 17:59:42 -0800 (PST) Received: from [0.0.0.0] (147.11.105.121) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.435.0; Sun, 24 Feb 2019 17:59:42 -0800 To: Richard Leitner , References: <1550719388-9980-1-git-send-email-fang.jia@windriver.com> From: "Jia, Fang" Message-ID: <1fe84823-ee0b-e93d-f004-e6cc8905eb12@windriver.com> Date: Mon, 25 Feb 2019 10:05:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH 1/2] Revert "base-files: Define JAVA_HOME by default" X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 01:59:43 -0000 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Hi, Thank you so much. Next time will do as your instruction definitely. Thanks again. Regards, Fang On 22/02/2019 16:52, Richard Leitner wrote: > Hi, > thanks for the patch. Looks good to me now. > I'll add it to my tests and will give feedback. > > Nonetheless things to improve for your next contribution: >  a) Please add [meta-java] to the subject >  b) Please version the patchset when it updates an existing one >     on the mailinglist > > Therefore the correct subject prefix for this patchset would have been: >  [oe][meta-java][PATCH V2 1/2] > > No problem for this one as I found it, but please keep an eye on that for the > next time. Thanks. > > regards;Richard.L