Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Stefan Wiehler <stefan.wiehler@missinglinkelectronics.com>,
	 openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] nvme-cli: defer host ID generation to post installation
Date: Sat, 12 Oct 2019 08:37:05 -0700	[thread overview]
Message-ID: <1ff659c05553cc4516ff8a446525d46199c1946a.camel@gmail.com> (raw)
In-Reply-To: <20191012124434.129278-2-stefan.wiehler@missinglinkelectronics.com>

Stefan

Please rebase it on top of latest master and resend please. Since half
of this patch is already merged.

On Sat, 2019-10-12 at 14:44 +0200, Stefan Wiehler wrote:
> Signed-off-by: Stefan Wiehler <
> stefan.wiehler@missinglinkelectronics.com>
> ---
>  meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb b/meta-
> oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb
> index 256d83f03..061c7a0fe 100644
> --- a/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb
> +++ b/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb
> @@ -4,7 +4,7 @@ HOMEPAGE = "https://github.com/linux-nvme/nvme-cli"
>  SECTION = "console/utils"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM =
> "file://LICENSE;md5=8264535c0c4e9c6c335635c4026a8022"
> -DEPENDS = "util-linux util-linux-native"
> +DEPENDS = "util-linux"
>  PV .= "+git${SRCPV}"
>  
>  SRC_URI = "git://github.com/linux-nvme/nvme-cli.git"
> @@ -15,15 +15,18 @@ S = "${WORKDIR}/git"
>  inherit bash-completion systemd
>  
>  do_install() {
> -    oe_runmake install DESTDIR=${D} PREFIX=${prefix} \
> +    oe_runmake install-spec DESTDIR=${D} PREFIX=${prefix} \
>          UDEVDIR=${nonarch_base_libdir}/udev
> SYSTEMDDIR=${systemd_unitdir}
>  }
>  
>  pkg_postinst_ontarget_${PN}() {
>      ${sbindir}/nvme gen-hostnqn > ${sysconfdir}/nvme/hostnqn
> +    ${bindir}/uuidgen > ${sysconfdir}/nvme/hostid
>  }
>  
>  PACKAGES =+ "${PN}-dracut ${PN}-zsh-completion"
>  
>  FILES_${PN}-dracut = "${libdir}/dracut/dracut.conf.d"
>  FILES_${PN}-zsh-completion = "${datadir}/zsh/site-functions"
> +
> +RDEPENDS_${PN} = "util-linux-uuidgen"
> -- 
> 2.19.2
> 



  reply	other threads:[~2019-10-12 15:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09 15:19 [meta-oe][PATCH] nvme-cli: Use install-spec target Khem Raj
2019-10-12 12:44 ` [meta-oe][PATCH] nvme-cli: defer host ID generation to post installation Stefan Wiehler
2019-10-12 12:44   ` Stefan Wiehler
2019-10-12 15:37     ` Khem Raj [this message]
2019-10-15  6:56       ` [meta-oe][PATCH v2] " Stefan Wiehler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ff659c05553cc4516ff8a446525d46199c1946a.camel@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=stefan.wiehler@missinglinkelectronics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox