Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Holger Freyther <zecke@selfish.org>
To: openembedded-devel@lists.openembedded.org
Subject: [sanity.bbclass] Make the mmap min_addr check not depend on arm
Date: Tue, 28 Oct 2008 22:27:45 +0100	[thread overview]
Message-ID: <200810282227.45943.zecke@selfish.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

Hey,

I have the following in the OM git tree that was needed to build ecj-initial. 
Robert I would appreciate if you could comment if that is still needed and 
Richard can you agree to such a change?

z.

[-- Attachment #2: sanity.bbclass --]
[-- Type: text/plain, Size: 1420 bytes --]

commit 6f11296d1bdf022443763a02b0cf2d808cbad19a
Author: Holger Hans Peter Freyther <zecke@openmoko.org>
Date:   Mon Jul 21 10:27:57 2008 +0200

    [sanity] Move the mmap_min_addr check out of arch == arm as ecj-initial fails
        This check is not arm specific. An ordinary ecj-initial will fail with
        mmap'ing and classpath-native can not be build then.

diff --git a/classes/sanity.bbclass b/classes/sanity.bbclass
index 883c0e5..4e33616 100644
--- a/classes/sanity.bbclass
+++ b/classes/sanity.bbclass
@@ -98,11 +98,11 @@ def check_sanity(e):
 			if not check_app_exists("qemu-arm", e.data):
 				messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH"
 
-		if os.path.exists("/proc/sys/vm/mmap_min_addr"):
-			f = file("/proc/sys/vm/mmap_min_addr", "r")
-			if (f.read().strip() != "0"):
-				messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n"
-			f.close()
+	if os.path.exists("/proc/sys/vm/mmap_min_addr"):
+		f = file("/proc/sys/vm/mmap_min_addr", "r")
+		if (f.read().strip() != "0"):
+			messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu and ecj so please fix the value (as root).\n"
+		f.close()
 
 	for util in required_utilities.split():
 		if not check_app_exists( util, e.data ):

                 reply	other threads:[~2008-10-29 11:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810282227.45943.zecke@selfish.org \
    --to=zecke@selfish.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox