Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@datenfreihafen.org>
To: openembedded-devel@lists.openembedded.org
Subject: [RFC] Ship dbus config and dbus service activation files
Date: Thu, 11 Dec 2008 00:49:10 +0100	[thread overview]
Message-ID: <20081210234910.GA16050@excalibur.local> (raw)

Hello.

While playing to get connman 0.1 running I found that we don't ship two files in
the wpa-supplicant that come in handy.

/etc/dbus-1/system.d/dbus-wpa_supplicant.conf

That one is really needed. Without it a wpa-supplicant -u barks out about wrong
security.

/usr/share/dbus-1/system-services/dbus-wpa_supplicant.service

This one is a nice-to-have. It allows autostart the service with the service
activation infrastructure from dbus. If a bus name listed in such a file is
called and not available it gets started the way described in this file.

The following patch i nstalls the files correctly for me. Never used FILES_${PN}
before so I would like to get some review before.

diff --git a/packages/wpa-supplicant/wpa-supplicant-0.6.inc b/packages/wpa-supplicant/wpa-supplicant-0.6.inc
index 6198958..779bee7 100644
--- a/packages/wpa-supplicant/wpa-supplicant-0.6.inc
+++ b/packages/wpa-supplicant/wpa-supplicant-0.6.inc
@@ -59,7 +59,14 @@ do_install () {
 	install -d ${D}${sysconfdir}/wpa_supplicant
 	install -m 755 ${WORKDIR}/ifupdown.sh ${D}${sysconfdir}/wpa_supplicant/
 	install -m 755 ${WORKDIR}/functions.sh ${D}${sysconfdir}/wpa_supplicant
-	
+
+	install -d ${D}/${sysconfdir}/dbus-1/system.d
+	install -m 644 ${S}/dbus-wpa_supplicant.conf ${D}/${sysconfdir}/dbus-1/system.d
+	install -d ${D}/${datadir}/dbus-1/system-services
+	install -m 644 ${S}/dbus-wpa_supplicant.service ${D}/${datadir}/dbus-1/system-services
+
 	ln -s /etc/wpa_supplicant/ifupdown.sh ${D}${sysconfdir}/network/if-pre-up.d/wpasupplicant
 	ln -s /etc/wpa_supplicant/ifupdown.sh ${D}${sysconfdir}/network/if-post-down.d/wpasupplicant
 }
+
+FILES_${PN} += "${datadir}/dbus-1/system-services/*"
diff --git a/packages/wpa-supplicant/wpa-supplicant_0.6.0.bb b/packages/wpa-supplicant/wpa-supplicant_0.6.0.bb
index d20ccaa..11fc774 100644
--- a/packages/wpa-supplicant/wpa-supplicant_0.6.0.bb
+++ b/packages/wpa-supplicant/wpa-supplicant_0.6.0.bb
@@ -1,3 +1,3 @@
 require wpa-supplicant-0.6.inc
 
-PR = "r1"
+PR = "r2"
diff --git a/packages/wpa-supplicant/wpa-supplicant_0.6.3.bb b/packages/wpa-supplicant/wpa-supplicant_0.6.3.bb
index d20ccaa..11fc774 100644
--- a/packages/wpa-supplicant/wpa-supplicant_0.6.3.bb
+++ b/packages/wpa-supplicant/wpa-supplicant_0.6.3.bb
@@ -1,3 +1,3 @@
 require wpa-supplicant-0.6.inc
 
-PR = "r1"
+PR = "r2"

Anyone objections?

regards
Stefan Schmidt



             reply	other threads:[~2008-12-10 23:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10 23:49 Stefan Schmidt [this message]
2008-12-11  0:16 ` [RFC] Ship dbus config and dbus service activation files Thomas Kunze
2008-12-11  0:33   ` Stefan Schmidt
2008-12-11 13:29     ` Stefan Schmidt
2008-12-11  0:37   ` Michael 'Mickey' Lauer
2008-12-11  0:55     ` Mike (mwester)
2008-12-11  1:07       ` Michael 'Mickey' Lauer
2008-12-11  7:48         ` Koen Kooi
2008-12-11  7:47       ` Koen Kooi
2008-12-11 12:31         ` Mike (mwester)
2008-12-11 12:42           ` Koen Kooi
2008-12-11 12:45           ` Koen Kooi
2008-12-11 13:06           ` Andrea Adami
2008-12-11 13:31             ` Stefan Schmidt
2008-12-11  8:45   ` Koen Kooi
2008-12-11  9:37     ` Andrea Adami
2008-12-11 10:07       ` Koen Kooi
2008-12-11 13:22       ` Stefan Schmidt
2008-12-11 13:38         ` Graeme Gregory
2008-12-11 13:55           ` Stefan Schmidt
2008-12-11 14:33             ` Graeme Gregory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081210234910.GA16050@excalibur.local \
    --to=stefan@datenfreihafen.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox