Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: openembedded-devel@openembedded.org
Subject: Re: RFC: "Virtual" native and sdk recipes
Date: Fri, 16 Jan 2009 19:54:34 -0700	[thread overview]
Message-ID: <20090117025434.GS6710@smtp.west.cox.net> (raw)
In-Reply-To: <20090114231705.GG6710@smtp.west.cox.net>

On Wed, Jan 14, 2009 at 04:17:05PM -0700, Tom Rini wrote:
> On Tue, Jan 13, 2009 at 06:15:39PM -0700, Tom Rini wrote:
> > On Fri, Jan 09, 2009 at 12:54:50AM +0000, Richard Purdie wrote:
> > > On Fri, 2009-01-02 at 01:11 +0000, Richard Purdie wrote:
> > > > I just had a look through the trini/canadian-sdk branch and there are
> > > > bits I like and bits I dislike. I'll try and provide some feedback in
> > > > due course with a view to getting the less controversial bits merged. I
> > > > have some tweaks in poky to do with dynamic library extension handling
> > > > for example (from playing with darwin targets) where it would pay us to
> > > > find a common solution.
> > > 
> > > Sorry for the delayed feedback, what I've looked at so far follows
> > > below. It was easiest to extract some patches from your tree and make
> > > some commits of my own so these are in:
> > > 
> > > http://git.openembedded.net/?p=openembedded.git;a=shortlog;h=refs/heads/rpurdie/canadian-sofar
> > > 
> > > Basically I wanted to particularly review the changes to the existing OE
> > > core classes/bitbake.conf. The changes in that branch are versions I'm
> > > happy with. I had two concerns there:
> > > 
> > > 1. I don't want to see ${HOST_EXEEXT} everywhere but I know why you 
> > >    need it and this was something OE would inevitably face. As a 
> > >    compromise I propose adding:
> > > 
> > >    EXEEXT = "${HOST_EXEEXT}"
> > > 
> > >    and using ${EXEEXT} which is fractionally less ugly for all common 
> > >    uses. Could you update your patch to use ${EXEEXT} please assuming 
> > >    we all agree on this. Its the same dilemma as the SOLIBS stuff I 
> > >    have with Darwin :/
> > > 
> > > 2. All the bb.data.inherits_class() stuff is ugly as sin and totally 
> > >    unreadable. My series has a better patch.
> > > 
> > > Moving on to the rest of the code, I don't see a problem merging any of
> > > the totally new files. How about the following merge process:
> > > 
> > > a) We push my tree into OE
> > 
> > My git-fu is weak and since we can't delete remote branches without
> > bugging someone, can we do this step?  I've got...
> > 
> > > b) You rebase onto my tree's changes and adjust the EXEEXT stuff.
> > > 
> > > c) You add changes which add the EXEEXT changes only to existing 
> > >    recipes and commit that.
> > > 
> > > d) The checksums.ini changes are a no brainer.
> > > 
> > > e) You start adding the totally new files to OE directly in a logical 
> > >    sequence of something like:
> > > 
> > >    i) Add canadian core classes (classes/canadian*)
> > >    ii) Add mingw new recipes
> > >    iii) Add misc support recipes (gmp/mprf-canadian)
> > >    iv) Add new binutils recipes
> > >    v) Add new gcc recipes
> > 
> > ... this done locally, mostly, in quilt.
> 
> Making more noise as I'm thinking on Friday I'll just merge RP's branch
> to mainline.

I'm fairly certian my git-fu did not fail and this has been done.  I'll
make branch of e-i -> e-v soon I hope (painting in the new house this
weekend).

-- 
Tom Rini



  reply	other threads:[~2009-01-17  3:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-01 16:25 RFC: "Virtual" native and sdk recipes Richard Purdie
2009-01-01 18:11 ` Koen Kooi
2009-01-01 20:07   ` Richard Purdie
2009-01-01 18:25 ` Tom Rini
2009-01-01 20:11   ` Richard Purdie
2009-01-01 22:02     ` Tom Rini
2009-01-02  1:11       ` Richard Purdie
2009-01-02  4:37         ` Native/Cross/SDK rethink (Was: Re: RFC: "Virtual" native and sdk recipes) Tom Rini
2009-01-05 14:31           ` Esben Haabendal
2009-01-05 15:42             ` Tom Rini
2009-01-05 17:29             ` Koen Kooi
2009-01-05 19:53               ` Tom Rini
2009-01-06 20:51               ` Esben Haabendal
2009-01-07  0:14                 ` Richard Purdie
2009-01-07  0:45                   ` Tom Rini
2009-01-08 22:59                   ` Leon Woestenberg
2009-01-09  0:54         ` RFC: "Virtual" native and sdk recipes Richard Purdie
2009-01-09  1:16           ` Tom Rini
2009-01-12 19:09             ` Tom Rini
2009-01-12 20:30             ` Esben Haabendal
2009-01-09 17:04           ` Tom Rini
2009-01-12 20:47             ` Tom Rini
2009-01-10 15:33           ` Tom Rini
2009-01-10 19:06             ` Tom Rini
2009-01-14  1:15           ` Tom Rini
2009-01-14 23:17             ` Tom Rini
2009-01-17  2:54               ` Tom Rini [this message]
2009-01-17  4:47           ` Tom Rini
2009-01-22 18:10             ` Tom Rini
2009-01-28 19:49               ` Tom Rini
2009-01-01 22:15 ` Tom Rini
2009-01-01 23:19 ` Richard Purdie
2009-01-03 11:17   ` Richard Purdie
2009-01-02 12:58 ` Koen Kooi
2009-01-14  0:03 ` Robert Schuster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090117025434.GS6710@smtp.west.cox.net \
    --to=trini@kernel.crashing.org \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox