From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: Bug in kernel-arch.bbclass
Date: Thu, 26 Mar 2009 21:16:52 -0700 [thread overview]
Message-ID: <200903262116.57707.raj.khem@gmail.com> (raw)
In-Reply-To: <20090324093519.GA6521@rhein.zuhause.netz>
[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]
On Tuesday 24 March 2009 02:35:20 Henning Heinold wrote:
> Hi,
>
> while compiling 2.6.28 for wrap board(geodegx) I noticed that the asm-headers didnt install into staging.
> After examine kernel-arch.bbclass and kernel.bblcass I found the following lines
>
> kernel-arch.bbclass
>
> def map_kernel_arch(a, d):
> import bb, re
>
> valid_archs = bb.data.getVar('valid_archs', d, 1).split()
>
> if re.match('(i.86|athlon)$', a): return '386'
> elif re.match('arm26$', a): return 'arm26'
> elif re.match('armeb$', a): return 'arm'
> elif re.match('mipsel$', a): return 'mips'
> elif re.match('sh(3|4)$', a): return 'sh'
> elif re.match('bfin', a): return 'blackfin'
> elif a in valid_archs: return a
> else:
> bb.error("cannot map '%s' to a linux kernel architecture" % a)
>
> export ARCH = "${@map_kernel_arch(bb.data.getVar('TARGET_ARCH', d, 1), d)}"
>
>
> kernel.bbclass
>
> kernel_do_stage() {
> ASMDIR=`readlink include/asm`
>
> mkdir -p ${STAGING_KERNEL_DIR}/include/$ASMDIR
> cp -fR include/$ASMDIR/* ${STAGING_KERNEL_DIR}/include/$ASMDIR/
> # Kernel 2.6.27 moved headers from includes/asm-${ARCH} to arch/${ARCH}/include/asm
> if [ -e arch/${ARCH}/include/asm/ ] ; then
> cp -fR arch/${ARCH}/include/asm/* ${STAGING_KERNEL_DIR}/include/$ASMDIR/
> install -d ${STAGING_KERNEL_DIR}/arch/${ARCH}/include
> cp -fR arch/${ARCH}/* ${STAGING_KERNEL_DIR}/arch/${ARCH}/
>
> As you can see this can not work because the ARCH-variable is set to 386 and so the "-e arch/${ARCH}/include/asm/"
> is not true. For backward compatiblity I attached a patch, which covers this problem.
>
> Is this okay for checkin?
your patch installs like old dir structure, I wonder if it should install in arch/$ARCH/include too
>
>
> Bye Henning
>
--
Khem Raj
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 204 bytes --]
prev parent reply other threads:[~2009-03-27 4:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 9:35 Bug in kernel-arch.bbclass Henning Heinold
2009-03-27 4:16 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903262116.57707.raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox