Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: update hook for git to check push commit message
Date: Thu, 28 Jan 2010 17:30:29 -0800	[thread overview]
Message-ID: <20100129013029.GA6136@gmail.com> (raw)
In-Reply-To: <1264715530.9974.436.camel@lenovo.internal.reciva.com>

On (28/01/10 21:52), Phil Blundell wrote:
> On Thu, 2010-01-28 at 12:00 -0800, Khem Raj wrote:
> > Attached is a small hook for updates that are pushed into repo.
> > Right now it only checks the first line of the commit and expects
> > module: summary
> 
> I'm not really in favour of applying the commit message policy quite
> that harshly.  The wiki page that you linked to doesn't really seem to
> support this kind of check: the actual guidance it gives about checkin
> messages is:

Thats true. However I have seen many devs complain about the module:
summary. That was my motivation. 

> 
> * Have a clear commit message (example):
>     - The first line of commit is a summary of the changes.
>     - The first line should start with the name of the recipe the change affects.
>     - The rest of the message should give more details on the change as appropriate.
>     - Mention the affected bug numbers if appropriate.
>     - Give credit where credit is due. If you commit someone else's work more or 
>       less verbatim, you should use git commit --author $mail-of-author. If pulling
>       changes from somewhere like Poky or OpenMoko there is no problem with that
>       but mention where the changes came from.
>     - Include a Signed-off-by: line indicating the change has valid certificate 
>       of origin as per the Linux kernel
> 
> ... which is nowhere near as prescriptive as the rule that you seem to
> be implementing in your script.  Also, the wiki page has an explicit
> statement that "[these] rules are not hard fast rules", which would
> suggest that even such guidance as it does provide is not intended to be
> taken too dogmatically. 
> 
> Personally I think that the current situation of the TSC applying
> pressure to those people who seem to be chronically unable to write
> suitable checkin comments is a perfectly fine way of solving the
> problem.

Probably it could help developers to check the commit messages on their own
by making this as post commit or pre push hook of some sort in their clones .git/hooks

> 
> On a technical level, I think you could probably do without the sed
> subprocess, and "summary = rev.split(1)" doesn't look quite right
> either.

true. I could have got it if I have tested it. The check for : should also
be inverted.




  parent reply	other threads:[~2010-01-29  1:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 20:00 update hook for git to check push commit message Khem Raj
2010-01-28 21:52 ` Phil Blundell
2010-01-28 22:01   ` Frans Meulenbroeks
2010-01-29  0:26     ` Paul Menzel
2010-01-29  1:30   ` Khem Raj [this message]
2010-01-28 22:59 ` Tom Rini
2010-01-28 23:22   ` Chris Larson
2010-01-29  0:10     ` Tom Rini
2010-01-29  8:21     ` Jens Seidel
2010-01-29  9:15       ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100129013029.GA6136@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox