Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] ffmpeg: Stage `avconfig.h` which is built at compile time.
Date: Tue, 16 Mar 2010 11:42:51 +0100	[thread overview]
Message-ID: <20100316104251.GD29306@jama> (raw)
In-Reply-To: <ac9c93b11003160258m2433be87s9794def341e14fc1@mail.gmail.com>

On Tue, Mar 16, 2010 at 10:58:39AM +0100, Frans Meulenbroeks wrote:
> 2010/3/16 Paul Menzel <paulepanter@users.sourceforge.net>:
> > This header is needed for `libvalhalla`.
> >
> > Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> > ---
> > Could someone please test this with `ffmpeg_0.4.9-pre1.bb` as it includes `ffmpeg.inc` too.
> > ---
> >  recipes/ffmpeg/ffmpeg.inc |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/recipes/ffmpeg/ffmpeg.inc b/recipes/ffmpeg/ffmpeg.inc
> > index cd330f8..437a822 100644
> > --- a/recipes/ffmpeg/ffmpeg.inc
> > +++ b/recipes/ffmpeg/ffmpeg.inc
> > @@ -61,6 +61,8 @@ do_stage() {
> >            install -m 0644 ${S}/libavutil/$h        ${STAGING_INCDIR}/ffmpeg/$h
> >            install -m 0644 ${S}/libavutil/$h        ${STAGING_INCDIR}/libavutil/$h
> >         done
> > +        install -m 0644 ${B}/libavutil/avconfig.h ${STAGING_INCDIR}/ffmpeg/
> > +        install -m 0644 ${B}/libavutil/avconfig.h ${STAGING_INCDIR}/libavutil/
> >
> >         install -d ${STAGING_INCDIR}/libswscale/
> >         install -m 0644 ${S}/libswscale/*.h ${STAGING_INCDIR}/ffmpeg/
> > --
> > 1.7.0
> >
> 
> It might be better to try to move to the new default staging (by
> removing the do_stage and testing whether it installs the required
> things in staging).

I agree it would be better, but right now it fixes mplayer build, so I
would like to push it as-is + INC_PR bump.

Regards,

-- 
uin:136542059                jid:Martin.Jansa@gmail.com
Jansa Martin                 sip:jamasip@voip.wengo.fr 
JaMa                         



      reply	other threads:[~2010-03-16 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16  9:49 [PATCH] ffmpeg: Stage `avconfig.h` which is built at compile time Paul Menzel
2010-03-16  9:58 ` Frans Meulenbroeks
2010-03-16 10:42   ` Martin Jansa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100316104251.GD29306@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox