From: Stefan Schmidt <stefan@datenfreihafen.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] u-boot_git.bb: add xilinx-ml507 support
Date: Sun, 21 Mar 2010 12:28:54 +0100 [thread overview]
Message-ID: <20100321112854.GB7325@excalibur.local> (raw)
In-Reply-To: <1269019049-25807-1-git-send-email-aalonso00@gmail.com>
Hello.
The first part, PR and SRCREV, is obviously fine. The second part raises a
question here. If it is preferred to have the xparameters header file from the
BSP would it make more sense to have it in OE? Be it a package or just the file.
The patch also has the problem that it does not work if XILINX_BSP_PATH is not
set. Your test in deploy if the directory exists triggers this here:
NOTE: Running task 1042 of 1048 (ID: 11,
/home/stefan/Projekte/OpenEmbedded/build/openmoko/openembedded/recipes/u-boot/u-boot_git.bb,
do_deploy)
ERROR: function do_deploy failed
ERROR: log data follows
(/home/stefan/Projekte/OpenEmbedded/build/openmoko/tmp/work/xilinx-ml507-angstrom-linux/u-boot-git-r43/temp/log.do_deploy.19446)
| NOTE: Installing u-boot elf image in bsp path
| install: cannot create regular file `/u-boot': Permission denied
The variable is empty and test thinks that is fine and wants to install the
u-boot into / as no other path is set. Please fix, resend and I'll apply it.
regards
Stefan Schmidt
next prev parent reply other threads:[~2010-03-21 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 17:17 [PATCH] u-boot_git.bb: add xilinx-ml507 support Adrian Alonso
2010-03-21 11:28 ` Stefan Schmidt [this message]
2010-03-22 17:21 ` Adrian Alonso
2010-03-22 17:40 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321112854.GB7325@excalibur.local \
--to=stefan@datenfreihafen.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox