Re: [PATCH] Add locking on tasks that add package_update_index_ipk

[Roman I Khimov <roman@khimov.ru>]

[-- Attachment #1: Type: Text/Plain, Size: 1429 bytes --]

В сообщении от Суббота 05 июня 2010 04:03:59 автор Tom Rini написал:
> We add a lockfile of do_populate_sdk and do_rootfs (in rootfs_ipk) that
> is also the lockfile that package_update_index_ipk uses.  With enough
> threads it is possible that one image (or meta-toolchain) is attempting
> to use the package index while another has only reached the point of
> generating the index leading to an empty index being seen later on.

Am I right that effectively it makes rootfs creation sequential? It's bad for 
performance. Probably it's time to fix ipkg-make-index to not touch index 
files if no new packages are found as was suggested some time ago:

http://patchwork.openembedded.org/patch/744/

But thinking about it a bit more, ipkg-make-index hack won't really fix the 
issue in this case, as we can have image A with a set of packages, image B 
with a similar set of packages plus additional package P and then A would do 
package_update_index_ipk and enter do_rootfs, then P gets completed, 
package_update_index_ipk for B is started and the package index really needs 
an update, thus things can break again.

Maybe it's easier to make those indexes per-image for performance.

Well,

Acked-by: Roman I Khimov <khimov@altell.ru>

for now.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]