Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [RFC] kernel NOTE messages fix
Date: Wed, 29 Sep 2010 14:37:00 -0400	[thread overview]
Message-ID: <20100929183700.GB27217@denix.org> (raw)
In-Reply-To: <AANLkTinMWT7K-h+hH0LvPD119Nxxpitro=f6igQvL7-K@mail.gmail.com>

On Tue, Sep 28, 2010 at 06:39:42PM +0200, Frans Meulenbroeks wrote:
> Dear all,
> 
> 3) copy the files directly from the work area to staging. That way
> there are no unpackaged files in image/ so no NOTE messages.
> Additional advantage is that it is faster as we save the copy to the image dir.
> 
> The following patch makes (3) happen:
> 
> diff --git a/classes/kernel.bbclass b/classes/kernel.bbclass
> index 5f8bc8a..05ddcc1 100644
> --- a/classes/kernel.bbclass
> +++ b/classes/kernel.bbclass
> @@ -121,7 +121,12 @@ kernel_do_install() {
>                  oe_runmake SUBDIRS="scripts/genksyms"
>          fi
> 
> -       kerneldir=${D}/kernel/
> +
> +}
> +
> +sysroot_stage_all_append() {
> +
> +        kerneldir=${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
> 
>         if [ -e include/asm ] ; then
>                 # This link is generated only in kernel before
> 2.6.33-rc1, don't stage it for newer kernels
> @@ -197,12 +202,7 @@ kernel_do_install() {
>         install -m 0644 System.map $kerneldir/System.map-${KERNEL_VERSION}
>         [ -e Module.symvers ] && install -m 0644 Module.symvers $kerneldir/
> 
> -       cp -fR scripts $kerneldir/
> -}
> -
> -sysroot_stage_all_append() {
> -       sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}

BTW, won't this patch break packaged-staging? Has anyone tried rebuilding from 
pstage after this fix?

> -       cp -fpPR ${D}/kernel/.config ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
> +       cp -fR scripts $kerneldir/
>  }
> 
>  kernel_do_configure() {

-- 
Denys



  parent reply	other threads:[~2010-09-29 18:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 16:39 [RFC] kernel NOTE messages fix Frans Meulenbroeks
2010-09-28 17:04 ` Denys Dmytriyenko
2010-09-28 17:15 ` Roman I Khimov
2010-09-28 20:06 ` Tom Rini
2010-09-28 21:16   ` Petr Štetiar
2010-09-28 21:14 ` Petr Štetiar
2010-09-29  6:34 ` Eric Bénard
2010-09-29  6:46   ` Frans Meulenbroeks
2010-09-29 18:18     ` Tom Rini
2010-09-29 18:37 ` Denys Dmytriyenko [this message]
2010-09-29 20:16   ` Frans Meulenbroeks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100929183700.GB27217@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox